[Script] Highlights for Segments & Landmarks - v1.5 Nov 16

[iainhouse]

Fixed saving of options when leaving the editor

Fantastic! It's been so annoying having to remember to turn "un-terminated" back on after every refresh.

Highlight landmarks when a specific city is selected

The highlighting seems to be "sticky": if I turn on city highlighting, the landmarks don't highlight until I mouseover them. Similarly, if I turn the highlighting off, I have to mouseover again to un-highlight the landmark.

Zooming in doesn't make the highlights change. Panning a short distance away and back again (1 screen horizontally) doesn't change it, but panning 2 screens away and then back does work.

[svx-biker]

Any reason a Level(1) Editor should not see unterminated roads and node problems?

We have quite some new editors that don't put end nodes initially and when I show them the Highlight Script they dont see unterminated roads and Node Problems.

[dave3825us]

Any reason a Level(1) Editor should not see unterminated roads and node problems?

We have quite some new editors that don't put end nodes initially and when I show them the Highlight Script they dont see unterminated roads and Node Problems.

I agree. living in an area that does not get many user reported problems daily, it would take one forever to reach a higher editing level. I was using the junction node fixer and it is not working any longer for me. I have a thread going in the end of the junction node fixer thread.
She just stopped working...

[Timbones]

Any reason a Level(1) Editor should not see unterminated roads and node problems?

I'm nervous about inexperienced editors being able to understand the node problems, so I'll keep those hidden under Advanced Options for now. I will move the 'Unterminated Roads' highlight up to the main options though.

The highlighting seems to be "sticky": if I turn on city highlighting, the landmarks don't highlight until I mouseover them. Similarly, if I turn the highlighting off, I have to mouseover again to un-highlight the landmark.

Fixed.

New beta version here: v1.5.8!

[Timbones]

A minor fix was uploaded today (same version) to fix a bug that affected non-AMs.

Final call for feedback for this beta...


via mobile

[iainhouse]

Final call for feedback for this beta...

I checked the landmark highlighting issue and that's now working fine.

There is another issue that has gone back a few versions, but I'm not sure how far or if it's connected to the beta versions. I have been seeing a weird problem that I have only now made the effort to pin down.

Whenever I refresh the browser or go to a favorite or hit permalink, I find that the roads & aerials layers are shifted horizontally by a few pixels:

offset.gif (4.87 KiB) Viewed 359 times

In this image you can see that the highlights appear to the right of the road images. Also, the cyan segment highlight where I have moved the mouse over a segment is offset. Although this image doesn't include the aerials, they are lined up with the road images. If I pan the map, the road & aerial images will then shift to the right, lining up with the highlights and actual selectable segments.

After disabling all other scripts and then re-enabling them one at a time, I have pinned it down to an interaction with Twister_UK's WMEOpenData script (both versions 1.14 and 1.15). If I disable that script, the offset behaviour does not happen.

It's not a biggie - I've got used to panning a bit immediately after following a link or refreshing - but I thought I'd better mention it. When I've posted this, I'll post a link to it in the topic for WMEOpenData.

[Twister_UK]

Iain, please try the 1.15.1 update I've just posted - although I wasn't able to replicate the problem you've described, I did find something in 1.14 and 1.15 which has the potential to cause it.

[iainhouse]

Iain, please try the 1.15.1 update I've just posted - although I wasn't able to replicate the problem you've described, I did find something in 1.14 and 1.15 which has the potential to cause it.

By George, I think he's got it!

That was it. I've noticed that scrollbar appearing as well, but I didn't connect the dots.

[bz2012]

Measles seems to have disappeared. The revcon/softcon/u-con colored nodes are missing.

Disregard. Seems to be back after I disabled all extension and then re-enabled them.

[mike0723]

It seems the green for un-connected roads only shows when the segment has City/State filled in. Otherwise, it is gray.

Anyone else notice this, or is it just me?

I am using v1.5.8