[Script] WME UR-MP Tracking

This sounds to me like a problem that’s also affecting Toolbox - specifically highlighting of segment elevations. After saving edits, you’ll find that many segments are highlighted as having non-ground elevation. If you select these segments, the elevation value will be missing. It’s necessary to use the refresh button in the layers menu - generally at least twice - to get the missing values to appear.

It’s been said over in the Toolbox thread that this is due to recent changes in JNF. JNF is not the cause of the problem - just the opposite. It seems that JNF was forcing a data reload after saving to get around this problem, which is inherent to WME. The most recent version of JNF (which is also incorporated within Toolbox) removed this feature to see if WME was still working poorly - and it is.

Back to the true hero of this thread - UR-MP Tracker. This problem does affect the script in one way. If you comment on a UR and hit “send”, this doesn’t require saving. Re-targeting the UR in the UR-MP list does not update the number of comments. URO+ is similarly affected - the comment count bubble doesn’t increase/appear. Until you refresh the page or use the layer reload.

However, the original problem mentioned (closed URs not showing green/being hidden by UR-MP) may still be due to the way the script works, rather than the WME bug. The data that goes into the UR-MP lists is only updated by 3 things: a manual scan, having “Auto scan” turned on or “targeting” a UR in the list. I generally manually scan the country once a week and run with auto scan turned off. So, as I get to the end of the week, more and more of the non-green URs I select in the list turn out to be solved when I target them.

Apologies for slightly derailing the thread again…

Ahh… you’ve pretty much got it. On a WME session load, comment data for all the visible URs gets loaded into W.model.updateRequestSessions, which seems like a convenient way for our scripts to gain access to all of this data. Wrong.

Having now run a debug session with HTTP request logging enabled, I see that each time you click on a UR, WME performs a new request for the UR comment data, and uses the data returned by that request, rather than the cached data in W.m.uRS, to populate the comment list within the UR window.

Similarly, each time you send a new comment, WME immediately posts it to the server whilst also maintaining a local copy of it within whatever data structures are used by the UR window.

However, neither the initial request for the latest comment data, nor any of the subsequent comment update posts back to the server, cause the cached data in W.m.uRS to be updated.

So whilst WME always knows what the correct comment count is for a UR at the point in time when it needs to know that information (i.e. when it’s displaying the comments), this information is not available anywhere within the global WME data structures we can access ourselves. W.m.uRS therefore appears to be pretty much useless - the only time we can be certain it contains valid data is immediately following a WME session reload, and since WME itself doesn’t seem to be using it then I have to wonder why it even exists…

Ssshhh! They might hear you and remove it - then we’ll really be stuffed. :lol:

Thanks for keeping this topic alive during my AFK time :slight_smile:
All answers are good!

To precise a little bit:

  • no plan for places updates: not enough time for that. It is at the bottom of my todo list
  • update comments: there is a bug pointed by twister-UK. I will fix it ‘soon’
  • as twister-UK said, some data has moved from the data structure to the GUI of WME, and it is hard for us to find the good information at the good time…

v2.0.2: bugfix: update UR once you post a comment. Thank to Twister-UK.

I’d love to see this tool track, for visited URs, the last date/time I visited, and be able to sort the list on that so I can go back and visit URs that I’ve recently updated.

@Alan.

Not sure if this is the answer you want but does this not get you what you want:

Check Hide without comment for me
Make sure Hide visited isn’t selected

and the sort by the last reply. The chat box looking thing in the second column (the bottom one). I know it doesn’t give you the date but should show the age of the last reply.

I will give this a try!

Request: turn off the refresh of URs. The issue I have is cosmetic, but it can be confusing. I do not use auto-save because I often want to add another note before sending. If I use a “Solved” response and hit send. The UR is marked as Solved, but the refresh changes the visual display back to non-resolved because the UR hasn’t been saved yet.

UPDATE: This also causes any segments you have drawn but not saved, to disappear from the map, though the save counter still shows the edit. You have to save and then continue on the roads when they reappear after the refresh.

The reload of features should not be allowed when there are unsaved changes. The Waze code should actually force that. But since it doesn’t…

V2.1:

  • bugfix: edits lost after sending a comment (thanks to AlanOfTheBerg)
  • Add filter: “hide last comment from an editor” (let you deal pending UR)

Thanks again for this. It works perfectly.

Problem I am seeing: when another editor adds a comment or closes a UR in my area while I am online, when I click on the URMP target icon to take me to the UR, it doesn’t update the comment count, or if closed now, that the UR is closed. If I close the UR window and then click on the Closed UR manually, it seems to update that, but if I manually click on a UR with new comments, the comment count does not increase, nor does the “days since last comment.”

It would be nice if these both updated even when clicking the URMP target button.

Also, it would be nice if it detected when the UR had disappeared from the map completely. Sometimes I click to visit a UR and there’s nothing at all to be found at the location. I have to periodically clear all my data and recrawl my area (which isn’t a bad thing, nor difficult).

Yes, I get this too. I think this is a UR which has been closed > 7 days. URMP won’t remove it automatically. Maybe part of the “can’t prove a negative” logic? :slight_smile: Clearing out the data isn’t a bad thing, I also agree.

… button that clear data? with “exclude ignored” option :wink:

odeslano z telefonu

I must be missing something with this script. I have Auto scan checked and the only scan area I have is “editable area”. When I first load my browser and WME I assume it scans my area. However, as I scroll around I see URs that were not on the UR-MP list until I scrolled by them. Even clicking to manually scan doesn’t help. I would think that if it scans my editable area (AM area) it would find all URs. Am I doing something wrong?

Editable area is a defined area. My editable area is the country, but URMP certainly doesn’t scan the entire US when it scans. Editable area is probably much smaller.

What I think you might you want to do is define some areas under the Areas tab.

Editable area covers some miles either side of where you have driven, and does NOT include your managed area.

It would be nice if there was a separate scan for ‘Managed area(s)’. In the meantime you can add your own custom area that covers the bit you manage.

Auto Scan simply refreshes data from the URs that are visible on the map. As you move around, it finds more.

PS: here are some tips I wrote for my local community:
https://www.waze.com/forum/viewtopic.php?t=127598

Thanks for the info Alan and Timbones. I obviously had some misconceptions about how it works.

Waze have updated the editor today. And UR_MP_Tracker no longer works. :cry: :cry:
Specifically, on Firefox, it doesn’t even appear on the list of scripts in the left-hand panel.

I know editor upgrades are the bane of script-writers’ lives, but do you have any idea how long this one is going to take to fix? Twister_UK has the URO+ script working (so far as I know), so may be able to help relocate any changed data.

Ian