[Template update] Rank

Moderators: MapSir, USA Champs

[Template update] Rank

Postby ldriveskier » Fri Jan 19, 2018 5:08 pm

Related to the new permissions system and changes on the Editing restrictions page, the Rank template needs some new fields defined. I'd like to propose the following fields (Parameter, Result, Description):

SegmentDelete, 2, The minimum editor rank to delete a segment not created by themselves
DT, 3, The minimum editor rank to set a difficult turn
URClose, 2, The minimum editor rank to close an Update Request
[ img ][ img ][ img ][ img ][ img ][ img ][ img ]
USA LC/CM, MAR MSM, WV SM, NE OH LAM (resident of Ohio)
ldriveskier
US Waze Champs
US Waze Champs
 
Posts: 729
Joined: Fri Feb 19, 2016 9:05 pm
Location: Northeast Ohio, United States
Has thanked: 1167 times
Been thanked: 915 times

Re: [Template update] Rank

Postby voludu2 » Fri Jan 19, 2018 5:21 pm

I propose DifficultTurn rather than DT, for clarity.
I just updated this template to correct the rank for adding links to external providers to 2.
Last edited by voludu2 on Fri Jan 26, 2018 1:11 pm, edited 1 time in total.

[ img ]
USA Northeast Region Discord Chat
State Manager - Pennsylvania
Country Manager - USA and Thailand
Wiki Master, Global Mentor
utilitas, simplicitas, retentionis
voludu2
Map Editor - Level 5
Map Editor - Level 5
 
Posts: 3038
Joined: Thu Jul 24, 2014 12:33 pm
Location: Chester County, Pennsylvania
Has thanked: 786 times
Been thanked: 1216 times

Re: [Template update] Rank

Postby ldriveskier » Fri Jan 19, 2018 7:28 pm

voludu2 wrote:I propose DifficultTurn rather than DT,j for clarity.
I just updated this template to correct the rank for adding links to external providers to 2.


Can we use both DT and DifficultTurn, similar to the JB/Junction Box?
[ img ][ img ][ img ][ img ][ img ][ img ][ img ]
USA LC/CM, MAR MSM, WV SM, NE OH LAM (resident of Ohio)
ldriveskier
US Waze Champs
US Waze Champs
 
Posts: 729
Joined: Fri Feb 19, 2016 9:05 pm
Location: Northeast Ohio, United States
Has thanked: 1167 times
Been thanked: 915 times

Re: [Template update] Rank

Postby voludu2 » Mon Jan 22, 2018 7:06 pm

Yes.

[ img ]
USA Northeast Region Discord Chat
State Manager - Pennsylvania
Country Manager - USA and Thailand
Wiki Master, Global Mentor
utilitas, simplicitas, retentionis
voludu2
Map Editor - Level 5
Map Editor - Level 5
 
Posts: 3038
Joined: Thu Jul 24, 2014 12:33 pm
Location: Chester County, Pennsylvania
Has thanked: 786 times
Been thanked: 1216 times

Re: [Template update] Rank

Postby voludu2 » Wed Jan 24, 2018 4:21 pm

This is all very simple, purely factual information, and nobody has objected to these facts.
I propose we make the following changes immediately.
1) Update the template to display these numbers to add these parameter values and the values the template will return for each.
2) Update the template documentation to display documentation of these new parameter values
3) Update the calling page (Editing Restrictions) to use these parameter values rather than the hard-coded values.

If there are no objections, I will see that steps 1 and 2 are completed by the end of the week.

[ img ]
USA Northeast Region Discord Chat
State Manager - Pennsylvania
Country Manager - USA and Thailand
Wiki Master, Global Mentor
utilitas, simplicitas, retentionis
voludu2
Map Editor - Level 5
Map Editor - Level 5
 
Posts: 3038
Joined: Thu Jul 24, 2014 12:33 pm
Location: Chester County, Pennsylvania
Has thanked: 786 times
Been thanked: 1216 times

Re: [Template update] Rank

Postby ldriveskier » Wed Jan 24, 2018 8:02 pm

voludu2 wrote:This is all very simple, purely factual information, and nobody has objected to these facts.
I propose we make the following changes immediately.
1) Update the template to display these numbers to add these parameter values and the values the template will return for each.
2) Update the template documentation to display documentation of these new parameter values
3) Update the calling page (Editing Restrictions) to use these parameter values rather than the hard-coded values.

If there are no objections, I will see that steps 1 and 2 are completed by the end of the week.


Please don't wait for me. I'm buried this week, so it would be quicker if you go ahead and do the updates. Thank you!!! :)
[ img ][ img ][ img ][ img ][ img ][ img ][ img ]
USA LC/CM, MAR MSM, WV SM, NE OH LAM (resident of Ohio)
ldriveskier
US Waze Champs
US Waze Champs
 
Posts: 729
Joined: Fri Feb 19, 2016 9:05 pm
Location: Northeast Ohio, United States
Has thanked: 1167 times
Been thanked: 915 times

Re: [Template update] Rank

Postby voludu2 » Fri Jan 26, 2018 6:19 pm

I have completed 1, 2, and 3 above.

[ img ]
USA Northeast Region Discord Chat
State Manager - Pennsylvania
Country Manager - USA and Thailand
Wiki Master, Global Mentor
utilitas, simplicitas, retentionis
voludu2
Map Editor - Level 5
Map Editor - Level 5
 
Posts: 3038
Joined: Thu Jul 24, 2014 12:33 pm
Location: Chester County, Pennsylvania
Has thanked: 786 times
Been thanked: 1216 times

Re: [Template update] Rank

Postby kentsmith9 » Wed Feb 07, 2018 7:54 pm

I think through the various editors updates we have gotten the template parameters out of sync with the doc parameters. The doc page must use at least one of the parameters on the actual template page. It is OK if the template includes terms not on the documentation page for historical purposes, but that might lead to confusion long term.

The template code is case insensitive, but not "space" insensitive. I believe we only created unspaced terms when they were not words but acted more like variables. Currently the "place" related parameters were the only unspaced parameters and all others were spaced.

TemplateDocumentationComment
closureClosureOK
segmentdeleteDelete SegmentPick one or the other word first and include both with and without a space. I propose Delete Segment.
dt / difficultturnDT / Difficult TurnAdd the spaced version to the template code
jb / junction boxJB / Junction BoxOK
hn / forceHN / ForceOK
placeautotrustPlaceAutoTrustOK
placeeditsPlaceEditsOK
placeexternalPlaceExternalOK
placeflagPlaceFlagOK
placeflagapprovalPlaceFlagApprovalOK
mteMTEOK
routingRoutingOK
cityCityOK
snapshotSnapshotOK
serverServerOK
am / area managerAM / Area ManagerOK
urcloseClose URPick one or the other word first and include both with and without a space. I propose Close UR.


For the two conflicting terms with reversed orders, I'd be OK to include both orders in the template code to support anything already in use. I'd also be OK adding both spaces and unspaced parameters to the template, but only list the spaced version on the doc page.Therefore the template would be updated with:
TemplateDocumentation
segmentdelete / deletesegment / delete segmentDelete Segment
dt / difficultturn / difficult turnDT / Difficult Turn
jb / junctionbox / junction boxJB / Junction Box
am / areamanager / area managerAM / Area Manager
urclose / closeur / close urClose UR
USA: Now Idaho; previously California (Northern, SF/SJ)

[ img ][ img ][ img ][ img ][ img ][ img ]
PLEASE READ: Waze Map Editor (Start Here) | Editing Quick-start | Best Practices | Junctions
kentsmith9
Waze Global Champs
Waze Global Champs
 
Posts: 5678
Joined: Mon Apr 23, 2012 3:33 pm
Location: Boise ID and SF/SJ Bay Area of Northern California
Has thanked: 1573 times
Been thanked: 1783 times

Re: [Template update] Rank

Postby voludu2 » Tue Feb 13, 2018 10:06 pm

Thanks, kent.
It shouldn't be too difficult to fix all the links to this template from all the calling pages - there are not many.

Perhaps a note in comments at the top of the template for anyone seeking to edit, describing the desired format for the parameters would help keep things tidier in the future.

[ img ]
USA Northeast Region Discord Chat
State Manager - Pennsylvania
Country Manager - USA and Thailand
Wiki Master, Global Mentor
utilitas, simplicitas, retentionis
voludu2
Map Editor - Level 5
Map Editor - Level 5
 
Posts: 3038
Joined: Thu Jul 24, 2014 12:33 pm
Location: Chester County, Pennsylvania
Has thanked: 786 times
Been thanked: 1216 times

Re: [Template update] Rank

Postby kentsmith9 » Wed Feb 14, 2018 12:47 am

If we don't get any push back by this weekend, I propose we move forward with the changes I proposed in the table above. I'm open to any editor making the change if I am not around. I agree to add a note in the code to help guide editors with new additions to the template.

Note that I already added the new Headlight Reminder for Segments since we have a page with that information in the WoP now.
USA: Now Idaho; previously California (Northern, SF/SJ)

[ img ][ img ][ img ][ img ][ img ][ img ]
PLEASE READ: Waze Map Editor (Start Here) | Editing Quick-start | Best Practices | Junctions
kentsmith9
Waze Global Champs
Waze Global Champs
 
Posts: 5678
Joined: Mon Apr 23, 2012 3:33 pm
Location: Boise ID and SF/SJ Bay Area of Northern California
Has thanked: 1573 times
Been thanked: 1783 times

Next

Return to US Wiki Discussion

Who is online

Users browsing this forum: ehcool68