[New Template] ForumLink

Moderator: Unholy

Re: [New Template] ForumLink

Postby kentsmith9 » Fri Oct 16, 2015 8:48 pm

Phase 1 complete. Still working on the no break space element. It is not currently working as I expected, but still in process.

Example can be seen at https://wiki.waze.com/wiki/Talk:Road_names/USA

I think the text looks strange with the unread icon in the middle of the text with no other notation. I think the prior idea for the () surrounding the icon might make it look less awkward. Or go with the original idea to place it at the end of the sentence. I realize the forum has it at the front of the title, but that is a title with no prior text. Placing it at the end would also improve the no break space issue.
USA: Now Idaho; previously California (Northern, SF/SJ)

[ img ][ img ][ img ][ img ][ img ][ img ]
PLEASE READ: Waze Map Editor (Start Here) | Editing Quick-start | Best Practices | Junctions
kentsmith9
Waze Global Champs
Waze Global Champs
 
Posts: 5686
Joined: Mon Apr 23, 2012 3:33 pm
Location: Boise ID and SF/SJ Bay Area of Northern California
Has thanked: 1578 times
Been thanked: 1800 times

Re: [New Template] ForumLink

Postby kentsmith9 » Fri Oct 16, 2015 9:14 pm

PesachZ wrote:I think it only makes sense to have the icon before the text when the text is the title of the forum threads, when we're using the default text "this forum" then put the icon after the text. Would that make sense?

Agreed. Which of the current example cases would keep the icon at the front?
https://wiki.waze.com/wiki/Template:ForumLink#Examples

IMO, the three that apply for using the icon in the examples should all move to the back. Under what condition can you use ForumLink to have the link at the front of the text in the box?
USA: Now Idaho; previously California (Northern, SF/SJ)

[ img ][ img ][ img ][ img ][ img ][ img ]
PLEASE READ: Waze Map Editor (Start Here) | Editing Quick-start | Best Practices | Junctions
kentsmith9
Waze Global Champs
Waze Global Champs
 
Posts: 5686
Joined: Mon Apr 23, 2012 3:33 pm
Location: Boise ID and SF/SJ Bay Area of Northern California
Has thanked: 1578 times
Been thanked: 1800 times

Re: [New Template] ForumLink

Postby kentsmith9 » Mon Oct 19, 2015 6:37 pm

PesachZ wrote:I think the icon goes before the text in the final two examples, as well as when set up using the link text syntax in these examples
Code: Select all
{{ForumLink | forumid=nnn | search-linktext | topicid }}
{{ForumLink | lang=aa | forumid=nnn | linktext | topicid }}
 {{ForumLink | forum=url | linktext}}

Making sure I understand your proposal. You think the icon should be before the text as in the two examples? It looks strange to me (assuming we can fix the no break space problem), but I am not stuck on it.
USA: Now Idaho; previously California (Northern, SF/SJ)

[ img ][ img ][ img ][ img ][ img ][ img ]
PLEASE READ: Waze Map Editor (Start Here) | Editing Quick-start | Best Practices | Junctions
kentsmith9
Waze Global Champs
Waze Global Champs
 
Posts: 5686
Joined: Mon Apr 23, 2012 3:33 pm
Location: Boise ID and SF/SJ Bay Area of Northern California
Has thanked: 1578 times
Been thanked: 1800 times

Re: [New Template] ForumLink

Postby PesachZ » Mon Oct 12, 2015 6:38 pm

I updated the template to allow an optional |text= or unnamed param to be used along with forum= (when a url is used) to display a custom link text.
I also added the usage to /doc page.
PesachZ
Wiki Master
Wiki Master
 
Posts: 4512
Joined: Mon Jul 01, 2013 12:51 am
Location: NY, USA (also NJ sometimes) {GC}
Has thanked: 1998 times
Been thanked: 2375 times

Re: [New Template] ForumLink

Postby PesachZ » Mon Oct 12, 2015 8:05 pm

kentsmith9 wrote:What do you think about adding the option (or hard code it as default and optionally disable) that the user is taken to the last unread message of that forum. If the user never went there before, it goes to the first entry. If they went previously, they don't have to figure out where was the last thing they read.

I believe we just need to add:
Code: Select all
&view=unread#unread

to the end of the URL

I'm not sure I like that idea, many forum threads for various things throughout the wave have a specific general information on the first post which the user will miss

Sent from Android using Tapatalk
PesachZ
Wiki Master
Wiki Master
 
Posts: 4512
Joined: Mon Jul 01, 2013 12:51 am
Location: NY, USA (also NJ sometimes) {GC}
Has thanked: 1998 times
Been thanked: 2375 times

Re: [New Template] ForumLink

Postby PesachZ » Mon Oct 12, 2015 8:28 pm

kentsmith9 wrote:
PesachZ wrote:I'm not sure I like that idea, many forum threads for various things throughout the wave have a specific general information on the first post which the user will miss

But in the case of unread, the system will only skip the first entry if they already read the first entry.

Today I believe most people currently only follow unread posts through the forum links to last unread or Tapatalk entry. If they want to see the OP, they just need to click on page 1.

Say you follow a link to the forum for a script, or the TTS thread or other topic which has 'read me first' info, download and FAQ links etc in the OP. And you already read that OP 6 months ago, now you'll miss it and maybe forget it's even there. I'd be OK with it if the default was off, so it didn't effect existing links unless they were specifically changed with this intent.

Sent from Android using Tapatalk
PesachZ
Wiki Master
Wiki Master
 
Posts: 4512
Joined: Mon Jul 01, 2013 12:51 am
Location: NY, USA (also NJ sometimes) {GC}
Has thanked: 1998 times
Been thanked: 2375 times

Re: [New Template] ForumLink

Postby PesachZ » Mon Oct 12, 2015 8:52 pm

kentsmith9 wrote:Good points.

In light of that and people assuming the current action, what if we just add the last unread link to the current entry in the mbox:

Comments or questions on this page can be brought up in this forum (unread link).

Or we can use the current forum icon for unread, so only those familiar with that icon would even know to press it. We add the hover text describing it as "Link to unread entries".
Comments or questions on this page can be brought up in this forum ([ img ]).

I like the second option better, and to keep the formatting uniform we should put the icon before the forum title meaning before the link text

Sent from Android using Tapatalk
PesachZ
Wiki Master
Wiki Master
 
Posts: 4512
Joined: Mon Jul 01, 2013 12:51 am
Location: NY, USA (also NJ sometimes) {GC}
Has thanked: 1998 times
Been thanked: 2375 times

Re: [New Template] ForumLink

Postby PesachZ » Mon Oct 12, 2015 9:05 pm

kentsmith9 wrote:
PesachZ wrote:I like the second option better, and to keep the formatting uniform we should put the icon before the forum title meaning before the link text

Like this:
Comments or questions on this page can be brought up in ([ img ]) this forum.


I'd be fine with that (with the appropriate hover text I didn't simulate here).

I would lose the parenthesis, and the link text is bold IIRC.

Comments or questions on this page can be brought up in the [ img ] New Glossary concept and format forum topic.
PesachZ
Wiki Master
Wiki Master
 
Posts: 4512
Joined: Mon Jul 01, 2013 12:51 am
Location: NY, USA (also NJ sometimes) {GC}
Has thanked: 1998 times
Been thanked: 2375 times

Re: [New Template] ForumLink

Postby PesachZ » Mon Oct 12, 2015 9:56 pm

kentsmith9 wrote:OK on the bold. I would think the parenthesis helps separate the two links, but I am not stuck on them.

The templates already does the bulb for and now you don't need to change anything. I took away the () to match the look how you get when you see it in the forum

Sent from Android using Tapatalk
PesachZ
Wiki Master
Wiki Master
 
Posts: 4512
Joined: Mon Jul 01, 2013 12:51 am
Location: NY, USA (also NJ sometimes) {GC}
Has thanked: 1998 times
Been thanked: 2375 times

Re: [New Template] ForumLink

Postby PesachZ » Fri Oct 16, 2015 4:21 pm

Agreed nbsp; Ibwont have time to do it this week, please go ahead

Sent from Android using Tapatalk
PesachZ
Wiki Master
Wiki Master
 
Posts: 4512
Joined: Mon Jul 01, 2013 12:51 am
Location: NY, USA (also NJ sometimes) {GC}
Has thanked: 1998 times
Been thanked: 2375 times

PreviousNext

Return to Wiki Updates and Discussion

Who is online

Users browsing this forum: No registered users