Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Re: [Script] WME Panel Swap

Post by qwaletee
Perhaps it is time to close this topic and start a new one, given the ownership change. We can have a forum mod post a note+link at the top of the opening post.
qwaletee
EmeritusChamps
EmeritusChamps
Posts: 2939
Has thanked: 188 times
Been thanked: 958 times
Send a message
US Champ / Country Manager | State Manager NY, NJ, PA, CT, MA, RI, VT, ME, NH | Northeast ARC | Mentor | Responding to Map Issues

Re: [Script] WME Panel Swap

Post by randyboy
This is one of those why-isnt-this-default-in-the-WME kinda question!
Very, very nice. Thank you :)
randyboy
Country Manager
Country Manager
Posts: 294
Has thanked: 83 times
Been thanked: 57 times
Send a message
Country Manager Norway
International : Waze Wiki | Waze Forum
Norwegian : Waze Wiki - Norge | Waze Forum - Norge | Todo - Norge | Facebook | Google+

Re: [Script] WME Panel Swap

Post by SAR85
This script has once again been updated for compatibility with WME updates. Since the original script author could not be contacted, please find the updated version here.

As always, the original work of JJohnston84 is greatly appreciated, as well as the idea for this script from Ottonomy. Thanks also to tonestertm for bringing the issues to my attention.
SAR85
Area Manager
Area Manager
Posts: 123
Has thanked: 43 times
Been thanked: 144 times
Send a message

Re: [Script] WME Panel Swap

Post by TheLastTaterTot
Looks like this script was an easy fix. Bootstrap function was looking within Waze object for properties that no longer exist, yet were not needed to make the script work. I think jjohnson has already released the fix (thanks!).

On another note, is it possible to bind a modifiable shortcut key? That would be awesome. ^_^
TheLastTaterTot
Wiki Master
Wiki Master
Posts: 480
Has thanked: 253 times
Been thanked: 287 times
Send a message
R5 | RI SM | CA, MA & NY AM | Mentor

Re: [Script] WME Panel Swap

Post by TheLastTaterTot
I must have thought he fixed it when I had gone into the code to fix it myself. Oops! lol

In any case, the fix is actually quite simple here... Just remove some of the checks in the bootstrap function (wmeps_bootstrap())... now i forget what it use to say, but any of the checks that have something after Waze.appPresenter.sidebar.editPanel.??? (replace ??? with other stuff) can be removed... WME Panel Swap never uses them.

The result should look something like this... tho I'm not sure if it actually needs to check all the parents of editPanel <shrug>:

if (undefined !== typeof Waze &&
Waze.appPresenter && Waze.appPresenter.sidebar && Waze.appPresenter.sidebar.editPanel &&
Waze.appPresenter.sidebar && Waze.appPresenter.sidebar.editPanel ) {
TheLastTaterTot
Wiki Master
Wiki Master
Posts: 480
Has thanked: 253 times
Been thanked: 287 times
Send a message
R5 | RI SM | CA, MA & NY AM | Mentor

Re: [Script] WME Panel Swap

Post by TheLastTaterTot
I'll make it simpler...

Replace the stuff after // Bootstrap and before function wmeps_int() { with the following:

Code: Select all

  function wmeps_bootstrap() {
    'use strict';
    wmeps_bootstrapCount++;
    if (undefined !== typeof Waze &&
      Waze.appPresenter && Waze.appPresenter.sidebar && Waze.appPresenter.sidebar.editPanel &&
      Waze.appPresenter.sidebar && Waze.appPresenter.sidebar.editPanel ) {
      console.debug('WME Panel Swap: Initializing...');
      window.setTimeout(wmeps_init, 100);
    } else if (wmeps_bootstrapCount < 15) {
      console.debug('WME Panel Swap: Bootstrap failed. Trying again...');
      window.setTimeout(wmeps_bootstrap, 1000);
    } else {
      console.debug('WME Panel Swap: Bootstrap error.');
    }
  }
  console.debug('WME Panel Swap: Bootstrapping');
  window.setTimeout(wmeps_bootstrap, 100);
TheLastTaterTot
Wiki Master
Wiki Master
Posts: 480
Has thanked: 253 times
Been thanked: 287 times
Send a message
R5 | RI SM | CA, MA & NY AM | Mentor

Re: [Script] WME Panel Swap

Post by tonestertm
Another fix, as I've been informed by SAR85, is as follows:
Because the property,
"typeToEditorClass"
of
Waze.appPresenter.sidebar.editPanel
has been renamed or replaced with
"TYPE_TO_EDITOR_CLASS"
in the model, simply changing the two instances of the former to the latter gets it running again, and leaves the checks intact.
tonestertm
US Waze Champs
US Waze Champs
Posts: 1441
Has thanked: 441 times
Been thanked: 836 times
Send a message
https://dl.dropbox.com/s/y7f2gsiomkpxbe6/CA_SM_Rocket_Shear_Alpha_50.png?dl=0
ARC for SW Region, USA
Global Champ, US Local Champ
The best editors Read the Wiki and read it often. Learn the proper way to handle URs. Don't draw another Place until you read this!

Re: [Script] WME Panel Swap

Post by tonestertm
Working fine here.
For them as wants it, I've posted a non-public version with the simple fix here:
https://greasyfork.org/en/scripts/15753 ... c-2015-fix
tonestertm
US Waze Champs
US Waze Champs
Posts: 1441
Has thanked: 441 times
Been thanked: 836 times
Send a message
https://dl.dropbox.com/s/y7f2gsiomkpxbe6/CA_SM_Rocket_Shear_Alpha_50.png?dl=0
ARC for SW Region, USA
Global Champ, US Local Champ
The best editors Read the Wiki and read it often. Learn the proper way to handle URs. Don't draw another Place until you read this!
Post Reply