[Script] WME Advanced Closures

Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Moderators: Unholy, bextein, Glodenox, JustinS83

Forum rules
Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

DO NOT START a new thread unless it is about a new idea. Keep discussion of existing tools within the main thread for that tool.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Re: [Script] WME Advanced Closures

Postby JustinS83 » Sun Mar 03, 2019 3:49 am

A function was removed in the latest update that Advanced Closures uses when setting the closures. I don't believe there is anything that can be done until staff fixes some things
Script Writing Community Coordinator
[ img ][ img ][ img ][ img ][ img ]
JustinS83
Waze Global Champs
Waze Global Champs
 
Posts: 1357
Joined: Wed Dec 03, 2014 4:33 am
Location: Franklin, OH
Has thanked: 342 times
Been thanked: 2407 times

Re: [Script] WME Advanced Closures

Postby JustinS83 » Sun Mar 03, 2019 1:00 pm

shmupi wrote:
JustinS83 wrote:A function was removed in the latest update that Advanced Closures uses when setting the closures. I don't believe there is anything that can be done until staff fixes some things


Are you sure nothing cannot be done from the community end to adapt the script ?

I would like to be sure 100% before contacting Waze staff

Thanks,
Shmupi

Yes. I'm already in contact with staff about the breaking issues from the last update.
Script Writing Community Coordinator
[ img ][ img ][ img ][ img ][ img ]
JustinS83
Waze Global Champs
Waze Global Champs
 
Posts: 1357
Joined: Wed Dec 03, 2014 4:33 am
Location: Franklin, OH
Has thanked: 342 times
Been thanked: 2407 times

Re: [Script] WME Advanced Closures

Postby JustinS83 » Wed May 01, 2019 4:37 pm

shmupi wrote:
Mike_2985 wrote:I think new WME version broke the "Apply" buton.
Thanks if a waze dev can see the problem to help serial closers :D


Confirmed. new WME broke it again

Notifying Waze once again

Shmupi

I'm in the middle of another project so I can't do anything right now. Can someone post the error?
JustinS83
Waze Global Champs
Waze Global Champs
 
Posts: 1357
Joined: Wed Dec 03, 2014 4:33 am
Location: Franklin, OH
Has thanked: 342 times
Been thanked: 2407 times

Re: [Script] WME Advanced Closures

Postby JustinS83 » Wed May 01, 2019 5:32 pm

RussPA wrote:
JustinS83 wrote:
shmupi wrote:Confirmed. new WME broke it again

Notifying Waze once again

Shmupi

I'm in the middle of another project so I can't do anything right now. Can someone post the error?

Console error:
VM502:1183 Uncaught TypeError: Cannot read property 'EDIT_CLOSURES' of undefined
at <anonymous>:1183:66
at Array.every (<anonymous>)
at HTMLButtonElement.<anonymous> (<anonymous>:1182:58)


Thanks to Dude495 this is fixed and published
JustinS83
Waze Global Champs
Waze Global Champs
 
Posts: 1357
Joined: Wed Dec 03, 2014 4:33 am
Location: Franklin, OH
Has thanked: 342 times
Been thanked: 2407 times

Re: [Script] WME Advanced Closures

Postby JustinS83 » Wed May 01, 2019 5:54 pm

RussPA wrote:Same here, the script doesn't load and generates this console error:
VM3172:64 Syntax error @ "WME Advanced Closures"!
##########################
JSHINT output:
##########################

SyntaxError: Invalid or unexpected token
at new Function (<anonymous>)
at Object.E_c (<anonymous>:3:308)
at ia (eval at exec_fn (:1:107), <anonymous>:63:272)
at Object.create (eval at exec_fn (:1:107), <anonymous>:75:51)
at c (eval at exec_fn (:1:107), <anonymous>:16:273)


Working on it...it's windows vs linux line endings when the script was compiled. I had forgotten about that with this script since I rarely do anything with it.
JustinS83
Waze Global Champs
Waze Global Champs
 
Posts: 1357
Joined: Wed Dec 03, 2014 4:33 am
Location: Franklin, OH
Has thanked: 342 times
Been thanked: 2407 times

Re: [Script] WME Advanced Closures

Postby JustinS83 » Wed May 01, 2019 6:00 pm

Should be fixed for real this time :)
Script Writing Community Coordinator
[ img ][ img ][ img ][ img ][ img ]
JustinS83
Waze Global Champs
Waze Global Champs
 
Posts: 1357
Joined: Wed Dec 03, 2014 4:33 am
Location: Franklin, OH
Has thanked: 342 times
Been thanked: 2407 times

Re: [Script] WME Advanced Closures

Postby JustinS83 » Thu May 02, 2019 2:52 pm

Mike_2985 wrote:hello, there is still a problem for the import of CSV file, the file is found everything is good but there is an error when checking or apply

Code: Select all
Uncaught TypeError: Cannot read property 'EDIT_CLOSURES' of undefined
    at <anonymous>:1651:50
    at Array.filter (<anonymous>)
    at WMEAC_Injected.WMEAC.ClassClosure.applyInWME (<anonymous>:1650:21)
    at applyClosure (<anonymous>:2581:29)
    at readyToApply (<anonymous>:2595:13)

and

Code: Select all
Uncaught TypeError: Cannot read property 'EDIT_GEOMETRY' of undefined
    at _0x5f775e.canEdit (userscript.html?id=735ac9d8-465b-4578-8fff-2ddb2c735c1a:45253)
    at _0x5f775e.loopSegments (userscript.html?id=735ac9d8-465b-4578-8fff-2ddb2c735c1a:45170)
    at _0x34afa5 (userscript.html?id=735ac9d8-465b-4578-8fff-2ddb2c735c1a:44669)
    at n.eval (userscript.html?id=735ac9d8-465b-4578-8fff-2ddb2c735c1a:44477)
    at f (vendor-b350155b7077605a1932.js:1)
    at p (vendor-b350155b7077605a1932.js:1)
    at h (vendor-b350155b7077605a1932.js:1)
    at n.u.trigger (vendor-b350155b7077605a1932.js:1)
    at r.<anonymous> (app-b14f030a21b97df0f48d.js:1)
    at initialize.triggerEvent (vendor-b350155b7077605a1932.js:1)

I'll take a look today when I get some free time.
Script Writing Community Coordinator
[ img ][ img ][ img ][ img ][ img ]
JustinS83
Waze Global Champs
Waze Global Champs
 
Posts: 1357
Joined: Wed Dec 03, 2014 4:33 am
Location: Franklin, OH
Has thanked: 342 times
Been thanked: 2407 times

Re: [Script] WME Advanced Closures

Postby JustinS83 » Thu May 02, 2019 5:37 pm

JustinS83 wrote:
Mike_2985 wrote:hello, there is still a problem for the import of CSV file, the file is found everything is good but there is an error when checking or apply

Code: Select all
Uncaught TypeError: Cannot read property 'EDIT_CLOSURES' of undefined
    at <anonymous>:1651:50
    at Array.filter (<anonymous>)
    at WMEAC_Injected.WMEAC.ClassClosure.applyInWME (<anonymous>:1650:21)
    at applyClosure (<anonymous>:2581:29)
    at readyToApply (<anonymous>:2595:13)

and

Code: Select all
Uncaught TypeError: Cannot read property 'EDIT_GEOMETRY' of undefined
    at _0x5f775e.canEdit (userscript.html?id=735ac9d8-465b-4578-8fff-2ddb2c735c1a:45253)
    at _0x5f775e.loopSegments (userscript.html?id=735ac9d8-465b-4578-8fff-2ddb2c735c1a:45170)
    at _0x34afa5 (userscript.html?id=735ac9d8-465b-4578-8fff-2ddb2c735c1a:44669)
    at n.eval (userscript.html?id=735ac9d8-465b-4578-8fff-2ddb2c735c1a:44477)
    at f (vendor-b350155b7077605a1932.js:1)
    at p (vendor-b350155b7077605a1932.js:1)
    at h (vendor-b350155b7077605a1932.js:1)
    at n.u.trigger (vendor-b350155b7077605a1932.js:1)
    at r.<anonymous> (app-b14f030a21b97df0f48d.js:1)
    at initialize.triggerEvent (vendor-b350155b7077605a1932.js:1)

I'll take a look today when I get some free time.


I just pushed an update that should fix this - 2019.05.02.01
Script Writing Community Coordinator
[ img ][ img ][ img ][ img ][ img ]
JustinS83
Waze Global Champs
Waze Global Champs
 
Posts: 1357
Joined: Wed Dec 03, 2014 4:33 am
Location: Franklin, OH
Has thanked: 342 times
Been thanked: 2407 times

Re: [Script] WME Advanced Closures

Postby JustinS83 » Thu Sep 05, 2019 10:09 pm

Priso19 wrote:Nothing new with the .csv parsing fonction ???

You are welcome to investigate and fix and send a pull request. My free time is extremely limited and I've never used his functionality before, so it would take a fair amount of debugging time.
Script Writing Community Coordinator
[ img ][ img ][ img ][ img ][ img ]
JustinS83
Waze Global Champs
Waze Global Champs
 
Posts: 1357
Joined: Wed Dec 03, 2014 4:33 am
Location: Franklin, OH
Has thanked: 342 times
Been thanked: 2407 times

Re: [Script] WME Advanced Closures

Postby JustinS83 » Sat Dec 14, 2019 2:18 am

This should be working again. I did not test thoroughly (only set one repeating closure) so please let me know of any other issues that are found.
Script Writing Community Coordinator
[ img ][ img ][ img ][ img ][ img ]
JustinS83
Waze Global Champs
Waze Global Champs
 
Posts: 1357
Joined: Wed Dec 03, 2014 4:33 am
Location: Franklin, OH
Has thanked: 342 times
Been thanked: 2407 times

PreviousNext

Return to Addons, Extensions, and Scripts

Who is online

Users browsing this forum: No registered users