Timbones wrote:

doctorkb wrote:As of last night, the node highlighting (of soft turns, u-turn, revconns) is no longer working.

I feared that might happen. Given that Validator shows these too (?), I'm considering dropping this feature from my script...

Hi Timbones,
I have just finished to debug this functionality of your script ,
I have tested it on the three servers (World, US & Canada only and Israel only)
And, it work on the domains:
- https:/www.waze.com/editor
- https:/www.waze.com/*/editor

I transmit you, the link of the source (v1.92) by private message, and you can publish it....
If you want...

A++!

Taco909 wrote:I'm not sure that Validator is catching Revcons.
I had another situation this morning where I needed to convert a group of 2-way streets to 1-way, and I forgot to disable turns first. I got no Revcon notification from either Validator or WMECH.
Also, over the past four days I've run Validator scripts against the entire eastern Los Angeles and Orange County basin. I did not get a single "hit" for Revcon for probably 800 square miles of scanning.

Currently Validator v1.1.1, or all other Highlight process, don't report the Revcons and UTurns. This is due to the recent change in the storage permissions turn.
Before, they was stored with the node information. Currently, they are stored with the segments information.

Timbones wrote:

doctorkb wrote:That said, while it has the same functionality, the functions are named slightly differently in the code.

WMECH is looking for a function called WME_JNF_FixNode - if it can't find it, then it prints that message about JNF not being active. What is it called in Toolbox?

WMETB_JNF_FixNode

Timbones wrote:Yes, I just spotted that while reading through the changes you sent me...

Ok , no problem if doctorkb can confirm.

Olestas wrote:I often check borders of 3-4 countries, and would like to see which segments/places belong to which country. WMECH changes to No city/Country or City/Country.. yes, but could you also add position -/Country, so it does not differ by City/no city.
THanks.

Hi,
Same for States please

Twister-UK,

Maybe it's the same problem : viewtopic.php?f=211&t=176712

Have you tested without others scripts ?

I'm not sure but maybe the scripts without icon tab cause this issue (problem to loading font-awesome).
Since I fixed icons, everything works to perfection

Full fix (add bold text) :
(careful, when you add lines, the numbers change )

Lines 159-161
if (cityID != null && Waze.model.cities.get(cityID).attributes != null) {
noCity = Waze.model.cities.get(cityID).attributes.isEmpty;
countryID = Waze.model.cities.get(cityID).attributes.countryID;
}

Line 807
var thisName = Waze.model.cities.get(thisCity).attributes.name;

Line 940 (cybernissart fix)
var cityname = Waze.model.cities.objects[cid].attributes.name;
var citystateid = Waze.model.cities.objects[cid].attributes.stateID;
var citycountryid = Waze.model.states.get(citystateid).countryID;
You can remove line 940
var city = Waze.model.cities.get(cid);

Line 943 (cybernissart fix)
cityObjs.push({id: cid, name: cityname, state: citystateid, country: citycountryid});



Sometimes highlight places have issu. please add this 2 lines from line 597
if (specificCity) {
if (venue.attributes.streetID === undefined) continue;
venueStreet = Waze.model.streets.get(venue.attributes.streetID);
if (venueStreet === undefined) continue;
selectedCityMatch = (specificCity && venueStreet.cityID == selectedCityId);



Also, if you want icon instead of text in tab, change line 1246 :
newtab.innerHTML = '<a href="#sidepanel-highlights" data-toggle="tab"><span class="fa fa-tint" title="Highlight"></span></a>';



If you want change highlight color for city (Filter by City (Yellow)) :
Lines 384 & 389 :
newColor = "#f90";
Give you orange color

I have but it's Tim's script :/

(Visit french forum about scripts )

One request, one possible bug. I did not read through the entire thread so my apologies if these came up before and were dismissed and not possible or not wanted.

Possible bug: I have been using the script extensively while auditing city segments, especially under the newer guidance for alt city names attached to ZIP code city names in the US. Generally I use the highlight city option inverted, to highlight segments with incorrect city naming. However, when something happens to my WME browser tab and it gets buggy and I have to load a new tab, the "invert" checkbox becomes unchecked. Not a huge deal, but since the other checkbox selections always come back the same, wondering if this one can be saved for browser reloads, too.

Request: I am also auditing for missing HNs, and the "No HNs" option is great for that. The no HNs feature for TB only works on Street segments, while Highlights works on Streets and higher types (thank you), but neither works on PR segments. Can Color Highlights be modified to show when a PR is named but has no HNs?

Thanks for all your hard work on this stuff, much appreciated.