Page 28 of 65

Re: [script] WME Junction Angle Info

PostPosted: Thu Apr 16, 2015 4:26 am
by sketch
That's right taco. Conversely, U turns can never be prevented by a segment longer than 15 m. And I do the same, 14 or 16 (if I'm going for a particular result with a road that would otherwise physically dictate a smaller or larger distance).

Re: [script] WME Junction Angle Info

PostPosted: Thu Apr 16, 2015 5:20 am
by milkboy
milkboy wrote:Meh.. There is a restriction from 2015-06-01 to 2016-12-31, which is incorrectly detected as a current restriction.. Need to add date range checks also =)


The date based restrictions should work correctly with latest version from GH/GF (1.8.3.1). Won't be releasing new addons for only this change just yet, as it's probably not the most frequently occurring issue ;)

Re: [script] WME Junction Angle Info

PostPosted: Thu Apr 16, 2015 5:35 am
by milkboy
Olestas wrote:Hmm.. strange.
JAI shows that this junctions all straight drives will be Keep, but they all are BC.
https://www.waze.com/editor/?env=row&lo ... =167182298

Argh. Good catch. The BC logic should only take angles <=~45 into account. This filter got lost at some point.

EDIT: And yes, this is probably bad enough to actually warrant a new release.


EDIT2: And fixed packages uploaded.

Re: [script] WME Junction Angle Info

PostPosted: Thu Apr 16, 2015 7:49 am
by FZ69617
Just published JAI version 1.8.4.1 including additional fixes to the turn instructions estimation atgorithm:
https://greasyfork.org/en/scripts/9192- ... angle-info

This version contains valuable additions contributed by wlodek76 - thanks!

Re: [script] WME Junction Angle Info

PostPosted: Thu Apr 16, 2015 8:11 am
by Olestas
So which one should I use, GH or GF? I keep changing them with each update? :D

Re: [script] WME Junction Angle Info

PostPosted: Thu Apr 16, 2015 8:43 am
by FZ69617
Olestas wrote:So which one should I use, GH or GF? I keep changing them with each update? :D

Depends on your expectations. :)

If you are an average user of the script, then you can use official releases of the script linked by @milkboy in the opening post there:
https://www.waze.com/forum/viewtopic.ph ... 50#p735439
The recent version published by the author is 1.8.4, which is available on both GH, and GF.

Version 1.8.4.1 (published by me) is say "developer version" and is currently available only on GF:
https://greasyfork.org/en/scripts/9192- ... angle-info
After acceptance by the author a version 1.8.4.1 may become a next offitial version (1.8.5?), but this is a sole decision of the original author, and this may even never happen. :)

Decide yourself on which version you want to use. :D

Re: [script] WME Junction Angle Info

PostPosted: Thu Apr 16, 2015 9:24 am
by milkboy
I try to check any patches as soon as possible and add them to the GitHub repository (which then automatically pushes the changes to _my_ Greasy Fork script), with best effort to attribute the changes to whoever made them. The most effortless way (for me at least) to get patches merged (and correctly attributed) is naturally to submit pull requests on GitHub, but I can't and won't require that ;)

As for when and how a "official version" is released (well, release in this case only means updating the Chrome/Firefox addons), there is no process for it.

Re: [script] WME Junction Angle Info

PostPosted: Thu Apr 16, 2015 4:09 pm
by milkboy
PR merged :) Quite painless operation that could be done while queuing to pay for a 21mm socket (for tightening wheel bolts) :)

Re: [script] WME Junction Angle Info

PostPosted: Thu Apr 16, 2015 4:20 pm
by milkboy
Oh, and if we'd really want to utilize GitHub, I could set up a separate "development" branch that could then be used for testing new stuff, before merging into master. The dev branch could then be used by brave testers who don't mind occasional problems or something. Master would then be considered "release quality"... just some thoughts.

Re: [script] WME Junction Angle Info

PostPosted: Thu Apr 16, 2015 5:35 pm
by milkboy
qwaletee wrote:If you place the instruction indicator centered on a line, then you can rotate the text to be perpendicular to the line, and stack two instructions. You would end up with three "rows" within your container:
  • Line closest to junction - directions from "this" segment toward the "other segment" coming out of the junction.
  • Line containing the turn angle.
  • Line furthest from junction - directions from the "other segment" to this segment

Hmm.. Not entirely sure I'm able to visualize this correctly in my head :?
3 lines inside the marker is probably going to make the markers biggish or the text really small..

I wonder if is possible to have multicolored markers =D As in, split in half with matching color code somehow matching the direction.. Might need some deeper insight into how OpenLayers actually work though.