[Script] WME Validator 1.1.20 / 03.11.2016

[AlanOfTheBerg]

Script has the wrong forum URL for "Website." In the Extensions window, the "Visit website" link is https://www.waze.com/forum/viewtopic.php?t=61518, which is for a different extension.

[khaytsus]

I've tried disabling all other scripts, yet this one still doesn't seem to "validate" anything. It shows up, I click the Play button, it pans around, finishes scanning, then nothing. No report (button stays greyed out).

Chrome 31, in tapermonkey. I'll try from the Chrome store later. Can't use Firefox right now, it's completely broken since it updated to 27 for me.

[davidg666]

I assume this takes account of countries where people drive on the left (and roundabouts are clockwise). Can you add Ireland to the list of countries like this?

There is a property in WME for left hand traffic and Validator takes it into account. For instance here is a "normal" (B->A) left-hand roundabout in Ireland: permalink and here is reversed left-hand (A->B) roundabout: permalink

Let me know if you want to completely disable this check for Ireland or change the check title/description.

Thanks for your response - however:

1. both of those roundabouts you mention above are correct (clockwise), even though one runs A->B and the other runs B->A. Possibly some of them are older and created with Cartouche, which may have created the segments a different way around (or maybe WME did once)
2. A great many roundabouts here (just pan around Dublin (we have plenty of roundabouts ) are reported as being incorrect, even when they're not.

It looks like 'newer' roundabouts (created around 2013) seem to run B->A and aren't flagged as wrong, but a lot of 'older' roundabouts (created around 2011) run A->B - both of these are correct on the map, but the A-B roundabouts are flagged as incorrect.

I suspect this is the case for other countries where people drive on the left, and possibly for all countries, including those where people drive on the right. (I haven't had time yet to look at other countries' roundabouts)

Can I suggest that you look around for older (2011 or so) roundabouts and compare with newer (2013 or later) roundabouts? (if this seems to affect drive-on-the-left countries only, maybe look at Australia, New Zealand or Japan and not the UK, since the UK has had a basemap import and may have more consistent roundabouts) I suspect that WME (or Cartouche) didn't always create roundabouts with the segments running A->B or B->A. For this reason, I don't think your roundabout correctness checking is correct, if it's just based on the order of segment end points.

Perhaps you could disable this check until it works consistently (and can handle both A->B and B->A roundabouts)?

++David \ davidg666

[berestovskyy]

I assume this takes account of countries where people drive on the left (and roundabouts are clockwise). Can you add Ireland to the list of countries like this?

There is a property in WME for left hand traffic and Validator takes it into account. For instance here is a "normal" (B->A) left-hand roundabout in Ireland: permalink and here is reversed left-hand (A->B) roundabout: permalink

Let me know if you want to completely disable this check for Ireland or change the check title/description.

Text bubble reads "Click 'Report' to review map issues" but there is no button named "Report" that I can see. There is a "Show report" button though.

Fixed.

Example where reverse connection does not appear to be detected:

Fixed.

Suggestions: If you can have only one active "report" then I would suggest a single icon to run the report and then clear the report.

While you are panning the map the issues are highlighted and reported. So you can click clear button any time to start the report over. If there are too many segments reported/cached, the clear report button becomes red.

The trash icon has changed.

When I select an interstate segment, it pops up a warning about city name being in the city field. It wants me to remove the city name from the interstate. I didn't think that was set in stone.

I agree. WMEV should not give this guidance.

Ok, the check is disabled for US.

it appears to stop when I go to a different tab and then start over when I switch back.

Drag the tab out to create a new window. Then do not minimize it, but just switch back to original window. At least this trick works for me.

Since dead-ends are supposed to have U-Turns hard disabled, it would be helpful to show the dead-end U-Turn alert for all end nodes that do NOT have the U-Turn hard disabled. Currently it only shows for hard enabled and soft enabled, it does not show for soft disabled

There was a bug with soft turns detection. This segment will be reported/highlighted now as having soft turns.

I'm seeing the validator highlight/flash a LOT of segments, but when I click on them, nothing is shown.

There is a "Might be incomplete city name" check, which reports segments with too short or partially duplicating city names.

This check has limits for different cases. If number of suspicious segments exceeds the limit, the Validator "unreport" all of those segments.

For instance, if we have segments with "City" and "City Plus", Validator "unreport" them if there are more than 10 segments with such a name.

Give me a permalink I'll have a look if that is the case.

Also, seems there's a bug with false-positive for unknown segment direction:
[ img ]

Validator reports here that the segment is highlighted by the WME Color Highlight (WCH). Maybe you are using another script, which colors the segment in #00ffff (that's the color for "Unknown directions" in WCH.) You can disable those reports in Settings->WCH: Report highlighted segments

Thanks for the feedback!

[AlanOfTheBerg]

I'm seeing the validator highlight/flash a LOT of segments, but when I click on them, nothing is shown.

Also, seems there's a bug with false-positive for unknown segment direction:
[ img ]

[pumrum]

VERY good stuff here. Thanks! A suggestion:

Since dead-ends are supposed to have U-Turns hard disabled, it would be helpful to show the dead-end U-Turn alert for all end nodes that do NOT have the U-Turn hard disabled. Currently it only shows for hard enabled and soft enabled, it does not show for soft disabled.

Wiki: https://www.waze.com/wiki/Map_Editing_Q ... nd-streets

Example: https://www.waze.com/editor/?zoom=5&lat ... TT&env=usa

[lelehman]

This is awesome! I've noticed I can't switch tabs while waiting to finish the scan - it appears to stop when I go to a different tab and then start over when I switch back. Nonetheless, this is a really helpful extension.

[AlanOfTheBerg]

When I select an interstate segment, it pops up a warning about city name being in the city field. It wants me to remove the city name from the interstate. I didn't think that was set in stone.

I agree. WMEV should not give this guidance. And WMEV links to https://www.waze.com/wiki/Fixing_%22smudged%22_cities which doesn't say anything about No Name for freeway segments.

[txemt]

When I select an interstate segment, it pops up a warning about city name being in the city field. It wants me to remove the city name from the interstate. I didn't think that was set in stone.

[AlanOfTheBerg]

Request: Add detection of segments which share the same two endpoints: https://www.waze.com/editor/?zoom=6&lat ... 4,61233176

This is known to cause routing errors and incorrect start-point display issues in the app. Also can cause the "requested route" information for Update Requests to show the wrong segment.