[Script] WME Validator v2021.3.5 (+ PLACES BETA)

Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Moderators: Unholy, bextein, Glodenox, JustinS83

Forum rules
Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

DO NOT START a new thread unless it is about a new idea. Keep discussion of existing tools within the main thread for that tool.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Re: [Script] WME Validator 1.1.19 / 04.06.2016

Postby Glodenox » Sun Oct 30, 2016 10:36 am

The past 4 pages in this thread already talk about this issue ;)
You can somewhat mitigate the issue by putting "!23" in the "Reported as" field in the search tab, though it will still slightly break the script.

We'll have to wait for the script author to fix this, I'm afraid.
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
[ img ][ img ]
Glodenox
Waze Global Champs
Waze Global Champs
 
Posts: 1268
Joined: Tue Aug 11, 2015 9:04 pm
Location: Belgium
Has thanked: 750 times
Been thanked: 1435 times

Re: [Script] WME Validator 1.1.20 / 03.11.2016

Postby Glodenox » Thu Jan 05, 2017 7:57 am

The script is sort of encrypted, but as with anything you have to run, there are ways of looking at what is inside. That said, I don't think that's the way to go here.

Basically, the script should be made more robust to not fail completely whenever a certain validation fails. Do we have a full list of all checks the script performs somewhere? Including all regional differences would probably become troublesome though.
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
[ img ][ img ]
Glodenox
Waze Global Champs
Waze Global Champs
 
Posts: 1268
Joined: Tue Aug 11, 2015 9:04 pm
Location: Belgium
Has thanked: 750 times
Been thanked: 1435 times

Re: [Script] WME Validator 1.1.20 / 03.11.2016

Postby Glodenox » Mon Feb 13, 2017 2:58 pm

So the addition of the ExtendedSVG renderer fixes the script already? I've just installed the userscript at https://dbcm.github.io/waze/valfix/valfix.js as a userscript on Firefox, but the validator still doesn't seem to work yet here (I've made it so that the fix gets executed before validator).

I'll look into it later if other people say this does seem to fix validator for them.
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
[ img ][ img ]
Glodenox
Waze Global Champs
Waze Global Champs
 
Posts: 1268
Joined: Tue Aug 11, 2015 9:04 pm
Location: Belgium
Has thanked: 750 times
Been thanked: 1435 times

Re: [Script] WME Validator 1.1.20 / 03.11.2016

Postby Glodenox » Mon Feb 13, 2017 3:19 pm

It's just a regular userscript, so I can't see where there would be a difference between TamperMonkey and GreaseMonkey here. Unless there's another bug that is only present on Firefox that hasn't been fixed this way. But I'll look into it closer in a couple of hours.
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
[ img ][ img ]
Glodenox
Waze Global Champs
Waze Global Champs
 
Posts: 1268
Joined: Tue Aug 11, 2015 9:04 pm
Location: Belgium
Has thanked: 750 times
Been thanked: 1435 times

Re: [Script] WME Validator 1.1.20 / 03.11.2016

Postby Glodenox » Mon Feb 13, 2017 6:45 pm

I've been able to get this to work consistently in Firefox after a couple of changes to the code of dbcm. The if statement around the proxy for require was unnecessary and I had to use window.require instead of just require to get it to work with GreaseMonkey. [EDIT: This has now been applied to dbcm's script] I've checked with TamperMonkey and this new version works there as well.
Last edited by Glodenox on Mon Feb 13, 2017 8:28 pm, edited 1 time in total.
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
[ img ][ img ]
Glodenox
Waze Global Champs
Waze Global Champs
 
Posts: 1268
Joined: Tue Aug 11, 2015 9:04 pm
Location: Belgium
Has thanked: 750 times
Been thanked: 1435 times

Re: [Script] WME Validator 1.1.20 / 03.11.2016

Postby Glodenox » Mon Feb 13, 2017 7:23 pm

Indeed, I had to change the @include rule in WME Validator as well to get it to work on beta because it is still referring to the old "editor-beta" subdomain that has been replaced quite a while ago.
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
[ img ][ img ]
Glodenox
Waze Global Champs
Waze Global Champs
 
Posts: 1268
Joined: Tue Aug 11, 2015 9:04 pm
Location: Belgium
Has thanked: 750 times
Been thanked: 1435 times

Re: [Script] WME Validator 1.1.20 / 03.11.2016

Postby Glodenox » Mon Feb 13, 2017 8:13 pm

dbcm wrote:In case you want to merge the code, do a pull request.
https://github.com/dbcm/waze/pulls

Double check that works also in Chrome with Tampermonkey

Done, and I had already checked that it still works with TamperMonkey. It wouldn't hurt that other people also verify this, but I've only ever installed my adjusted version of the userscript in TamperMonkey and WME Validator works there, so I'd say it works fine :)

asph4lt wrote:There is something missing to be able to use in languages other than English, no?

I've just checked it with Dutch and it doesn't work there indeed. There's an uncaught TypeError where the script is trying to access a layers property in the translations.
Adding a very small subset of the "en" translations seems to do the trick, I'll make the change and send another pull request.
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
[ img ][ img ]
Glodenox
Waze Global Champs
Waze Global Champs
 
Posts: 1268
Joined: Tue Aug 11, 2015 9:04 pm
Location: Belgium
Has thanked: 750 times
Been thanked: 1435 times

Re: [Script] WME Validator v2020.11.1 (PLACES BETA)

Postby Glodenox » Mon Feb 22, 2021 12:56 pm

Heads-up warning: Waze is planning to put the beta version of WME in production tomorrow. This script has a reference to the W.app.modeController object, which has been removed after the removal of the MTE mode. The fix is simple: just remove everything connected to that object as it no longer has any use. This can be done safely in production already.

This script relies on modeController being present at initialization, so it becomes broken in this new version.
EDIT: just noticed the GitHub, I'll quickly fork it and send in a pull request.
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
[ img ][ img ]
Glodenox
Waze Global Champs
Waze Global Champs
 
Posts: 1268
Joined: Tue Aug 11, 2015 9:04 pm
Location: Belgium
Has thanked: 750 times
Been thanked: 1435 times

Re: [Script] WME Validator 0.7.3 (BETA) / 24.02.2014

Postby glomp » Thu Feb 27, 2014 8:57 am

berestovskyy wrote:DISABLED for US 'More than 55 letters Ramp name'


Can we get this disabled for Australia?

With the work we have done for the addition of road shields, the format used for them can add an extra 7-10 characters to the name of a highway/freeway name. This makes the average length of a highway/freeway name about 25 characters.

With the addition of wording such as "entry to:/exit" and a couple of city destinations, it quickly makes the ramp names quite long.
glomp
Country Manager
Country Manager
 
Posts: 2008
Joined: Thu Aug 16, 2012 3:49 pm
Location: Western Australia
Has thanked: 479 times
Been thanked: 1026 times

Re: [Script] WME Validator 0.5.0 (BETA) / 20.01.2014

Postby goodolsen » Mon Jan 20, 2014 11:08 pm

sketch wrote:edit again: I do miss the flashing, maybe it's just me! :D Could it be optional?


I second that, the flashing made it easier for me and took up less real estate on the screen. :)
Toby G.
Raleigh Area
[ img ][ img ]
goodolsen
 
Posts: 44
Joined: Thu Nov 04, 2010 8:53 pm
Location: North Carolina
Has thanked: 19 times
Been thanked: 6 times

PreviousNext

Return to Addons, Extensions, and Scripts

Who is online

Users browsing this forum: jm6087, ldriveskier