[Script] WME Validator 1.1.20 / 03.11.2016

Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Moderators: Unholy, bextein

Forum rules
Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

DO NOT START a new thread unless it is about a new idea. Keep discussion of existing tools within the main thread for that tool.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Re: [Script] WME Validator 0.9.4 (BETA) / 30.03.2014

Postby berestovskyy » Wed Apr 02, 2014 5:55 am

sketch wrote:check out Street View on the service road at Aurora and Orion here — to prohibit drivers from cutting through the neighborhood when exiting the Interstate.

Wow, very nice and rare example. I just wondering how can we detect such a situation... A turn from a Ramp/Highway to the regular street or lower? Any ideas?

Although the map is perfectly correct, there are few possibilities to suppress the warning in Validator at the moment:
1. Add a 24/7 time based turn restriction from highway to the street.

2. Make an exiting piece of the screet one way.

3. Make the screet private.

I know it's ugly but a tempory solution. So, shall I exclude inward connectivities warnings for the turns from highways/ramps to streets/parking lots/dirts?
berestovskyy
 
Posts: 840
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 259 times
Been thanked: 714 times

Re: [Script] WME Validator 0.9.4 (BETA) / 30.03.2014

Postby berestovskyy » Fri Apr 04, 2014 4:18 pm

lg1992 wrote:Are there plans to enable checking for invalid elevation? If not, can I enable this checking just for me? If not, what's the correct rule to define custom condition for that?

Sorry, I couldn't reproduce the issue in my environment, so there is no plans to re-enable it unless someone ask me to. But sure you can use custom check to find null elevations.

Click Settings->custom and in "Custom template" field put:
Code: Select all
${elevation}

In the "Custom RegExp" field put:
Code: Select all
null
berestovskyy
 
Posts: 840
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 259 times
Been thanked: 714 times

Re: [Script] WME Validator 0.9.4 (BETA) / 30.03.2014

Postby berestovskyy » Mon Apr 07, 2014 9:17 am

No worries, Validator is a read-only tool. At the moment it's dozens of files/~15K lines of source code project roots in WMET, so I never paid attention to those messages. And frankly, I have no idea how did you get into that part of legacy code :lol:

But sure, it will be fixed in the next release.
berestovskyy
 
Posts: 840
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 259 times
Been thanked: 714 times

Re: [Script] WME Validator 0.9.4 (BETA) / 30.03.2014

Postby berestovskyy » Mon Apr 07, 2014 11:19 am

petervdveen wrote:Question about the error 'too short segment'.

It's a per-country setting and by default Validator reports 'too short segment' if a segment is 2m long or less. The check also skips dead-ends and roundabout segments.

There is also a group if checks, which skips less than 6m long segments:
#44 'No outward connectivity'
#102/#103 'Node A/B: No outward connectivity'
#107/#108 'Node A/B: No connection'

So by default there is a gap for the 3-5m long segments, i.e. you don't get them reported as too short nor Validator thoroughly checks their connectivity.

It's made on purpose after I scanned few capitals in Europe and found too many false positives at complex intersections. There was no reliable way to exclude those false positives, so I decided to make the gap. It's in my todo, but I haven't managed yet to get back to the issue.

Let me know if I shall increase the value for the too short segments for BeNeLux.
berestovskyy
 
Posts: 840
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 259 times
Been thanked: 714 times

Re: [Script] WME Validator 0.9.4 (BETA) / 30.03.2014

Postby berestovskyy » Mon Apr 07, 2014 1:14 pm

Here are few examples of too short segments in Amsterdam to illustrate what I mean:
permalink1
permalink2
permalink3
permalink4

And tons of regular streets like this:
permalink
berestovskyy
 
Posts: 840
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 259 times
Been thanked: 714 times

Re: [Script] WME Validator 0.9.5 (BETA) / 07.04.2014

Postby berestovskyy » Mon Apr 07, 2014 8:48 pm

07.04.2014 v0.9.5:
- Validator now skips locked segments, so the locks may
be used to hide issues for low-level users.
- New faster 'Show report' method (Chrome only)
- Layers param in permalinks in report

- Updated Spanish translations thanks to robindlc
- Updated #109 'Too short segment': 5m by default
(6m for BeNeLux) + wiki link added
- Updated #79 'Too short U-turn connector' to report
only same road types
- Updated #24 'Might be incorrect city name' for
Строитель снт vs Строитель 2 снт

For localization packs:
- Configured check parameters are listed now in
'Settings->About->Available checks'
- New params to override default check description:
'titleEN', 'problemEN' and 'solutionEN'
- Fixed custom check ${deadEnd} variable for off-screen
nodes
- Fixed custom check ${softTurns} variable

Checks review:
I'm reviewing all the checks, removing unused, merging similar checks, adding params to some checks, splitting nodes A/B etc. So in this release:
Code: Select all
  All "option1" properties changed to params/regexp
  Changed check ID #10 -> #9
  Split check #40 'Soft turns' -> #200 and #300
    'Node A/B: Unconfirmed turn on minor road'
  Split check #86 'Soft turns on primary road' -> #201 and #301
    'Node A/B: Unconfirmed turn on primary road'
  Removed #49 and #111 (Roundabouts)
  Added params for #73 'Too short street name'
    and #109 'Too short segment'
  Added new checks to validate street names:
    #160 Freeway name (merged #61 and #80)
    #161 Major Highway name (merged #53, #60 and #81)
    #162 Minor Highway name (merged #82)
    #163 Ramp name (merged #54, #64, #89 and #113)
    #164 Primary Street name
    #165 Street name
    #166 Parking Lot Road name
    #167 Railroad name (merged #58)
    #169 any type street name (merged #55, #56 and #123)
    #170 'Lowercase street name' (merged #93, #94)
    #171 'Incorrectly abbreviated street'
      (merged #26, #51, #68 and #88)
    #172 'Unneeded spaces in street name' (merged #30)
    #173 'No space before/after abbreviation' (merged #32)
    #174 'Street name spelling mistake' (merged #100)
    #175 'Empty street name' (merged #98)
  Added new checks to validate street types:
    #70 must be a Freeway (merged #83)
    #71 must be a Major (merged #62 and #84)
    #72 must be a Minor (merged #63 and #85)
berestovskyy
 
Posts: 840
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 259 times
Been thanked: 714 times

Re: [Script] WME Validator 0.9.5 (BETA) / 07.04.2014

Postby berestovskyy » Tue Apr 08, 2014 6:02 am

kentsmith9 wrote:I propose the validator identify these segments without a state.

Sure, will be added. Meanwhile you can click Settings->custom and put into the "Custom template" field:
Code: Select all
${state}

then put in the custom RexExp field:
Code: Select all
^$

And you will get those empty states highlighted for you.

irowiki wrote:Wait, I thought locked segments were already excluded?

They were excluded by default with "Exclude non-editable segments". Now the locked segments are excluded always.
berestovskyy
 
Posts: 840
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 259 times
Been thanked: 714 times

Re: [Script] WME Validator 0.9.6 (BETA) / 08.04.2014

Postby berestovskyy » Tue Apr 08, 2014 9:36 am

kentsmith9 wrote:Also, I searched the first post in this thread, but did not find the link to the Complete Search list.

Kent, it's always available under Settings->About->Available checks. If you click it over the US, Validator will show enabled/disabled checks for US. And I just added a red link to the OP ;)

Fabianotkd wrote:Don't limit us, please. :?

No problem, I guess we need to discuss it.

Every rule has an exception. Despite I'm doing my best to avoid false positives, they are there and they always will be. So IMO we need to agree on how do we mark those false positives on the map, so other editors do not try to fix them just because Validator says so.

For instance, few days ago Sketch posted here a link to the area where the right turns on two-way roads are disabled: permalink

So the current proposal is to simply lock those exceptions and do not report issues to the low-level users. I also significantly improves Validator performance for low-level users on low zoom levels when there are lots of locked freeway/highway segments.

Let me know if anyone has a better idea.


08.04.2014 v0.9.6:
- Fixed #170 'Lowercase street name' (but not for "U turn" I guess :lol:)
- New for US #106 'No state name selected'
- Disabled skips of locked segment
berestovskyy
 
Posts: 840
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 259 times
Been thanked: 714 times

Re: [Script] WME Validator 0.9.6 (BETA) / 08.04.2014

Postby berestovskyy » Tue Apr 08, 2014 3:17 pm

Ok, guys I got that you need to see issues on locked segments.

Any ideas regarding
we need to agree on how do we mark those false positives on the map, so other editors do not try to fix them just because Validator says so.

or I didn't get your proposal with highlighting :? I wish we had a comment field...

But how about this: do not highlight/report a segment:
1) if the segment was locked above editor's level
2) and it was modified after 2014-05-01

So you will get the issues on the "old" locked segments, but never on recently updated segments.

PS. I hope I'll get #170 fixed soon, sorry :(
berestovskyy
 
Posts: 840
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 259 times
Been thanked: 714 times

Re: [Script] WME Validator 0.9.7 (BETA) / 08.04.2014

Postby berestovskyy » Tue Apr 08, 2014 8:35 pm

For US Country Managers (and not only)

Guys, have a look at the complete list of checks here: forum post

Note that some of the checks have params to configure, for instance
Freeway/Highway/Ramp/Street/Railroad names (#160-#169)
Lowercase street name (#170)
Street abbreviations (#171)
Street name spelling mistakes (#174)
Freeway/Highway/Ramp/Primary Street locks (#150-#154)
and few other

Most of them are not even enabled in US.

Here is a detailed post explaining how to enable/setup Validator for your country: forum link

I'm not editing in US, so I would really appreciate if any US-based CM could take a role of a "Validator country manager", i.e. to enable, configure and test those checks in US, distribute localization package or ask me to pull back into Validator proven configurations time to time.

Sure, I will help and support, answer and advice. Let me know if anyone is interested.

Thanks!
berestovskyy
 
Posts: 840
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 259 times
Been thanked: 714 times

PreviousNext

Return to Addons, Extensions, and Scripts

Who is online

Users browsing this forum: No registered users