[Script] WME Validator v2020.11.1 (PLACES BETA)

[berestovskyy]

Thank you for making this open source! I've just created a PR on the i18n for the NL (Dutch) translations

Thanks for the contribution.

[berestovskyy]

Just like Justin said. We planned to move it to GitHub with update/download URLs but all of a sudden the script was locked and deleted due to minification. So unfortunately, we have to do this manually now

I just moved the release files to GitHub and updated the link:
https://raw.githubusercontent.com/WMEVa ... or.user.js

Please report if you have any issues.

[berestovskyy]

v2018.08.09:
- add GreasyFork release script
- disable checks 114 and 115 (drivable & non-drivable)


The script is back on GreasyFork, so:
> For Firefox browser download the script at GitHub.com or GreasyFork
Note: for Firefox browser you also need Greasemonkey or Tampermonkey installed.

[berestovskyy]

Not sure what "minified" means, but

No problem, let me Google it for you: https://en.wikipedia.org/wiki/Minification_(programming)

Minification, in computer programming languages and especially JavaScript, is the process of removing all unnecessary characters from source code without changing its functionality.
[...]
Minified source code is especially useful for interpreted languages deployed and transmitted on the Internet (such as JavaScript), because it reduces the amount of data that needs to be transferred.

If it's been taken Open Source, then why is it being obfuscated and minified?

Validator was never obfuscated or minified. It was always compiled using Google Closure Compiler: https://en.wikipedia.org/wiki/Google_Cl ... e_Compiler

The version uploaded on GresyFork is not compiled anymore, so it is a bit bigger and slower than GitHub or Web Store releases.


Since Validator is open source now, you can build and use any version you like, with or without compilation. Full sources, build scripts and instructions are available on GitHub: https://github.com/WMEValidator/

Hope this answers your questions, SuperDave1426.

[berestovskyy]

I guess what happened was Greasyfork did what they did before this change to the Open Source model (and is no longer complied), which would no longer trigger such an action on their part.

Not sure what triggered the lock. I used to upload the compiled Validator on GreasyFork for years. Before Validator became open source and after.

But anyway, GreasyFork issue is fixed. Anyone who want to help, let us focus on the open issues...


For example, there is an issue #5 in localization. We need to contact localization contributors and make sure they don't mind to release their translations under the GPLv3. No developers skills are needed.

Anyone want to help with this?

[berestovskyy]

v2018.08.28:
- davidakachaos: fix switching to/from event mode
- davidakachaos: fix "unneeded node" for segments with different speeds
- davidakachaos: fix WMECH integration bug

Many thanks to davidakachaos.
Keep up the great job, David!

[berestovskyy]

Did a quick search and didn't return much, can this be used to validate for road speeds being blank?

Validator is open source. Guys, please help us to implement speed limits support!


There is already created an Issue #14 for that:

https://github.com/WMEValidator/validator/issues/14

And davidakachaos have done the basic speed limit support in this commit. All the building blocks are there, all we need is to report those segments with blank speed limit...

Here is an example how to report segments in Validator:

Code: Select all

   if (!state
      && address.isOkFor(106))
      segment.report(106);


Basically, in the first line we check a condition we want to report (a segment with no state in this example). In the second line we check if the report is appropriate for the segment's address (country). At last we report the segment.

Here is how to define new reports:

Code: Select all

"106.title": "No state name selected",
"106.problem": "The segment has no state name selected",
"106.solution": "Select a state for the segment and apply the changes",
"106.solutionLink": "W:Creating_and_Editing_street_segments#Confirm_the_road_by_updating_details",


Basically, we assign a unique number, add title, problem description, solution and optional link to a Wiki.

So in total, it will take around 10 lines of code to implement the speed limit check. Good and easy task to start contributing to Validator.

And sure, I will help. Just let me know if there are any question.

Thanks in advance for your help, guys!

[berestovskyy]

Hi guys,
Two days ago my third child was born, so I am not able to develop Validator at the moment. David has a surgery, so he is also AFK. Justin is too busy with other scrips...

Validator is Open Source, i.e. it belongs to everyone now. Anyone can take the source code and lead the development the way they want, implement the functionality they want or fix the most annoying bug:
https://github.com/WMEValidator/

If you would like to try or know someone who might be interested, please feel free to contact me by email, PM or directly here in the forum. There are lots of fun stuff inside and around the Validator, there is something to learn for whatever your current level is.

I will answer all the question: from which IDE to use, how to use git or what is a getter in JavaScript. I will also help with code review and release engineering.

Please share this info to whatever group/messenger you feel appropriate.

Thanks in advance,
Andriy

[berestovskyy]

I think the problem has to do with the W.location.code being removed. There are 2 places where it is used, Just search for

Code: Select all

Ra.location.code

and change it to

Code: Select all

Ra.app.getAppRegionCode()

Would you like to try to fix this? Here are the quick start instructions:
https://github.com/WMEValidator/validat ... uick-start

You can try to fix the issue, test and commit the changes. I will review the changes and make a new release? GitHub counts all the contributions:
https://github.com/WMEValidator/validat ... ntributors

You can use it later for you CV or you can do it just for fun. There is a learning curve, but the skills you will learn are state of the art. Validator always used modern techniques, compilers, version control systems etc.

If you have any questions -- just let me know, I will try my best to answer/help.

Andriy

[berestovskyy]

A small correction must be made to the newly created localization file.

Will be fixed in the next release.