[Script] WME Validator 1.1.20 / 03.11.2016

Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Moderators: Unholy, bextein

Forum rules
Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

DO NOT START a new thread unless it is about a new idea. Keep discussion of existing tools within the main thread for that tool.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Re: [Script] WME Validator 1.1.16 / 29.01.2016

Postby dougp01 » Fri Apr 29, 2016 2:51 am

Hi all, I am seeking advice on "Incorrectly abbreviated street name"

I have a situation where the "." is an actual part of the road name. The Validator report result looks like this:

Fire Rte 162.12, No City
Fire Rte 199.1, No City
Fire Rte 199.1B, No City
Fire Rte 199.1C, No City
Forest Road 509.1, No City

Is there an alternative to this naming I can substitute?

thanks, Doug
dougp01
Map Raider
Map Raider
 
Posts: 93
Joined: Wed Jun 18, 2014 10:05 pm
Location: Larimer, Weld and parts of Boulder County Colorado USA
Has thanked: 36 times
Been thanked: 9 times

Re: [Script] WME Validator 1.1.16 / 29.01.2016

Postby Bill473 » Sun Apr 24, 2016 11:53 pm

Not just in theory, but in reality it's not an error. Obviously I didn't notice that unusual symbol.

(Thanks for pointing that out.)
Bill473
Area Manager
Area Manager
 
Posts: 196
Joined: Wed Jan 14, 2015 6:25 pm
Location: Richmond, Indiana USA
Has thanked: 110 times
Been thanked: 46 times

Re: [Script] WME Validator 1.1.16 / 29.01.2016

Postby Glodenox » Sun Apr 24, 2016 8:44 pm

In theory, that's not an error. ‰ stands for 'per mille' (per thousand). So 33‰ = 3.3%
But as this symbol isn't used that often, I also think it would be better to replace it with a percentage instead.
Glodenox
Map Raider
Map Raider
 
Posts: 333
Joined: Tue Aug 11, 2015 9:04 pm
Location: Belgium
Has thanked: 132 times
Been thanked: 369 times

Re: [Script] WME Validator 1.1.16 / 29.01.2016

Postby Bill473 » Sun Apr 24, 2016 3:04 pm

I love Validator and can't imagine editing without it.

There is an issue with the % calculations (which must have been pointed out before, but I didn't want to re-read the 177 pages of this thread...)

Total number of segments checked: 1912
Reported warnings — 64 (33‰)

That's really 3.3%

(Edited to add: As Glodenox kindly points out below, I didn't notice the difference between % and ‰. Sorry.)
Last edited by Bill473 on Sun Apr 24, 2016 11:55 pm, edited 1 time in total.
Bill473
Area Manager
Area Manager
 
Posts: 196
Joined: Wed Jan 14, 2015 6:25 pm
Location: Richmond, Indiana USA
Has thanked: 110 times
Been thanked: 46 times

Re: [Script] WME Validator 1.1.16 / 29.01.2016

Postby Glodenox » Sat Apr 23, 2016 8:31 am

I've found that the issue is located somewhere in the initialization of the script. It waits for a user login, even though there is already a user logged in. By executing the following bit of code I'm able to make Validator appear again on Firefox:
Code: Select all
Waze.loginManager.events.triggerEvent('login');

In the shape of a bookmarklet that gives:
Code: Select all
javascript:Waze.loginManager.events.triggerEvent('login');

So I'm guessing (as I can't read the source code) that the check for a logged in user is incorrect or that the state listener is added too late.

Personally I'm using this code to trigger when the user has logged in and this seems to work fine:
Code: Select all
    if (typeof Waze === 'undefined' ||
        typeof Waze.loginManager === 'undefined') {
      setTimeout(init, 100);
      return;
    }
    if (!Waze.loginManager.hasUser()) {
      Waze.loginManager.events.register("login", null, init);
      Waze.loginManager.events.register("loginStatus", null, init);
      if (!Waze.loginManager.hasUser()) {
        return;
      }
    }

EDIT: oh wait, it seems I also have another check before I can actually access the tabs (to add a tab or manage them):
Code: Select all
    var tabs = document.querySelector('#user-tabs .nav-tabs');
    if (!tabs) {
      setTimeout(init, 400);
      return;
    }
Glodenox
Map Raider
Map Raider
 
Posts: 333
Joined: Tue Aug 11, 2015 9:04 pm
Location: Belgium
Has thanked: 132 times
Been thanked: 369 times

Re: [Script] WME Validator 1.1.16 / 29.01.2016

Postby turbomkt » Sat Apr 23, 2016 4:50 am

I'm going to assume FF changed something that broke it since the script hasn't been updated since January.
turbomkt
Waze Mentor
Waze Mentor
 
Posts: 287
Joined: Thu Jan 22, 2015 1:05 am
Location: San Diego, Ca
Has thanked: 165 times
Been thanked: 67 times

Re: [Script] WME Validator 1.1.16 / 29.01.2016

Postby whatdoesthisdo » Fri Apr 22, 2016 8:26 pm

Glad to know it is not just me. I had it very briefly once (on a WME load) but since have not seen it.

Edit: On Firefox 45.0.2
whatdoesthisdo
 
Posts: 7
Joined: Mon Dec 02, 2013 2:20 am
Location: Pennsylvania, USA
Has thanked: 3 times
Been thanked: 0 time

Re: [Script] WME Validator 1.1.16 / 29.01.2016

Postby SpencerFG » Fri Apr 22, 2016 6:49 pm

I haven't had a problem with this script, but in the past uninstalling the script and re-installing it solved the problem.
SpencerFG
 
Posts: 99
Joined: Thu Mar 12, 2015 10:05 pm
Location: Virginia, Southern California USA
Has thanked: 35 times
Been thanked: 11 times

Re: [Script] WME Validator 1.1.16 / 29.01.2016

Postby mrsmith66 » Fri Apr 22, 2016 6:41 pm

Doesn't show up for me at all in Firefox in WME Production
mrsmith66
State Manager
State Manager
 
Posts: 144
Joined: Sat Jul 13, 2013 7:46 pm
Location: Hamilton, NJ USA
Has thanked: 27 times
Been thanked: 29 times

Re: [Script] WME Validator 1.1.16 / 29.01.2016

Postby karlcr9911 » Wed Apr 20, 2016 8:05 pm

It doesn't show up for me at all in Chrome in the newest WME beta release.
karlcr9911
Waze Global Champs
Waze Global Champs
 
Posts: 1952
Joined: Fri Aug 23, 2013 2:05 am
Location: North East Texas, USA
Has thanked: 339 times
Been thanked: 1200 times

PreviousNext

Return to Addons, Extensions, and Scripts

Who is online

Users browsing this forum: Fafa114