[Script] WME Validator 1.1.20 / 03.11.2016

Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Moderators: Unholy, bextein

Forum rules
Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

DO NOT START a new thread unless it is about a new idea. Keep discussion of existing tools within the main thread for that tool.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Re: [Script] WME Validator 1.0.0 / 26.05.2014

Postby ispyisail » Fri Jun 20, 2014 8:15 pm

ispyisail wrote:I suspect that validator is missing some errors?

Is this possible?

If so could my slow internet have something to do with this?


Im even more sure that its missing problems.

I assume that the tile loads then gets scanned then validator moves on to the next tile. How does validator know the the tile has fully loaded? Time or other?
New Zealand and Papua New Guinea Country Manager
ImageImageImage
ispyisail
Waze Local Champs
Waze Local Champs
 
Posts: 3355
Joined: Tue Feb 21, 2012 11:59 pm
Location: New Zealand
Has thanked: 567 times
Been thanked: 548 times

Re: [Script] WME Validator 1.0.0 / 26.05.2014

Postby ispyisail » Fri Jun 20, 2014 8:57 pm

Ok i've found an example

This is my report

https://dl.dropboxusercontent.com/u/120 ... wnload.htm

This is the segment that it didn't find

https://www.waze.com/editor/?zoom=5&lat ... =191911646

but it found the ones next to it? (see report)

Image

The scan is with dual screen at full resolution
New Zealand and Papua New Guinea Country Manager
ImageImageImage
ispyisail
Waze Local Champs
Waze Local Champs
 
Posts: 3355
Joined: Tue Feb 21, 2012 11:59 pm
Location: New Zealand
Has thanked: 567 times
Been thanked: 548 times

Re: [Script] WME Validator 1.0.0 / 26.05.2014

Postby ispyisail » Fri Jun 20, 2014 9:07 pm

When I scan above the problem segment at a lower zoom level it finds it?

https://dl.dropboxusercontent.com/u/120 ... 281%29.htm
New Zealand and Papua New Guinea Country Manager
ImageImageImage
ispyisail
Waze Local Champs
Waze Local Champs
 
Posts: 3355
Joined: Tue Feb 21, 2012 11:59 pm
Location: New Zealand
Has thanked: 567 times
Been thanked: 548 times

Re: [Script] WME Validator 1.0.0 / 26.05.2014

Postby berestovskyy » Sat Jun 21, 2014 7:15 am

ispyisail wrote:Ok i've found an example
Image

In this particular case Validator missed a note reported by Toolbox. When I looked into the code, both Toolbox and Colour Highlight did not detect tile load properly and they both used a timer to periodically re-highlight segments.

So I had to implement a trick in Validator: once it detects the tile is loaded and ready, Validator dispatches an event to WMECH to force it to re-highlight the segments. It does not send anything to Toolbox though and I don't remember the reason. Probably the trick didn't work with Toolbox or smth :?


Generally speaking, those misses are plausible in Validator, esp. for the very long segments crossing the map view. So few month ago I send a message to Ohad asking a permission to use a low-level WME calls. It would allow Validator to scan the map few times faster and detect issues on the very long segments.

Now the validation functionality being implemented on the WME servers, I guess there is no reason to put much efforts here...
berestovskyy
 
Posts: 925
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 254 times
Been thanked: 703 times

Re: [Script] WME Validator 1.0.0 / 26.05.2014

Postby ispyisail » Sat Jun 21, 2014 9:35 pm

In this particular case Validator missed a note reported by Toolbox. When I looked into the code, both Toolbox and Colour Highlight did not detect tile load properly and they both used a timer to periodically re-highlight segments.


I've done some more tests and I think with a high probability the problem is to do with using dual screens.

When I go to single screen it appears to pick up everything?
New Zealand and Papua New Guinea Country Manager
ImageImageImage
ispyisail
Waze Local Champs
Waze Local Champs
 
Posts: 3355
Joined: Tue Feb 21, 2012 11:59 pm
Location: New Zealand
Has thanked: 567 times
Been thanked: 548 times

Re: [Script] WME Validator 1.0.0 / 26.05.2014

Postby lg1992 » Sun Jun 22, 2014 6:34 am

Lately I cannot use the Validator on the beta editor (Israeli server). If I work with a small area, the Validator properly paints problematic segments and the button "Show Report", but clicking the button doesn't open a Report page. If I work with a bigger area and click "Start Scanning", the scanning starts but never finishes, and clicking the buttons "Pause" or "Stop" doesn't bring the map back. There are no such problems with the regular editor.

Do any users experience these problems with the beta editor or NA or ROW servers?
Leonid, Country Manager, Israel
lg1992
Country Manager
Country Manager
 
Posts: 2254
Joined: Fri May 04, 2012 9:50 am
Has thanked: 31 times
Been thanked: 211 times

Re: [Script] WME Validator 1.0.0 / 26.05.2014

Postby kentsmith9 » Sun Jun 22, 2014 6:29 pm

I generally don't use the reports, but the on-map visuals are working fine for me in NA.
kentsmith9
Waze Global Champs
Waze Global Champs
 
Posts: 5126
Joined: Mon Apr 23, 2012 3:33 pm
Location: SF/SJ Bay Area of Northern California
Has thanked: 1302 times
Been thanked: 1536 times

Re: [Script] WME Validator 1.0.0 / 26.05.2014

Postby bz2012 » Sun Jun 22, 2014 8:19 pm

Is it possible to add a custom template field for {editorID} or {CreatedBy} {EditedBy} ?
so we could do something like
${EditedBy}
/(user1|user2|user3)$/i
to highlight segments edited by any of a list of editors?
State Manager, Louisiana
bz2012
Map Raider
Map Raider
 
Posts: 1429
Joined: Wed Nov 23, 2011 4:32 pm
Location: Baton Rouge, La
Has thanked: 1023 times
Been thanked: 259 times

Re: New thoughts

Postby krikketdoug » Sun Jun 22, 2014 11:28 pm

berestovskyy wrote:
krikketdoug wrote:1> Walking trails and other non-drivable road types that have a elevation of something other than -5 be flagged.

You can use a custom check in Validator for that:
template: ${typeRank}:${elevation}
regexp: /^5:(?!-5)/


By chance is this one of those features linked to editor rank? I've looked about my system and haven't been able to find a way to do this.

berestovskyy wrote:But in fact at the moment Validator does the opposite. In some countries it highlights walking trails with elevation -5 (check #105).


For the first time I ran across a road that needed to be added, where I had to worry about elevation. Long story short, I double checked the wiki. Aside from the link I believe was previously referenced, https://wiki.waze.com/wiki/Road_types/U ... .2FTaxiway (and yes, that is US specific) I also found: https://wiki.waze.com/wiki/Elevation#Road_elevation

The reason I mention it here is because (I believe) the effort is to get this wonderful extension to match the Wiki. I have no clue how the ROW uses elevation, but since this might be relavent, I thought I'd point it out in an attempt to be helpful. Hopefully I succeeded. :) If I didn't, please accept my apologies.
Krikket
a.k.a. Doug Krick

ImageImage
Chicago Speed and Traffic Cameras
https://webapps1.cityofchicago.org/traffic/
krikketdoug
 
Posts: 160
Joined: Thu Oct 03, 2013 12:01 am
Location: Villa Park, Illinois, USA
Has thanked: 56 times
Been thanked: 14 times

Saint versus Street

Postby krikketdoug » Sun Jun 22, 2014 11:42 pm

An idea for another invalid street name check, that might be workable...

I was out on a drive and I heard a couple of times at different streets, "Turn right on Street Charles Road". Kind of obvious what the problem was when I thought about it. St. is the abbreviation for Saint and Street.

Given that Street would only be used at the end of the street name, but Saint would be used after the directional (if any) and before the name, could Validator look for St in this context?

Just a thought.
Krikket
a.k.a. Doug Krick

ImageImage
Chicago Speed and Traffic Cameras
https://webapps1.cityofchicago.org/traffic/
krikketdoug
 
Posts: 160
Joined: Thu Oct 03, 2013 12:01 am
Location: Villa Park, Illinois, USA
Has thanked: 56 times
Been thanked: 14 times

PreviousNext

Return to Addons, Extensions, and Scripts

Who is online

Users browsing this forum: Motik