[Script] WME Junction Angle Info

Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Moderators: Unholy, bextein, Glodenox, JustinS83

Forum rules
Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

DO NOT START a new thread unless it is about a new idea. Keep discussion of existing tools within the main thread for that tool.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Re: [script] WME Junction Angle Info

Postby sketch » Thu Apr 16, 2015 4:26 am

That's right taco. Conversely, U turns can never be prevented by a segment longer than 15 m. And I do the same, 14 or 16 (if I'm going for a particular result with a road that would otherwise physically dictate a smaller or larger distance).
ALL US EDITORS READ: New USA road type guidance
assistant regional coordinator • south central region • usa
waze global champ • beta leader • tier one • new orleans
2017 chevrolet ss sedan 6mt • slipstream blue metallic
[ img ] [ img ]
sketch
Waze Global Champs
Waze Global Champs
 
Posts: 6444
Joined: Sat Aug 08, 2009 6:13 pm
Location: Nouvelle-Orléans, Louisiane, États-Unis
Has thanked: 2050 times
Been thanked: 2542 times

Re: [script] WME Junction Angle Info

Postby milkboy » Thu Apr 16, 2015 5:20 am

milkboy wrote:Meh.. There is a restriction from 2015-06-01 to 2016-12-31, which is incorrectly detected as a current restriction.. Need to add date range checks also =)


The date based restrictions should work correctly with latest version from GH/GF (1.8.3.1). Won't be releasing new addons for only this change just yet, as it's probably not the most frequently occurring issue ;)
Nexus 5 | CM 13 (Android 6.0.1 nightly)
[ img ][ img ][ img ][ img ]
Škoda Octavia III Combi 2.0 TDI RS DSG 2014 [ img ]
milkboy
Map Editor - level 3
Map Editor - level 3
 
Posts: 107
Joined: Thu Jun 09, 2011 6:24 am
Location: Europe/Finland/Helsinki
Has thanked: 11 times
Been thanked: 123 times

Re: [script] WME Junction Angle Info

Postby milkboy » Thu Apr 16, 2015 5:35 am

Olestas wrote:Hmm.. strange.
JAI shows that this junctions all straight drives will be Keep, but they all are BC.
https://www.waze.com/editor/?env=row&lo ... =167182298

Argh. Good catch. The BC logic should only take angles <=~45 into account. This filter got lost at some point.

EDIT: And yes, this is probably bad enough to actually warrant a new release.


EDIT2: And fixed packages uploaded.
Nexus 5 | CM 13 (Android 6.0.1 nightly)
[ img ][ img ][ img ][ img ]
Škoda Octavia III Combi 2.0 TDI RS DSG 2014 [ img ]
milkboy
Map Editor - level 3
Map Editor - level 3
 
Posts: 107
Joined: Thu Jun 09, 2011 6:24 am
Location: Europe/Finland/Helsinki
Has thanked: 11 times
Been thanked: 123 times

Re: [script] WME Junction Angle Info

Postby FZ69617 » Thu Apr 16, 2015 7:49 am

Just published JAI version 1.8.4.1 including additional fixes to the turn instructions estimation atgorithm:
https://greasyfork.org/en/scripts/9192- ... angle-info

This version contains valuable additions contributed by wlodek76 - thanks!
FZ69617
Waze Local Champs
Waze Local Champs
 
Posts: 933
Joined: Fri Jul 25, 2014 9:29 am
Location: Zielona Góra, Poland
Has thanked: 36 times
Been thanked: 237 times

Re: [script] WME Junction Angle Info

Postby Olestas » Thu Apr 16, 2015 8:11 am

So which one should I use, GH or GF? I keep changing them with each update? :D
[ img ][ img ][ img ][ img ]

GC: Latvia
Coordinator: Latvia
Country manager (Full coverage): Latvia/Lithuania/Belarus/Russia/Ukraine
Olestas
Coordinators
Coordinators
 
Posts: 6358
Joined: Wed Mar 09, 2011 7:08 pm
Location: Latvia
Has thanked: 3482 times
Been thanked: 2360 times

Re: [script] WME Junction Angle Info

Postby FZ69617 » Thu Apr 16, 2015 8:43 am

Olestas wrote:So which one should I use, GH or GF? I keep changing them with each update? :D

Depends on your expectations. :)

If you are an average user of the script, then you can use official releases of the script linked by @milkboy in the opening post there:
https://www.waze.com/forum/viewtopic.ph ... 50#p735439
The recent version published by the author is 1.8.4, which is available on both GH, and GF.

Version 1.8.4.1 (published by me) is say "developer version" and is currently available only on GF:
https://greasyfork.org/en/scripts/9192- ... angle-info
After acceptance by the author a version 1.8.4.1 may become a next offitial version (1.8.5?), but this is a sole decision of the original author, and this may even never happen. :)

Decide yourself on which version you want to use. :D
FZ69617
Waze Local Champs
Waze Local Champs
 
Posts: 933
Joined: Fri Jul 25, 2014 9:29 am
Location: Zielona Góra, Poland
Has thanked: 36 times
Been thanked: 237 times

Re: [script] WME Junction Angle Info

Postby milkboy » Thu Apr 16, 2015 9:24 am

I try to check any patches as soon as possible and add them to the GitHub repository (which then automatically pushes the changes to _my_ Greasy Fork script), with best effort to attribute the changes to whoever made them. The most effortless way (for me at least) to get patches merged (and correctly attributed) is naturally to submit pull requests on GitHub, but I can't and won't require that ;)

As for when and how a "official version" is released (well, release in this case only means updating the Chrome/Firefox addons), there is no process for it.
Nexus 5 | CM 13 (Android 6.0.1 nightly)
[ img ][ img ][ img ][ img ]
Škoda Octavia III Combi 2.0 TDI RS DSG 2014 [ img ]
milkboy
Map Editor - level 3
Map Editor - level 3
 
Posts: 107
Joined: Thu Jun 09, 2011 6:24 am
Location: Europe/Finland/Helsinki
Has thanked: 11 times
Been thanked: 123 times

Re: [script] WME Junction Angle Info

Postby milkboy » Thu Apr 16, 2015 4:09 pm

PR merged :) Quite painless operation that could be done while queuing to pay for a 21mm socket (for tightening wheel bolts) :)
Nexus 5 | CM 13 (Android 6.0.1 nightly)
[ img ][ img ][ img ][ img ]
Škoda Octavia III Combi 2.0 TDI RS DSG 2014 [ img ]
milkboy
Map Editor - level 3
Map Editor - level 3
 
Posts: 107
Joined: Thu Jun 09, 2011 6:24 am
Location: Europe/Finland/Helsinki
Has thanked: 11 times
Been thanked: 123 times

Re: [script] WME Junction Angle Info

Postby milkboy » Thu Apr 16, 2015 4:20 pm

Oh, and if we'd really want to utilize GitHub, I could set up a separate "development" branch that could then be used for testing new stuff, before merging into master. The dev branch could then be used by brave testers who don't mind occasional problems or something. Master would then be considered "release quality"... just some thoughts.
Nexus 5 | CM 13 (Android 6.0.1 nightly)
[ img ][ img ][ img ][ img ]
Škoda Octavia III Combi 2.0 TDI RS DSG 2014 [ img ]
milkboy
Map Editor - level 3
Map Editor - level 3
 
Posts: 107
Joined: Thu Jun 09, 2011 6:24 am
Location: Europe/Finland/Helsinki
Has thanked: 11 times
Been thanked: 123 times

Re: [script] WME Junction Angle Info

Postby milkboy » Thu Apr 16, 2015 5:35 pm

qwaletee wrote:If you place the instruction indicator centered on a line, then you can rotate the text to be perpendicular to the line, and stack two instructions. You would end up with three "rows" within your container:
  • Line closest to junction - directions from "this" segment toward the "other segment" coming out of the junction.
  • Line containing the turn angle.
  • Line furthest from junction - directions from the "other segment" to this segment

Hmm.. Not entirely sure I'm able to visualize this correctly in my head :?
3 lines inside the marker is probably going to make the markers biggish or the text really small..

I wonder if is possible to have multicolored markers =D As in, split in half with matching color code somehow matching the direction.. Might need some deeper insight into how OpenLayers actually work though.
Nexus 5 | CM 13 (Android 6.0.1 nightly)
[ img ][ img ][ img ][ img ]
Škoda Octavia III Combi 2.0 TDI RS DSG 2014 [ img ]
milkboy
Map Editor - level 3
Map Editor - level 3
 
Posts: 107
Joined: Thu Jun 09, 2011 6:24 am
Location: Europe/Finland/Helsinki
Has thanked: 11 times
Been thanked: 123 times

PreviousNext

Return to Addons, Extensions, and Scripts

Who is online

Users browsing this forum: BenEnmen, ciprian-coman