[Script] WME Color Highlights - 2.33 Sept 2020

[seb-d59]

Yes, I just spotted that while reading through the changes you sent me...

Ok , no problem if doctorkb can confirm.

[Sebiseba]

I often check borders of 3-4 countries, and would like to see which segments/places belong to which country. WMECH changes to No city/Country or City/Country.. yes, but could you also add position -/Country, so it does not differ by City/no city.
THanks.

Hi,
Same for States please

[Sebiseba]

Twister-UK,

Maybe it's the same problem : https://www.waze.com/forum/viewtopic.php?f=211&t=176712

[Sebiseba]

Have you tested without others scripts ?

I'm not sure but maybe the scripts without icon tab cause this issue (problem to loading font-awesome).
Since I fixed icons, everything works to perfection

[Sebiseba]

Full fix (add bold text) :
(careful, when you add lines, the numbers change )

Lines 159-161
if (cityID != null && Waze.model.cities.get(cityID).attributes != null) {
noCity = Waze.model.cities.get(cityID).attributes.isEmpty;
countryID = Waze.model.cities.get(cityID).attributes.countryID;
}

Line 807
var thisName = Waze.model.cities.get(thisCity).attributes.name;

Line 940 (cybernissart fix)
var cityname = Waze.model.cities.objects[cid].attributes.name;
var citystateid = Waze.model.cities.objects[cid].attributes.stateID;
var citycountryid = Waze.model.states.get(citystateid).countryID;
You can remove line 940
var city = Waze.model.cities.get(cid);

Line 943 (cybernissart fix)
cityObjs.push({id: cid, name: cityname, state: citystateid, country: citycountryid});



Sometimes highlight places have issu. please add this 2 lines from line 597
if (specificCity) {
if (venue.attributes.streetID === undefined) continue;
venueStreet = Waze.model.streets.get(venue.attributes.streetID);
if (venueStreet === undefined) continue;
selectedCityMatch = (specificCity && venueStreet.cityID == selectedCityId);



Also, if you want icon instead of text in tab, change line 1246 :
newtab.innerHTML = '<a href="#sidepanel-highlights" data-toggle="tab"><span class="fa fa-tint" title="Highlight"></span></a>';



If you want change highlight color for city (Filter by City (Yellow)) :
Lines 384 & 389 :
newColor = "#f90";
Give you orange color

[Sebiseba]

I have but it's Tim's script :/

(Visit french forum about scripts )

[SeveriorumPatrem]

One request, one possible bug. I did not read through the entire thread so my apologies if these came up before and were dismissed and not possible or not wanted.

Possible bug: I have been using the script extensively while auditing city segments, especially under the newer guidance for alt city names attached to ZIP code city names in the US. Generally I use the highlight city option inverted, to highlight segments with incorrect city naming. However, when something happens to my WME browser tab and it gets buggy and I have to load a new tab, the "invert" checkbox becomes unchecked. Not a huge deal, but since the other checkbox selections always come back the same, wondering if this one can be saved for browser reloads, too.

Request: I am also auditing for missing HNs, and the "No HNs" option is great for that. The no HNs feature for TB only works on Street segments, while Highlights works on Streets and higher types (thank you), but neither works on PR segments. Can Color Highlights be modified to show when a PR is named but has no HNs?

Thanks for all your hard work on this stuff, much appreciated.

[SeveriorumPatrem]

Script enhancement request:

Can a "halo" be added around Map Comment Points (MCPs)?

The all-white dot is easy to lose in some aerial imagery, lacks contrast when surrounded by similarly bright backgrounds or in clutter.

At a minimum would love to get a black circle around the white dot, or if you're feeling really creative, the ability to choose from a handful of dark colors that would still contrast with white.

Is that something that can be done?

[SeveriorumPatrem]

Just adding to the list... sorry.... but noticed today that if highlighting for a city name (City X) is enabled - and a particular segment has a different city name (City Y), but does not have City X as an alt and is therefore not highlighted - highlighting for no speed limit is not working.

* Highlights enabled for (1) City X and (2) No speed limit.
* A particular segment's primary city is City Y, and it has no alt cities. It also has no SL. No highlights appear.
* City X added as alt city.
* Segment is now highlighted for lack of speed limit.
* Speed limit added.
* Segment is now highlighted for City X.

This does not occur if the original segment has no primary city. In that case, the no-SL highlight works fine.

It's possible that city highlighting returning a negative result may block all other highlights, but I did not test that.

Maybe it's always been this way and I didn't notice?

[SeveriorumPatrem]

Feature request:

Under the highlight places section, is it possible to highlight places based on city, as can be done with segments? And if so, to invert that highlight?

I am trying to detect places (and more specifically, RPPs) with the wrong USPS city assigned. I'd like to be able to visually scan for RPPs that do *not* have the specified city assigned.