[Script] WME Validator v2021.3.5 (+ PLACES BETA)

[PesachZ]

I'm busy creating a WMEV localization pack for South Africa, but am bashing my head against a wall with some weird errors. The following code works fine for mH segments named R100 to R512, and then again from R516 onwards, but R513, R514 and R515 all get flagged as incorrect. WHY?????

Code: Select all

// Custom Check - Minor Highway Name Format
  "137.enabled": true,
  "137.params": {
    "titleEN": "Incorrect name format on Minor Highway",
    "problemEN": "All Minor Highways name format should be (R###) numbered > 100 ",
    "solutionEN": "Change name to ... (R###)",
    "template": "${typeRank}:${street}:${direction}",
    "regexp": "/(13):(?!R[0-9]{3} [NESW]:(1|2) ?|(R[0-9]{3}:(3))$)/"
  },
  "137.solutionLink": "W:South_Africa#Road_Network",

513 is being flagged because you are not anchoring and it is matching the 13:R513:3 from the string produced by your template.

you could try this and see if works better for you.

Code: Select all

"regexp": "/^13:(?!(R[1-9]\\d{2}( [NESW]:[12] ?|:3))$)/"

I also noticed you are allowing an optional space in the string after the direction on one-way segments, not sure why you would want that, but I did include it. I moved the anchors and groups around a bit to accomplish what I think you want.
"/(13):(?!R[0-9]{3} [NESW]:(1|2) ?|(R[0-9]{3}:(3))$)/"

Edit: your code also allowed numbers <100 such as R099, as long as they were 3 digits. I updated it to only allow >100.
Edit2: shortened code, should still work the same

[PesachZ]

Here's an updated type list (not typerank): fixed Ferry, Stairway, and added Railroad.
${type}

Code: Select all

1:  Street
2:  Primary Street
3:  Freeway
4:  Ramp
5:  Walking Trail
6:  Major Highway
7:  Minor Highway
8:  Dirt Road / 4X4 Trail
9:
10: Pedestrian Boardwalk
11:
12:
13:
14: [i](old: Ferry)[/i]
15: Ferry
16: Stairway
17: Private Road
18: Railroad [i](old: Stairway)[/i]
19: Runway/Taxiway
20: Parking Lot Road
21: [i]Service Road (deprecated)[/i]


[PesachZ]

Quick question : I keep getting this in the Validator report after I scan a certain area.

Might be incorrect city name (only available in the report) (#24)
The segment might have incorrect city name: wiki
Consider suggested city name and use this form to rename the city: forum

Gy — city name is too short
Allée du Chambet, Gy
65434649
...

But that village's name is really just "Gy"
I would use the filter in the city name with !Gy to ignore it, but then it would just not show any potential errors on these segments as they would be ignored (if I understand this right).

How can I make it ignore the "city name is too short" error only, from the report, while still scanning these segments for anything else that could be wrong with them ?

I hope the answer is not too obvious

You can disable check #24 by typing it in the Reported As: of the filters. Assuming that's the only check you want to disable you would type in

Code: Select all

!24,*

[PesachZ]

Sheesh, I can't even get Validator to load at all. The only line in the console on load is "WME Validator v1.1.8: login AlanOfTheBerg". Win7/Chrome 46.0.2490.71 m. Ideas?

Are you in WME Beta? Validator is broken in the latest beta.

Sent from Android using Tapatalk

[PesachZ]

Sheesh, I can't even get Validator to load at all. The only line in the console on load is "WME Validator v1.1.8: login AlanOfTheBerg". Win7/Chrome 46.0.2490.71 m. Ideas?

Are you in WME Beta? Validator is broken in the latest beta.

Nope, I wish it was that simple. I knew that it wasn't working in beta.

Are you using a localization package?

Sent from Android using Tapatalk

[PesachZ]

v 1.1.10 is flagging "Expy" as an incorrectly abbreviated street name.

This is for the US, Expwy is our recommended abbreviation for Expressway

[PesachZ]

Another apparent incorrect flagging: "Int'l", though Jane TTS does say "international".

This was my mistake, I will send a message to the author with a fix for this.
Thanks for bringing it up

the regex for rule #171 in the US will have to be updated to this to fix it.

Code: Select all

"regexp": "/((?!(\\bPhila|\\bPenna|.(\\bWash|\\bCmdr|\\bProf|\\bPres)|..(Adm|\\bSte|\\bCpl|\\bMaj|\\bSgt|\\bRe[vc]|\\bR\\.R|\\bGov|\\bGen|\\bHon|\\bCpl)|...(\\bSt|\\b[JSD]r|\\bLt|\\bFt)|...(#| )[NEWSR])).{5}\\.|(?!(hila|enna|(\\bWash|\\bCmdr|\\bProf|\\bPres)|.(\\bAdm|\\bSte|\\bCpl|\\bMaj|\\bSgt|\\bRe[vc]|\\bR\\.R|\\bGov|\\bGen|\\bHon|\\bCpl)|..(\\bSt|\\b[JSD]r|\\bLt|\\bFt)|..(#| )[NEWSR])).{4}\\.|(?!(ila|nna|(ash|mdr|rof|res)|(\\bAdm|\\bSte|\\bCpl|\\bMaj|\\bSgt|\\bRe[vc]|\\bR\\.R|\\bGov|\\bGen|\\bHon|\\bCpl)|.(\\bSt|\\b[JSD]r|\\bLt|\\bFt)|.(#| )[NEWSR])).{3}\\.|(?!(la|na|(sh|dr|of|es)|(dm|te|pl|aj|gt|e[vc]|\\.R|ov|en|on|pl)|(\\bSt|\\b[JSD]r|\\bLt|\\bFt)|(#| )[NEWSR])).{2}\\.|(#|^)[^NEWSR]?\\.)|(((?!\\b(D|O)).|#|^)\'(?![sl]\\b)|(?!\\b(In|Na)t).{3}\'l|(#|^).{0,2}\'l)|(Dr|St)\\.(#|$)|,|;|\\\\|((?!\\.( |#|$|R))\\..|(?!\\.( .|#.|$|R\\.))\\..{2}|\\.R(#|$|\\.R))|[Ee]x(p|w)y|Tunl|Long Is\\b|Brg/",

[PesachZ]

Does this mean we need to change the tens of thousands of segments in the area that have "Expy".

And which of the many abbreviations charts are we supposed to use?

That's something your SM/CM can answer.

I have. They think "Expy" is acceptable. But PesachZ's reply suggests otherwise, as do the thousands of flags and highlighted segments from Validator.

By the way, this is a new flag from Validator since the latest update. Expy wasn't flagged prior.

The list in the USA abbreviations wiki is the definitive list. It is still being updated, and expwy will be added to it shortly. Once complete that will the all inclusive source for recommended abbreviations.

As to changing them, its not urgent but something you do as you work on other things.

Sent from Android using Tapatalk

[PesachZ]

Would it be possible to add the recently added speed limits and tunnel indications to the custom template list? I propose the names ${speedAB}, ${speedBA} and ${tunnel}.

Let's say, hypothetically, roads that haven't had speed limits entered after XX time frame are entered automatically by waze_bot via third party source. Will TB be able to pick that up if there is no edit name attached to it?

This is the Validator thread, but to answer your question based on previous behaviors:
After an import is done any speeds entered by editors should display as "verified". Scripts will most likely be able to detect the " verified " flag.

Sent from Android using Tapatalk

[PesachZ]

v 1.1.10 is flagging "Expy" as an incorrectly abbreviated street name.

This is for the US, Expwy is our recommended abbreviation for Expressway

After 3+ years of it being an accepted abbreviation across the US, why did it change to unaccepted?

It wasn't my decision, and I don't want to speak for others, or put words in their mouths. What follows is my assumption of the issue.
"Expy" was included as the road names on the basemap, and was grandfathered into acceptance for lack of an initiative to use better naming.
With the restructuring of the TTS engine, a concerted effort was led by several champs to generate a comprehensive list of recommended abbreviations which are a better for a navigation app.
They relied heavily on several official sources, primarily the MUTCD.

The MUTCD lists "Expwy" as the exclusive acceptable abbreviation for expressway.

I believe most BGS where expressway is abbreviated it appears as "Expwy", and not "Expy".

Our goals are to help wazers match instructions as easily as possible with what they see around them. That said if the BGS does not use "Expy", and the MUTCD recommends against it, there's no reason we should be using it.

Now if the BGS in your area do actually use Expy as an abbreviation then that may be a factor worth reconsidering. If this is the case in a large area please bring it up so we can evaluate it.

Sent from Android using Tapatalk