jdelosa wrote:Does any of this get the UR comments to return back to the last tab before it was activated???

Version 1.4.7 fixed the switch back to previous tab option and I made it set the scroll height back to the previous scroll height.

bz2012 wrote:Just noticed that I have been 'double reminding' as it has been auto-adding a reminder and THEN showing the UR without the added reminder, automatically adding the text for a second reminder and waiting for me to hit the 'send' button.

Then, the 'comment count' updates from 1c to 3c.

The other, updated URs, in the same area, don't show they have been updated until I do a refresh.

If I am understanding correctly, URC sends auto reminders and then you use URMP to open the same UR and send another reminder?

let me start with i don't user URMP and have no idea how to use it correctly. that being the case I never intended for the auto reminders to be used with URMP.

The great part about the auto reminders is that they happen quickly in the background, the problem is that WME doesn't know about background comments until you refresh the map data.

URC loads the comment counts and days from the background data so moving or zooming the map around will update the counts shown with URC but not the UR data. I had to trick URC not to send double reminders by adding a tag to each UR that received a auto reminder and then URC hides those pins. after a refresh those tags are cleared and the new UR data is loaded.

if you were to find and click one of the UR that got a auto reminder WME would not show the reminder message until you close the UR window and a refresh was done.

if you want to use the auto reminders with URMP or another script, if you see the message that reminders had been sent, Close the UR window and reload or refresh before using URMP.

i can make it so the function that sets the reminder text to the UR window checks for the ReminderSent tag and not fill in the reminder message if it had a reminder. i can try to close the UR, refresh the data, and send a message why. but this would require everyone to update the language and custom files. this also wouldn't be guaranteed to work with all other scripts.

russblau wrote:Reminder messages are not adding the "To reply..." message for me. If I select a 4-day old UR it loads the standard "Just a reminder" text but not the additional "To reply..." message with the URL. I do have "Auto set reminder UR comment" checked, but not "Auto send reminders."

That option and message were removed please read some of the previous posts for an explanation why.

citeman wrote:Rick,
Is it your script or another script that made the UR interface window larger (top to bottom of the WME)? With the recent WME updates, that feature is now broken for me. I'm trying to track down, what I need to fix...

I removed the code that made the UR full screen height, the huge amount of white space on new URs was not well received.

taco909 wrote:Or even better, if we could click and drag the bottom.

I understand those on shallow screens wanting a shorter window, and without sensing the display area, it is impossible to code a height that works for every display.

I was just asked to make it even smaller, since the ur window forces the edit area to have scroll bars when at 1368x768.

I think I will play around and see if it works with a setting or perhaps I can auto sense the browser size. Maybe a drop down with a bunch of sizes to choose from.

Twister-UK wrote:

rickzabel wrote:I think I will play around and see if it works with a setting or perhaps I can auto sense the browser size. Maybe a drop down with a bunch of sizes to choose from.

window.innerHeight is a good place to start, though depending on whether the UR edit UI is positioned relative to the whole window or to the map view area you may then need to grab the height of the menu/wazebar in order to work out what the effective window height is as far as the UI element is concerned. URO+ needs to be browser size aware to prevent its popups going off the edge of the screen, so if you're after a bit of inspiration then have a look in uroNewLookHighlightedItemsCheck() to see how it's handled in there.

I hadn't had time to get to my computer but I'll check this out when I do, thanks!

bz2012 wrote:I have been seeing a strange problem related to the little 'take me to this UR' button in the upper right corner of the box I see when a UR is opened:
It used to take me back to the UR, If I had somehow moved it out of my window.
Now, occasionally, for no reason I have been able to figure out, I sometimes find WME has shifted my view to someplace strange and if I click on the 'take me to this UR' button, it takes me someplace else weird rather than back to where the UR is visible.

jdelosa wrote:I have noticed the same thing and the centering is sometimes off.it use to be very consistent the UR window would be screen left and the UR was placed in the center of the screen just to the right of the UR box....

I noticed this also so i just did some playing around and i bet we have one thing in common, we are using URO to disable auto centering on URs. whats going on is the cross hair button used to take you to the UR now it only zooms the map in on your current view. If you don't have the UR center screen then you appear to be taken somewhere very random.

i already had code that was looking for the UR window and code that would zoom to a UR by ID so i combined them to attach a listener to the click of the cross hairs with a 500 millisecond delay. now when clicked waze will zoom in but then URC will take you to the UR and set the zoom to 5.
there might be a slight delay before the button is ready, the same delay it takes the text to auto in the comment box.

this will be included in the next version, but before posting i am going to try to work on the UR size.

Twister-UK wrote:

rickzabel wrote:I think I will play around and see if it works with a setting or perhaps I can auto sense the browser size. Maybe a drop down with a bunch of sizes to choose from.

window.innerHeight is a good place to start, though depending on whether the UR edit UI is positioned relative to the whole window or to the map view area you may then need to grab the height of the menu/wazebar in order to work out what the effective window height is as far as the UI element is concerned. URO+ needs to be browser size aware to prevent its popups going off the edge of the screen, so if you're after a bit of inspiration then have a look in uroNewLookHighlightedItemsCheck() to see how it's handled in there.

i am giving up on making the UR window fit the comments + editor. window.innerHeight returns different numbers if i have a browser maximized vs stricted to fix the screen. worse off each of my monitors return different numbers when set to the same resolution.

jdelosa wrote:Thanks for giving it the old college try.....

for about 4-5 hours i was trying different things, it's not as much fun when you don't have progress to show! I also for that on top of all that firefox also reports different numbers

citeman wrote:

rickzabel wrote:

jdelosa wrote:Thanks for giving it the old college try.....

for about 4-5 hours i was trying different things, it's not as much fun when you don't have progress to show! I also for that on top of all that firefox also reports different numbers

Drat!!! Maybe you can just pick three sizes: small, medium, and large. That would be more awesome than what it is now... Would something like that be doable?

same problem comes into play what sizes do i choose?

we can all do an experiment if we get enough data then perhaps i can add a choice.

1. find a UR that has a ton of comments or make a fake one.
2. in chrome you can right click on a scroll bar and click inspect. right click on the scroll bar in the comment area and click inspect element
3. in the code it should highlight an <ul with the class of "comment-list list-unstyled"
4. look in the side window for "max-height: 190px;"
5. click and change the 190px to whatever height does not force the UR window to go off the bottom of the edit area and does not cause the UR to have double scroll bars. (make sure not to remove the px)
6. post what resolution you are at and what max-height works for your resolution

the results i have are
1366*768 max height is 80px
1600*1200 max height is 520px
1920*1080 max height 410px