[Script] UrComments

Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Moderators: Unholy, bextein, Glodenox, JustinS83

Forum rules
Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

DO NOT START a new thread unless it is about a new idea. Keep discussion of existing tools within the main thread for that tool.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Re: [Script] UrComments

Postby rickzabel » Thu Jan 28, 2016 3:56 am

helifino206 wrote:New bug:
Selecting a response sometimes doesn't do anything until I click a few different responses, then one works and it auto-centers and I can then go back to the original response I wanted to send.


i can not reproduce this, what browser, browser version, and OS are you using?
[ img ]
Chicago Illinois Suburbs , Main areas Downers Grove, Naperville, and Auroa
https://wiki.waze.com/wiki/User:Rickzabel
rickzabel
Map Editor - level 3
Map Editor - level 3
 
Posts: 222
Joined: Sat Sep 20, 2014 1:05 am
Location: Aurora / Downers Grove Illinois
Has thanked: 0 time
Been thanked: 277 times

Re: [Script] UrComments

Postby rickzabel » Sun Jan 31, 2016 7:27 pm

helifino206 wrote:I have yet to encounter the click issue since the upgrade, but auto-centering is still unreliable.

Linux Mint 17, Google Chrome 48.0.2564.97 from package google-chrome-stable.



WME auto now automatically centers on a UR when clicked, meaning we should not be using the option in in URC to autocenter. be aware If you are running URO it disables auto centering. there used to be a checkbox for this but i can't seem to find it.
[ img ]
Chicago Illinois Suburbs , Main areas Downers Grove, Naperville, and Auroa
https://wiki.waze.com/wiki/User:Rickzabel
rickzabel
Map Editor - level 3
Map Editor - level 3
 
Posts: 222
Joined: Sat Sep 20, 2014 1:05 am
Location: Aurora / Downers Grove Illinois
Has thanked: 0 time
Been thanked: 277 times

Re: [Script] UrComments

Postby rickzabel » Sun Feb 07, 2016 3:42 pm

n4dog wrote:
KuniaKid wrote:It seems to be broken for beta. Works fine in prod.

I was just coming to comment of this issue. Still not able to use it in beta :(

should be working in both waze renamed a function.
[ img ]
Chicago Illinois Suburbs , Main areas Downers Grove, Naperville, and Auroa
https://wiki.waze.com/wiki/User:Rickzabel
rickzabel
Map Editor - level 3
Map Editor - level 3
 
Posts: 222
Joined: Sat Sep 20, 2014 1:05 am
Location: Aurora / Downers Grove Illinois
Has thanked: 0 time
Been thanked: 277 times

Re: [Script] UrComments

Postby rickzabel » Sun Feb 07, 2016 7:26 pm

AquaZR1 wrote:I'm guessing an update is coming to handle the new version of WME? Looks like URComments is not fully loading.

Thanks
already done, update
[ img ]
Chicago Illinois Suburbs , Main areas Downers Grove, Naperville, and Auroa
https://wiki.waze.com/wiki/User:Rickzabel
rickzabel
Map Editor - level 3
Map Editor - level 3
 
Posts: 222
Joined: Sat Sep 20, 2014 1:05 am
Location: Aurora / Downers Grove Illinois
Has thanked: 0 time
Been thanked: 277 times

Re: [Script] UrComments

Postby rickzabel » Wed Feb 10, 2016 12:12 am

n4dog wrote:No longer working on regular WME now :(

what version are you on V1.6.1? any details what is not working?
[ img ]
Chicago Illinois Suburbs , Main areas Downers Grove, Naperville, and Auroa
https://wiki.waze.com/wiki/User:Rickzabel
rickzabel
Map Editor - level 3
Map Editor - level 3
 
Posts: 222
Joined: Sat Sep 20, 2014 1:05 am
Location: Aurora / Downers Grove Illinois
Has thanked: 0 time
Been thanked: 277 times

Re: [Script] UrComments

Postby rickzabel » Thu Feb 11, 2016 3:22 am

roadtechie wrote:Rick, the "Auto zoom in on new UR" feature is still zooming into the wrong location on the map. Just wanted to make sure you were aware. This is happening in production and beta.


it seems that whenever URO is enabled/installed the 'auto zoom in' on URC does not work correctly. unchecking enabled after UROverview Plus 3.71 restores the auto zoom

i am pulling the long at lat from waze and using their set center command to zoom in.

if you want to test; replace the urid with one that is on screen and then paste the following code into console. or goto this link and then run the code from console.

https://www.waze.com/editor/?env=usa&lo ... ueFilter=0

var zoom = 5;
var urID = 5033746;
var x = Waze.model.mapUpdateRequests.objects[urID].attributes.geometry.x;
var y = Waze.model.mapUpdateRequests.objects[urID].attributes.geometry.y;
console.log("gotoURById: " + "x: " + x + "y: " + y + "zoom: " + zoom);
Waze.map.setCenter([x, y], zoom);

i started looking into this when you posted your comment and it took this long to figure out what was the cause. I dont know when / if i will look into this further...
[ img ]
Chicago Illinois Suburbs , Main areas Downers Grove, Naperville, and Auroa
https://wiki.waze.com/wiki/User:Rickzabel
rickzabel
Map Editor - level 3
Map Editor - level 3
 
Posts: 222
Joined: Sat Sep 20, 2014 1:05 am
Location: Aurora / Downers Grove Illinois
Has thanked: 0 time
Been thanked: 277 times

Re: [Script] UrComments

Postby rickzabel » Sun Feb 14, 2016 12:01 am

Twister-UK wrote:If you're running that code when the UR marker is clicked (and therefore highlighted), it'll fail with URO+ active because the geometry.x attribute no longer points to the correct location...

To work around the problem where two or more markers are stacked at the same coordinates and WME always opens up the editing panel for the topmost marker even if you specifically request it opens up the panel for one of the underneath markers, URO started allocating unique geometry.x values to the UR markers - this allowed the unstacked markers to be selected correctly, because WME would no longer see multiple markers at the same coordinates.

After WME then started doing its annoying auto-centre thing, it became apparent that this workaround for stacked markers also acted as a way to block auto-centre too, and so I modified URO so that it would always apply this geometry.x adjustment whenever a UR marker was highlighted, even if it wasn't part of a marker stack.

In order to re-enable centering on the UR when the crosshairs icon was clicked in the edit panel, URO also saves a copy of the unadjusted geometry.x value into a temporary geometry.realX attribute, and restores this back into geometry.x whenever the marker is unhighlighted (e.g. when you've moused-over the edit panel). This also means that if you try to centre on the marker via any other means when it isn't highlighted (e.g. clicking on a feed entry for that UR), WME will also be able to centre on it correctly.


So to get your centering code working ok when URO+ is also enabled, what you should do is replace the var x = ... line above with:

Code: Select all
var x;
if(Waze.model.mapUpdateRequests.objects[urID].attributes.geometry.realX === undefined)
{
   x = Waze.model.mapUpdateRequests.objects[urID].attributes.geometry.x;
}
else
{
   x = Waze.model.mapUpdateRequests.objects[urID].attributes.geometry.realX;
}


Thank you this should fix both the auto zoom and auto center options.
[ img ]
Chicago Illinois Suburbs , Main areas Downers Grove, Naperville, and Auroa
https://wiki.waze.com/wiki/User:Rickzabel
rickzabel
Map Editor - level 3
Map Editor - level 3
 
Posts: 222
Joined: Sat Sep 20, 2014 1:05 am
Location: Aurora / Downers Grove Illinois
Has thanked: 0 time
Been thanked: 277 times

Re: [Script] UrComments

Postby rickzabel » Sun Feb 14, 2016 6:36 pm

houseofmiracle wrote:Hi, I have a question

How to set the position of UR is not in the middle of the screen when we click?
I have not checklist "Auto center on UR"
[ img ]

Thank you


Waze now auto centers on every UR, install URO+ to stop the auto centering.
[ img ]
Chicago Illinois Suburbs , Main areas Downers Grove, Naperville, and Auroa
https://wiki.waze.com/wiki/User:Rickzabel
rickzabel
Map Editor - level 3
Map Editor - level 3
 
Posts: 222
Joined: Sat Sep 20, 2014 1:05 am
Location: Aurora / Downers Grove Illinois
Has thanked: 0 time
Been thanked: 277 times

Re: [Script] UrComments

Postby rickzabel » Wed Mar 02, 2016 2:52 pm

GiancarloG wrote:Great and very useful script! Just a question though... (and sorry for not being able to go through all the pages in the thread due to lack of time but...)

Is it possible to have custom comments? I use the spanish version but some of the preloaded comments may sound a bit strange, at least not from someone in my country. If no custom comments are possible, would it be possible to modify the script so that I can have more colloquial comments?

Thanks!


If you want we can modify the spanish list to be an Ecuador list. otherwise install the custom comments file and manually edit the comments in that script. https://greasyfork.org/en/scripts/6236- ... ustom-list
[ img ]
Chicago Illinois Suburbs , Main areas Downers Grove, Naperville, and Auroa
https://wiki.waze.com/wiki/User:Rickzabel
rickzabel
Map Editor - level 3
Map Editor - level 3
 
Posts: 222
Joined: Sat Sep 20, 2014 1:05 am
Location: Aurora / Downers Grove Illinois
Has thanked: 0 time
Been thanked: 277 times

Re: [Script] UrComments

Postby rickzabel » Sun Mar 13, 2016 8:09 pm

s18slider wrote:Something with this script drops the view of the UR Problem to just 3 lines of text. Is there a fix for this?


I was getting feedback that URC was stopping people from reading the descriptions, when I set the conversation to the last comment. The compromise I had was to move the description up one DIV so it is always visible. I then limited it to 3 lines so it was not blocking the conversation view.
[ img ]
Chicago Illinois Suburbs , Main areas Downers Grove, Naperville, and Auroa
https://wiki.waze.com/wiki/User:Rickzabel
rickzabel
Map Editor - level 3
Map Editor - level 3
 
Posts: 222
Joined: Sat Sep 20, 2014 1:05 am
Location: Aurora / Downers Grove Illinois
Has thanked: 0 time
Been thanked: 277 times

PreviousNext

Return to Addons, Extensions, and Scripts

Who is online

Users browsing this forum: No registered users