[Script] UrComments

Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Moderators: Unholy, bextein, Glodenox, JustinS83

Forum rules
Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

DO NOT START a new thread unless it is about a new idea. Keep discussion of existing tools within the main thread for that tool.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Re: [Script] UrComments

Postby russblau » Thu Aug 04, 2016 9:52 pm

russblau wrote:On the beta editor, I can't post any comments on URs when this script is active. (All other functions seem to operate OK, but the "Send" button is inoperative. Not a problem on production editor.


Update: This bug only occurs if I select an auto-response and then hit "Send" without any intervening editing. If I erase and then retype one character in the response, I can then send it OK.
[ img ][ img ][ img ][ img ][ img ]
MAR MSM; State Manager: District of Columbia
russblau
State Manager
State Manager
 
Posts: 1531
Joined: Fri Oct 19, 2012 11:36 pm
Has thanked: 333 times
Been thanked: 657 times

Re: [Script] UrComments

Postby russblau » Thu Aug 18, 2016 4:37 pm

rickzabel wrote:
russblau wrote:On the beta editor, I can't post any comments on URs when this script is active. (I changed the permissions manually to allow it to run on beta.waze.com.) All other functions seem to operate OK, but the "Send" button is inoperative. Not a problem on production editor.

[EDIT] Console log shows the following error (every tenth of a second from when I click the Send button until I "x" out of the UR entirely):
Code: Select all
Uncaught TypeError: Cannot read property 'getID' of undefined      VM241:6724
  uroTSTCommentAddedHandler @ VM241:6724
  uroTenthSecondTick @ VM241:7014


I did not look in to why this error is happening but both of those are from URO not URC.


Hmm, you're right. Disabling URO+ does stop the console errors from appearing, but does not fix the bug; auto-text in the UR box still can't be saved until it has been edited.
[ img ][ img ][ img ][ img ][ img ]
MAR MSM; State Manager: District of Columbia
russblau
State Manager
State Manager
 
Posts: 1531
Joined: Fri Oct 19, 2012 11:36 pm
Has thanked: 333 times
Been thanked: 657 times

Re: [Script] UrComments

Postby RussPA » Fri Sep 09, 2016 3:56 pm

AquaZR1 wrote:I had to disable the auto-zoom in and auto-center as it was taking me elsewhere every time. Anyone else seeing this behavior?

I am still seeing this issue. If I turn off auto zoom but leave on auto center, when I click a UR, about half the time it does not auto center, my screen just stays as it was. If I close the UR window and click that UR again, it does auto center. Seems to be random on when it chooses to auto center or not. So it appears the problem is with auto center, not auto zoom.
[ img ] [ img ] [ img ] [ img ] [ img ][ img ] [ img ]
Assistant Regional Coordinator - NOR
Global Champ - US
WME Beta Community Coordinator
RussPA
Waze Global Champs
Waze Global Champs
 
Posts: 2979
Joined: Fri Nov 06, 2015 9:05 pm
Location: Bucks County, Pennsylvania
Has thanked: 491 times
Been thanked: 1266 times

Re: [Script] UrComments

Postby RussPA » Sat Sep 10, 2016 1:28 pm

rickzabel wrote:I have not and did not plan on doing anything to attempt to fix this. I think it's conflict between scripts, if you have uro installed disable it and see if the issue still happens.

The problem goes away if URO is disabled. I even tried disabling all the options in URO and leaving it enabled, but the problem still happens.
[ img ] [ img ] [ img ] [ img ] [ img ][ img ] [ img ]
Assistant Regional Coordinator - NOR
Global Champ - US
WME Beta Community Coordinator
RussPA
Waze Global Champs
Waze Global Champs
 
Posts: 2979
Joined: Fri Nov 06, 2015 9:05 pm
Location: Bucks County, Pennsylvania
Has thanked: 491 times
Been thanked: 1266 times

Re: [Script] UrComments

Postby RussPA » Fri Nov 18, 2016 5:14 pm

ojlaw wrote:i can't see any pills. is that just me or do other people have this problem? thanks!

See this post. URO+ generates those images, not URC.
[ img ] [ img ] [ img ] [ img ] [ img ][ img ] [ img ]
Assistant Regional Coordinator - NOR
Global Champ - US
WME Beta Community Coordinator
RussPA
Waze Global Champs
Waze Global Champs
 
Posts: 2979
Joined: Fri Nov 06, 2015 9:05 pm
Location: Bucks County, Pennsylvania
Has thanked: 491 times
Been thanked: 1266 times

Re: [Script] UrComments

Postby RussPA » Mon Nov 21, 2016 7:52 pm

abc1357 wrote:I see that URComments was updated to 1.7.4 today, but it's not loading for me, even with all scripts off. WME on Chrome.

Same here, huge list of errors on the console (just a few here):
VM2557:59 Syntax error @ "WME URComments (Stable)"!
##########################
JSHINT output:
require: (W058) Missing '()' invoking a constructor on line: 52 at character: 33
require: (W058) Missing '()' invoking a constructor on line: 53 at character: 30
require: (W058) Missing '()' invoking a constructor on line: 54 at character: 34
require: (W058) Missing '()' invoking a constructor on line: 55 at character: 29
require: (W058) Missing '()' invoking a constructor on line: 56 at character: 29
require: (W032) Unnecessary semicolon on line: 61 at character: 6
require: (W041) Use '===' to compare with 'null' on line: 78 at character: 23
require: (W041) Use '===' to compare with 'false' on line: 92 at character: 64
require: (W030) Expected an assignment or function call and instead saw an expression on line: 121 at character: 127
require: (W032) Unnecessary semicolon on line: 257 at character: 6
require: (W032) Unnecessary semicolon on line: 333 at character: 6
require: (W032) Unnecessary semicolon on line: 354 at character: 6
require: (W032) Unnecessary semicolon on line: 385 at character: 6
require: (W032) Unnecessary semicolon on line: 484 at character: 6
script: (E058) Missing semicolon on line: 31 at character: 76
script: (W030) Expected an assignment or function call and instead saw an expression on line: 31 at character: 77
script: (E058) Missing semicolon on line: 31 at character: 85
script: (W030) Expected an assignment or function call and instead saw an expression on line: 31 at character: 86
[ img ] [ img ] [ img ] [ img ] [ img ][ img ] [ img ]
Assistant Regional Coordinator - NOR
Global Champ - US
WME Beta Community Coordinator
RussPA
Waze Global Champs
Waze Global Champs
 
Posts: 2979
Joined: Fri Nov 06, 2015 9:05 pm
Location: Bucks County, Pennsylvania
Has thanked: 491 times
Been thanked: 1266 times

Re: [Script] UrComments

Postby RussPA » Wed Dec 28, 2016 8:23 pm

I would agree. Even if I just leave a UR open on my screen, after about a minute or two the WME tab slows to a complete crawl. No problems otherwise if I don't have a UR open.
[ img ] [ img ] [ img ] [ img ] [ img ][ img ] [ img ]
Assistant Regional Coordinator - NOR
Global Champ - US
WME Beta Community Coordinator
RussPA
Waze Global Champs
Waze Global Champs
 
Posts: 2979
Joined: Fri Nov 06, 2015 9:05 pm
Location: Bucks County, Pennsylvania
Has thanked: 491 times
Been thanked: 1266 times

Re: [Script] UrComments

Postby RussPA » Tue Jan 31, 2017 12:49 am

Any progress on identifying or fixing the memory leak issue? I keep getting "Aw snap" message if I leave a UR open for too long.
[ img ] [ img ] [ img ] [ img ] [ img ][ img ] [ img ]
Assistant Regional Coordinator - NOR
Global Champ - US
WME Beta Community Coordinator
RussPA
Waze Global Champs
Waze Global Champs
 
Posts: 2979
Joined: Fri Nov 06, 2015 9:05 pm
Location: Bucks County, Pennsylvania
Has thanked: 491 times
Been thanked: 1266 times

Re: [Script] UrComments

Postby RussPA » Sat Mar 18, 2017 1:42 am

This script updated for me to v1.7.9, and now my custom comment files give me the "Your comments file Custom is outdated, has errors..." error. The first post here still shows v1.7.2. What has changed?

EDIT: NM, I had the custom comments scripts disabled in Tampermonkey. Still curious about a change log, though.
[ img ] [ img ] [ img ] [ img ] [ img ][ img ] [ img ]
Assistant Regional Coordinator - NOR
Global Champ - US
WME Beta Community Coordinator
RussPA
Waze Global Champs
Waze Global Champs
 
Posts: 2979
Joined: Fri Nov 06, 2015 9:05 pm
Location: Bucks County, Pennsylvania
Has thanked: 491 times
Been thanked: 1266 times

Re: [Script] UrComments

Postby RussPA » Wed Mar 29, 2017 12:16 pm

jdelosa wrote:Each UR should be reviewed and tried to be fixed.

I thank Rick for this tool, I use it in conjunction with my detective skills and fix the map.

I totally agree. Each UR should be investigated before any response is sent, as some can be fixed right off. And if not, you can often ask a specific question that may save some back and forth with the reporter. Automatically sending a canned response without even looking first is not a good editing skill, IMO.
[ img ] [ img ] [ img ] [ img ] [ img ][ img ] [ img ]
Assistant Regional Coordinator - NOR
Global Champ - US
WME Beta Community Coordinator
RussPA
Waze Global Champs
Waze Global Champs
 
Posts: 2979
Joined: Fri Nov 06, 2015 9:05 pm
Location: Bucks County, Pennsylvania
Has thanked: 491 times
Been thanked: 1266 times

PreviousNext

Return to Addons, Extensions, and Scripts

Who is online

Users browsing this forum: jm6087, Mythdraug, steveinark