iainhouse wrote:The prevent auto-centring is also affecting Map problems, which saves me asking for that.

However, could we have 'Replace "Next update request" button' working for MPs as well as URs please?

Interesting, I take it you're using Chrome here when you say MPs are "fixed", because they currently still auto-centre in Firefox which is how I'd expect them to behave given that I've only applied the fix to UR markers...

In any event, now I know how to stop the native behaviour (both auto-centre and the replacement of the Done button) for URs, applying the same fixes to the MP and PUR UIs shouldn't be too much work. He says, hoping that he hasn't just invoked the famous last words variation of Sods Law.

NorfolkMustard wrote:It's a shame the last few additions have all needed to be "Replace..." , "Disable...", "Hide..." but a big thank you for doing so

Quite. I know it's a tradition of each WME release that the devteam give us something to moan about, but this time they really seem to have gone the extra mile.

iainhouse wrote:I might have been wrong! I'm sure MPs weren't centring earlier, but they are now. So, yes, I'd be happy to see that behaviour squashed as well.

It may have been that they genuinely weren't centring earlier, but that could well have been down to the native auto-centre functionality being broken rather than anything URO+ was doing. I was sure Tim's WMECH and WMERC scripts weren't playing nicely earlier today, but an hour or so later without any changes at my end, everything was fine again. And someone else said WMERC wasn't working properly, only to then follow up a bit later to say it was fine again too.

So I'm thinking that WME itself was experiencing another one of its wibbles earlier today, which would then be consistent with all of the reports that've been coming in about periods of instability/sluggishness/etc since the update went public.

3.60 extends the "disable auto-centre" and "replace the Next... button with a Done button" options to MPS and PURs, and also performs latitude correction on the map scale bar.

Notes:

For PURs which have multiple updates associated with a single place, the UI will still show the "Next" button so that you can click through all of the updates. It's only the "Next place" button which is replaced here.

The "Done" text is now taken from the currently selected I18n translations data.

To prevent the scale bar now being too wide for the screen, the imperial side of the bar is hidden when WME is set to work in metric and vice versa. When switching between units, or when a WME session is first loaded, the scale bar will not be correctly corrected and a manual pan/zoom of the map view will be required.


Firefox+Greasemonkey version: https://greasyfork.org/scripts/1952-uroverview-plus-uro
Chrome Web Store version: https://chrome.google.com/webstore/deta ... mjcdghdphi

Yes, that's an unfortunate side-effect of taking the easy/least-risky approach to disabling the centre-on-marker-click behaviour so many of us want to get rid of, because the more desirable centre-on target-icon-click behaviour uses the same native code to reposition the map, and so disabling the former also disables the latter...

It's something I'd like to resolve at some point, but as it doesn't feel like a major issue then it's currently low down on my priority list.

Just identified a potentially confusing issue related to the identical-UR-coordinate click workaround, and a slightly annoying visual glitch caused by the PUR auto-centre disable option...

Identical-UR-coordinate issue:

If WME has multiple UR markers at the same co-ords, but you use URO+ filters to hide all but one of the markers, the unstacking code will (correctly) not reposition the markers as there's no need to unstack a single visible marker.

However, because the unstacking code doesn't kick in, neither does the identical-coordinate marker selection workaround.

Therefore, when clicking on the single marker that remains visible in the stack, WME will revert to doing its stupid "search for the topmost marker at these co-ords" thing when deciding which UR details to show in the edit UI - these will only be the correct details if the filter settings happen to have left the topmost marker visible.


PUR auto-centre disable issue:

If auto-centring is disabled for PURs, and you then reject or approve a PUR, the green "solved" marker is now placed at the centre of the mapview... This doesn't prevent you from solving PURs, it just means that until you save the changes you'll be left with one or more mispositioned PUR markers.


Meh.

Umm, yes, that would be something slightly bug-like Seems I'd forgotten to include the PUR filters when testing the master enable setting - I'll have this fixed this in the next release...

bmtg wrote:I see a few posts back that the scale bar is now only set to one type of unit depending on a setting (Which?). Is there a way to disable that hiding? I use both unit type scale bars for different reasons. (I am meaning the scale bar that lives below the chat window).

Thx
bmtg

URO+ uses the imperial/metric setting in the native WME settings tab to decide which side of the scale bar to hide, and this isn't something that can be disabled in the current version. I'll see if leaving both sides visible at all times works OK - I seem to recall at one point during testing on a smaller browser window, the two scaled bars side by side were too wide for the window, but that may have been related to a bug in the early version of the scaling code, so it might now be safe to have them both displayed...

There's already an option to filter by keyword in the UR description or comments, which would at least let you find those URs quickly even without them having a custom marker. Would that suffice, or do you still think it'd be better to have a custom marker option as well?

hmarian wrote:Trying to filter URs using the feature "Last comment less than X days ago" I can see URs that I made comments on within the X range. URs commented by others are not showing, only those with my comments.

HM.

The only way I can replicate behaviour like this is if I've commented on a UR which is also tagged (i.e. [INFO] etc.) and I've got the "Don't apply state/age filters to tagged URs" option ticked. For non-tagged URs, or if I don't have that option ticked, the "last comment less than..." filter seems to be working just fine regardless of who commented on the URs.

Is this still causing you an issue now? If so, please send me a copy of your URO settings.