Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.
Post by Glodenox
Weird, that seems like some caching issue at Greasyfork. It seems to be working fine for me, though.
Do you also not get the update when you click the "Last updated" date shown in the list of scripts in the TamperMonkey Dashboard?
 
Glodenox
Waze Global Champs
Waze Global Champs
Posts: 1568
Answers: 1
Has thanked: 278 times
Been thanked: 946 times
Send a message
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
https://www.tomputtemans.com/images/WazeBelgium.pnghttps://www.tomputtemans.com/images/WazeWMEbeta.png

Post by Glodenox
Can you give more information on what is broken? I've just tested it in both production and beta and both the "drag to get the lines" and "enable the layer to get the lines" seem to work just fine for me.
Glodenox
Waze Global Champs
Waze Global Champs
Posts: 1568
Answers: 1
Has thanked: 278 times
Been thanked: 946 times
Send a message
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
https://www.tomputtemans.com/images/WazeBelgium.pnghttps://www.tomputtemans.com/images/WazeWMEbeta.png

Post by Glodenox
I've just released version 1.0.0 to deal with some upcoming minor changes in the WME that would break the script. There are no big changes in the script, but I think this script can be seen as complete in functionality, deserving the increase in the major version number.

I did notice Greasy Fork is still providing the older 0.9.0 version code for some reason, so hopefully that won't stay an issue for too long.
Glodenox
Waze Global Champs
Waze Global Champs
Posts: 1568
Answers: 1
Has thanked: 278 times
Been thanked: 946 times
Send a message
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
https://www.tomputtemans.com/images/WazeBelgium.pnghttps://www.tomputtemans.com/images/WazeWMEbeta.png

Post by Glodenox
Coming straight to you from the EMEA meetup in Lisbon, Portugal: a new version of the script that detects Street View mode in a different way. Basically, whenever the Street View button is active ( = blue), the layer should activate automatically. I think I've covered all cases with this, but I didn't get to do a very thorough testing here.

The issue you've encountered was caused by Waze removing and re-adding the control buttons on the right. Whenever that happened, the script assumed that the button was being dragged and that it had to display the Street View lines.
Glodenox
Waze Global Champs
Waze Global Champs
Posts: 1568
Answers: 1
Has thanked: 278 times
Been thanked: 946 times
Send a message
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
https://www.tomputtemans.com/images/WazeBelgium.pnghttps://www.tomputtemans.com/images/WazeWMEbeta.png

Post by Glodenox
I personally haven't run into the bug again yet. It should now only trigger when the Street View button turns blue. So any issues should only happen if that button turns blue without Street View active.

If you can tell me how you're able to trigger this issue, I'd love to investigate it further.
 
Glodenox
Waze Global Champs
Waze Global Champs
Posts: 1568
Answers: 1
Has thanked: 278 times
Been thanked: 946 times
Send a message
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
https://www.tomputtemans.com/images/WazeBelgium.pnghttps://www.tomputtemans.com/images/WazeWMEbeta.png

Post by Glodenox
I've tried just about all combinations of enabling and disabling Street View, making changes to the map and saving and haven't been able to find an issue, neither in Firefox or in Chrome. I only noticed that the checkbox in the map layer doesn't always seem to properly reflect the Street View layer's state, but that doesn't seem like what you are reporting.

Can you explain in more detail which exact steps you take, what behaviour you see and what you expected?
 
Glodenox
Waze Global Champs
Waze Global Champs
Posts: 1568
Answers: 1
Has thanked: 278 times
Been thanked: 946 times
Send a message
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
https://www.tomputtemans.com/images/WazeBelgium.pnghttps://www.tomputtemans.com/images/WazeWMEbeta.png

Post by Glodenox
No update yet. I've only had like 2 free evenings the past three weeks, which I wasn't going to spend on doing more software development :lol:
Things have finally slowed down now and I'm working my way through the backlog of tasks, including this issue.
Glodenox
Waze Global Champs
Waze Global Champs
Posts: 1568
Answers: 1
Has thanked: 278 times
Been thanked: 946 times
Send a message
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
https://www.tomputtemans.com/images/WazeBelgium.pnghttps://www.tomputtemans.com/images/WazeWMEbeta.png

Post by Glodenox
A small update: I've since been able to investigate the issue, but haven't written a solution for it yet. The issue seem so be that the Street View marker and button are no longer set as active after a save, even though the Street View panel remains open at that point. I'm going to have to adjust the code to look at both the status of that button and the state of the Street View panel. While it looks more complicated, I think this will actually allow me to simplify a bit of the logic.
Glodenox
Waze Global Champs
Waze Global Champs
Posts: 1568
Answers: 1
Has thanked: 278 times
Been thanked: 946 times
Send a message
Belgium & Luxembourg Coordinator • Script Writing Community Coordinator
https://www.tomputtemans.com/images/WazeBelgium.pnghttps://www.tomputtemans.com/images/WazeWMEbeta.png

Post by iainhouse
Glodenox wrote:The script now restores the last used width of the Street View panorama
Hey there. I'm having a little problem with this latest feature - or at least how it interacts with a new feature in WME FixUI. It seems we've both been working on the same problem from different angles! :lol:

The problem is really down to bad design by the WME Devs. As initially loaded, the relative widths of the map and GSV panels are controlled by CSS classes setting the widths to 50%/50%. But, as soon as you drag the handle, WME adds inline CSS to the elements themselves setting width/drag handle positions in fixed pixel values.

My script will alter the default % values in the CSS classes to change the default split position. If you drag the handle, that position gets overridden by the dragged-to position set in the inline CSS.

It looks like you are restoring the previous position by storing the inline CSS values and restoring them on reload - but you are doing this even if the handle hasn't been dragged and is therefore still at the default position and controlled by the CSS classes.

That's where it's interfering with WME FixUI. I think your script is looking for the inline CSS, not seeing any, then assuming the position is at 50% and setting/storing the corresponding inline CSS settings - even though FixUI has altered that default.

Perhaps you could change your code to not store/set a permission if no inline CSS setting is found? Or maybe look at the % position set in on these 3 CSS classes:
  • #editor-container #map.street-view-mode #waze-map-container {width}
  • #editor-container #map.street-view-mode #street-view-drag-handle {left}
  • #editor-container #map.street-view-mode #street-view-container {width}
iainhouse
EmeritusChamps
EmeritusChamps
Posts: 11143
Answers: 1
Has thanked: 2173 times
Been thanked: 8188 times
Send a message
https://storage.googleapis.com/wazeoped ... c4/AGC.pnghttps://sign.waze.tools/s2000.pnghttps://sign.waze.tools/c6.png
My scripts: WME FixUI WME Presets :ugeek:
I want to go to a commune in Vermont and deal with no unit of time shorter than a season

Post by iainhouse
Glodenox wrote:The only thing I can imagine would be that changing the width of the Street View panel too early would somehow break the initialisation of Street View. I'll try to remove that feature from the userscript tonight as I don't see it as an added value any more.
Anyway, you can use FixUI to do it ;)
iainhouse
EmeritusChamps
EmeritusChamps
Posts: 11143
Answers: 1
Has thanked: 2173 times
Been thanked: 8188 times
Send a message
https://storage.googleapis.com/wazeoped ... c4/AGC.pnghttps://sign.waze.tools/s2000.pnghttps://sign.waze.tools/c6.png
My scripts: WME FixUI WME Presets :ugeek:
I want to go to a commune in Vermont and deal with no unit of time shorter than a season