Source code repository on github

These forums are specific to the Waze mobile app. Post here if you experienced a problem while using the app, have a question about the app functionality or a feature such as navigation or search.

Moderators: krankyd, Unholy

Re: Source code repository on github

Postby Shr3k » Thu Nov 15, 2012 9:29 am

This quick comparsion makes me ROFL and very doubtful about GNU GPL violation of RoadMap:
strings papaya_2.4.0.26.libwaze.so | sort > papaya.txt http://pastebin.com/0FvEJxUB
strings cocus_3.5.0.105.libwaze.so | sort > cocus.txt http://pastebin.com/nfTTuSEa

Funniest parts are:
Code: Select all
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_androidmenu.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_androidspeechtt.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_camera.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_canvas_ogl.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_device.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_dialog.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_libpng.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_main.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_path.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_sound.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_thread.c

VS
Code: Select all
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/androidmenu.c
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/androidspeechtt.c
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/camera.c
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/canvas_ogl.c
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/device.c
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/main.c
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/sound.c
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/thread.c

etc.

Some parts of code are moved to subdirectories. It looks like new 3.* version was rather big update than complete rewrite from scratch. Anything beginning with roadmap was renamed to same to almost same directory structure and functions are renamed in same manner:

Code: Select all
roadmap_canvas_copy_image
roadmap_canvas_create_pen
roadmap_canvas_draw_formated_string_angle
roadmap_canvas_draw_formated_string_size
roadmap_canvas_draw_image
roadmap_canvas_draw_image_angle
roadmap_canvas_draw_image_formated_text
roadmap_canvas_draw_image_middle_stretch
roadmap_canvas_draw_image_scaled
roadmap_canvas_draw_image_scaled_angle
roadmap_canvas_draw_image_stretch
roadmap_canvas_draw_image_text
roadmap_canvas_draw_multiple_circles
roadmap_canvas_draw_multiple_lines
roadmap_canvas_draw_multiple_lines_int
roadmap_canvas_draw_multiple_lines_slow
roadmap_canvas_draw_multiple_lines_smooth
roadmap_canvas_draw_multiple_points
roadmap_canvas_draw_multiple_polygons
roadmap_canvas_draw_multiple_tex_lines
roadmap_canvas_draw_string
roadmap_canvas_draw_string_angle
roadmap_canvas_draw_string_size

VS
Code: Select all
canvas_copy_image
canvas_create_pen
canvas_draw_formated_string_angle
canvas_draw_formated_string_angle
canvas_draw_formated_string_size
canvas_draw_image
canvas_draw_image_angle
canvas_draw_image_formated_text
canvas_draw_image_middle_stretch
canvas_draw_image_scaled
canvas_draw_image_scaled_angle
canvas_draw_image_stretch
canvas_draw_image_text
canvas_draw_image_to_fbo
canvas_draw_multiple_circles
canvas_draw_multiple_lines
canvas_draw_multiple_lines
canvas_draw_multiple_points
canvas_draw_multiple_polygons
canvas_draw_multiple_tex_lines
canvas_draw_multiple_tex_lines
canvas_draw_string
canvas_draw_string_angle
canvas_draw_string_size


Maybe it would be better to come clean, than have problems with GNU GPL or FSF.
Samsung Galaxy S, Qstarz BT-Q1000X
Shr3k
 
Posts: 16
Joined: Fri Oct 15, 2010 4:12 pm
Location: Prague, Czech Republic
Has thanked: 0 time
Been thanked: 0 time

Re: Re: Source code repository on github

Postby Shr3k » Fri Nov 16, 2012 11:35 am

bgodette wrote:What problems? Again there's no prohibition against relicensing *your own code*. You can also purchase/transfer copyright and relicense.

Waze client is based on Israeli fork of RoadMap routing application (http://sourceforge.net/projects/roadmap/) originally developed by Pascal Martin as GNU GPL (derived works can only be distributed under the same license terms). See http://en.wikipedia.org/wiki/GNU_Genera ... e#Copyleft
Samsung Galaxy S, Qstarz BT-Q1000X
Shr3k
 
Posts: 16
Joined: Fri Oct 15, 2010 4:12 pm
Location: Prague, Czech Republic
Has thanked: 0 time
Been thanked: 0 time

Re: Re: Source code repository on github

Postby Shr3k » Sat Nov 17, 2012 2:29 am

bgodette wrote:
OldGnome wrote:
bgodette wrote:You really are being dense...

Are the public insults really necessary?
Are the public insinuations that there's code theft after it's been explained many times really necessary?

This is straw man. I didn't know that someone wrote about a code theft. :?

I took the trouble, unlike you, to find similar or identical function calls, similar directory structure used in time of compiling in dynamically linked shared object library of Waze GPL and closed-source clients and expressed a doubt. That's all. If you have better information based on your own research, just share them.
Samsung Galaxy S, Qstarz BT-Q1000X
Shr3k
 
Posts: 16
Joined: Fri Oct 15, 2010 4:12 pm
Location: Prague, Czech Republic
Has thanked: 0 time
Been thanked: 0 time

Re: Re: Re: Source code repository on github

Postby Shr3k » Sat Nov 17, 2012 11:22 am

bgodette wrote:e.g. insinuating code theft. You continue to ignore the fact that relicensing is allowed to willfully perpetuate this insinuation.

This is argumentum ad hominem. Again I remind you if you have better information just present it. It's more constructive than continue writing something I never wrote and even never meant.

Regards relicensing, it seems you you totally forgot the "infectiousness" of GPL. If you want a use a GPL code in closed source project, you must ask and relicense every piece of code, every patch, from every developer who worked on it before. As every version, branch or a fork is GPL again and again until someone comes and rewrites it from beginning. And if the source code isn't stable hosted on a CVS system for long time, it is quite difficult to detect appropriate parts of the submitted patches from different developers as these changes are quite atomic. Actually it is often better to start with a complete rewrite from scratch if you have learnt and have knowhow.
Samsung Galaxy S, Qstarz BT-Q1000X
Shr3k
 
Posts: 16
Joined: Fri Oct 15, 2010 4:12 pm
Location: Prague, Czech Republic
Has thanked: 0 time
Been thanked: 0 time

Re: Source code repository on github

Postby Shr3k » Sun Nov 18, 2012 11:33 am

Please don't shout and be constructive. It looks like you have some kind of unofficial information that the Waze team relicensed code from all previous developers of RoadMap.
Samsung Galaxy S, Qstarz BT-Q1000X
Shr3k
 
Posts: 16
Joined: Fri Oct 15, 2010 4:12 pm
Location: Prague, Czech Republic
Has thanked: 0 time
Been thanked: 0 time

Re: Source code repository on github

Postby stacktrase » Mon Aug 27, 2012 12:52 am

No. Anything extracted from the APK file is impossible to work with. Function, class, and variable names are lost and converted to identifiers with no meaning.
stacktrase
 
Posts: 3
Joined: Tue Jul 31, 2012 4:33 am
Has thanked: 0 time
Been thanked: 0 time

Re: Source code repository on github

Postby stacktrase » Mon Aug 27, 2012 4:22 pm

On twitter they just replied to me:

@stackTrase Since version 3.0 we haven't had an open source code :(


Don't know how that fits in with the OpenSource technology they use in their software.
stacktrase
 
Posts: 3
Joined: Tue Jul 31, 2012 4:33 am
Has thanked: 0 time
Been thanked: 0 time

Re: Source code repository on github

Postby stacktrase » Tue Nov 13, 2012 3:16 pm

Yes but if you use GPL code you can't modify it and have it closed source.
stacktrase
 
Posts: 3
Joined: Tue Jul 31, 2012 4:33 am
Has thanked: 0 time
Been thanked: 0 time

Re: Source code repository on github

Postby Suik » Mon Apr 30, 2012 8:54 am

cymike wrote:
xteejx wrote:What was the point of doing that?

Just wanted to see how different versions relate/differ etc. Git repository makes it convenient. Also it might be convenient for people who want to make their own improvements/modifications.
3.0 source isn't even available yet.

3.0 changes seem to be mostly gui-related anyway.


not only gui changed, you cannot tweak "preferences" file anymore, afaik.
BA-SVK & surroundings AreaManager, Soc. Med. XP
Renault Fluence 2011, 1.6 16V Exception+HTC One S, stock Android 4.0.4, waze 3.6.0.0
FB pg: Waze Slovensko / Twitter: @waze_slovensko / G+: Waze Slovensko
Suik
 
Posts: 882
Joined: Thu Jun 02, 2011 11:17 pm
Location: Slovakia
Has thanked: 1 time
Been thanked: 6 times

Re: Source code repository on github

Postby Suik » Mon Apr 30, 2012 10:43 pm

xteejx wrote:You certainly can, on Android at least.

Sent from my Telenor_OneTouch using Tapatalk


if so...how? since 3.x. I can't manage to make the line

Code: Select all
GPS.Show GPS: no


"functional" if changed to yes.
Same applies to changing the ID numbers of Hazards shown in the client :).
BA-SVK & surroundings AreaManager, Soc. Med. XP
Renault Fluence 2011, 1.6 16V Exception+HTC One S, stock Android 4.0.4, waze 3.6.0.0
FB pg: Waze Slovensko / Twitter: @waze_slovensko / G+: Waze Slovensko
Suik
 
Posts: 882
Joined: Thu Jun 02, 2011 11:17 pm
Location: Slovakia
Has thanked: 1 time
Been thanked: 6 times

PreviousNext

Return to Waze App

Who is online

Users browsing this forum: No registered users