Source code repository on github

These forums are specific to the Waze mobile app. Post here if you experienced a problem while using the app, have a question about the app functionality or a feature such as navigation or search.

Moderators: Unholy, bextein

Re: Source code repository on github

Postby shr3k » Tue Nov 13, 2012 1:22 pm

Interesting, this developer https://twitter.com/damagedspline of http://code.google.com/p/waze-qt says that 3.5 libwaze.so contains same strings as GPL'ed version 2.4.
Sony XPeria Z1 Compact in Mazda6 Wagon 2.2 CD Revolution
shr3k
 
Posts: 20
Joined: Fri Oct 15, 2010 4:12 pm
Location: Prague, Czech Republic
Has thanked: 0 time
Been thanked: 1 time

Re: Source code repository on github

Postby robin1979 » Tue Nov 13, 2012 2:24 pm

As you as you own the copyright to the code, you can change licenses as much as you want. So there's really no problem here.
MapSquadEurope
Area Manager - Europe
robin1979
 
Posts: 3034
Joined: Thu Sep 10, 2009 6:49 am
Location: EUROPE
Has thanked: 7 times
Been thanked: 38 times

Re: Source code repository on github

Postby stacktrase » Tue Nov 13, 2012 3:16 pm

Yes but if you use GPL code you can't modify it and have it closed source.
stacktrase
 
Posts: 3
Joined: Tue Jul 31, 2012 4:33 am
Has thanked: 0 time
Been thanked: 0 time

Re: Re: Source code repository on github

Postby bgodette » Tue Nov 13, 2012 3:35 pm

stacktrase wrote:Yes but if you use GPL code you can't modify it and have it closed source.

Only applies to using *other people's* code. If it's your own code you can use whatever license(s) you wish.

It's all my phone's fault for using Tapatalk.
ImageImage
bgodette
Waze Global Champs
Waze Global Champs
 
Posts: 3378
Joined: Wed Jul 06, 2011 8:19 pm
Location: Denver, CO
Has thanked: 101 times
Been thanked: 480 times

Re: Source code repository on github

Postby floppyrod84 » Wed Nov 14, 2012 1:56 am

Indeed. If it's their licence they can do whatever the hell they like with it. I know I've seen some projects change the game at times, but all previous source before any licence change should be available.

Sent from my GT-I9100 using Tapatalk 2
floppyrod84
 
Posts: 2582
Joined: Wed Jan 19, 2011 3:17 pm
Location: Sheerness, Kent, UK
Has thanked: 46 times
Been thanked: 45 times

Re: Source code repository on github

Postby shr3k » Thu Nov 15, 2012 9:29 am

This quick comparsion makes me ROFL and very doubtful about GNU GPL violation of RoadMap:
strings papaya_2.4.0.26.libwaze.so | sort > papaya.txt http://pastebin.com/0FvEJxUB
strings cocus_3.5.0.105.libwaze.so | sort > cocus.txt http://pastebin.com/nfTTuSEa

Funniest parts are:
Code: Select all
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_androidmenu.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_androidspeechtt.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_camera.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_canvas_ogl.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_device.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_dialog.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_libpng.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_main.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_path.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_sound.c
/workspace/branches/papaya_2.4.0.1/src/android/java/jni/../../..//android/roadmap_thread.c

VS
Code: Select all
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/androidmenu.c
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/androidspeechtt.c
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/camera.c
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/canvas_ogl.c
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/device.c
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/main.c
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/sound.c
/Users/aga/workspace/cocus/src/android/java/jni/../../..//android/thread.c

etc.

Some parts of code are moved to subdirectories. It looks like new 3.* version was rather big update than complete rewrite from scratch. Anything beginning with roadmap was renamed to same to almost same directory structure and functions are renamed in same manner:

Code: Select all
roadmap_canvas_copy_image
roadmap_canvas_create_pen
roadmap_canvas_draw_formated_string_angle
roadmap_canvas_draw_formated_string_size
roadmap_canvas_draw_image
roadmap_canvas_draw_image_angle
roadmap_canvas_draw_image_formated_text
roadmap_canvas_draw_image_middle_stretch
roadmap_canvas_draw_image_scaled
roadmap_canvas_draw_image_scaled_angle
roadmap_canvas_draw_image_stretch
roadmap_canvas_draw_image_text
roadmap_canvas_draw_multiple_circles
roadmap_canvas_draw_multiple_lines
roadmap_canvas_draw_multiple_lines_int
roadmap_canvas_draw_multiple_lines_slow
roadmap_canvas_draw_multiple_lines_smooth
roadmap_canvas_draw_multiple_points
roadmap_canvas_draw_multiple_polygons
roadmap_canvas_draw_multiple_tex_lines
roadmap_canvas_draw_string
roadmap_canvas_draw_string_angle
roadmap_canvas_draw_string_size

VS
Code: Select all
canvas_copy_image
canvas_create_pen
canvas_draw_formated_string_angle
canvas_draw_formated_string_angle
canvas_draw_formated_string_size
canvas_draw_image
canvas_draw_image_angle
canvas_draw_image_formated_text
canvas_draw_image_middle_stretch
canvas_draw_image_scaled
canvas_draw_image_scaled_angle
canvas_draw_image_stretch
canvas_draw_image_text
canvas_draw_image_to_fbo
canvas_draw_multiple_circles
canvas_draw_multiple_lines
canvas_draw_multiple_lines
canvas_draw_multiple_points
canvas_draw_multiple_polygons
canvas_draw_multiple_tex_lines
canvas_draw_multiple_tex_lines
canvas_draw_string
canvas_draw_string_angle
canvas_draw_string_size


Maybe it would be better to come clean, than have problems with GNU GPL or FSF.
Sony XPeria Z1 Compact in Mazda6 Wagon 2.2 CD Revolution
shr3k
 
Posts: 20
Joined: Fri Oct 15, 2010 4:12 pm
Location: Prague, Czech Republic
Has thanked: 0 time
Been thanked: 1 time

Re: Re: Source code repository on github

Postby bgodette » Thu Nov 15, 2012 2:13 pm

Shr3k wrote:Maybe it would be better to come clean, than have problems with GNU GPL or FSF.
What problems? Again there's no prohibition against relicensing *your own code*. You can also purchase/transfer copyright and relicense.

It's all my phone's fault for using Tapatalk.
ImageImage
bgodette
Waze Global Champs
Waze Global Champs
 
Posts: 3378
Joined: Wed Jul 06, 2011 8:19 pm
Location: Denver, CO
Has thanked: 101 times
Been thanked: 480 times

Re: Re: Source code repository on github

Postby shr3k » Fri Nov 16, 2012 11:35 am

bgodette wrote:What problems? Again there's no prohibition against relicensing *your own code*. You can also purchase/transfer copyright and relicense.

Waze client is based on Israeli fork of RoadMap routing application (http://sourceforge.net/projects/roadmap/) originally developed by Pascal Martin as GNU GPL (derived works can only be distributed under the same license terms). See http://en.wikipedia.org/wiki/GNU_Genera ... e#Copyleft
Sony XPeria Z1 Compact in Mazda6 Wagon 2.2 CD Revolution
shr3k
 
Posts: 20
Joined: Fri Oct 15, 2010 4:12 pm
Location: Prague, Czech Republic
Has thanked: 0 time
Been thanked: 1 time

Re: Source code repository on github

Postby floppyrod84 » Fri Nov 16, 2012 1:43 pm

Oh dear...

Sent from my GT-I9100 using Tapatalk 2
floppyrod84
 
Posts: 2582
Joined: Wed Jan 19, 2011 3:17 pm
Location: Sheerness, Kent, UK
Has thanked: 46 times
Been thanked: 45 times

Re: Re: Source code repository on github

Postby bgodette » Fri Nov 16, 2012 5:00 pm

Shr3k wrote:
bgodette wrote:What problems? Again there's no prohibition against relicensing *your own code*. You can also purchase/transfer copyright and relicense.

Waze client is based on Israeli fork of RoadMap routing application (http://sourceforge.net/projects/roadmap/) originally developed by Pascal Martin as GNU GPL (derived works can only be distributed under the same license terms). See http://en.wikipedia.org/wiki/GNU_Genera ... e#Copyleft
You really are being dense, but ok:
(c) Copyright Pascal Martin, 2003, 2005
(c) Copyright Latchesar Ionkov, 2003
(c) Copyright Stephen Woodbridge, 2004
(c) Copyright Ehud Shabtai, 2005
(c) Copyright Paul Fox, 2006, 2007, 2008
(c) Copyright Danny Backx, 2007, 2008
Look who's in there.
Oh that's right. You can *fork your own code*. The GPL also does NOT prevent, preclude, prohibit, exclude, deny or otherwise disallow you from purchasing copyright from the original authors and closing the source.

It does however prevent you from pulling access to the code as it existed at the time the license was changed. Since we don't know when Ehud/Waze decided to relicense *his own code*, we have no idea if that part is in compliance or not for 2.4.x clients, but we do know it does not apply to 3.x clients.
ImageImage
bgodette
Waze Global Champs
Waze Global Champs
 
Posts: 3378
Joined: Wed Jul 06, 2011 8:19 pm
Location: Denver, CO
Has thanked: 101 times
Been thanked: 480 times

PreviousNext

Return to Waze App

Who is online

Users browsing this forum: No registered users