dbraughlr wrote:

iainhouse wrote:... the scripts can only perform actions that can already be performed by editors.

I believe that some scripts to perform functions which are not possible with the WME user interface but are possible with the Waze object model. The functions for manipulating roundabouts are such functions. This amazing ability to modify a property which should be read-only could be a pair of ordinary bugs.

I've now looked at the code that deals with these loops. It deletes the existing loop and replaces it with new segments. It does not change the creator for the existing loop.

I can't categorically state that this isn't possible to change the creator on an existing segment. But I am confident that this script isn't doing so.

In the UK we have a lot of roundabouts. Whilst many of these are highlighted as not having consecutive segments IDs, most of them function perfectly normally. In the vast majority of cases, rebuilding them would not make any difference to routing and would be more an exercise in points-farming - given how many roundabouts we have.

For this reason, we specifically asked for this issue not to be highlighted by Validator in the UK. WME Toolbox will also highlight them, but I invariably have that highlight off because of the high rate of false-positives. If I ever encounter a roundabout that is generating UR problems, I may turn on the Toolbox highlight just to see what it says.

As a side note, I believe (without empirical evidence) that I am seeing far fewer of the 2 main roundabout problems than I used to see: roundabout suicide (where the segments lose their "roundabout" property) and 0'th exit problems. Maybe Waze have made some changes that actually improve roundabout routing - as opposed to borking it entirely!

[EDIT] All the below predates the latest update, but it doesn't sound like the update addresses these problems. Sorry - I've been trying to put this data together for hours!

Chrome version 34.0.1847.137 m
Window XP SP4 (yes, I know! I'm living on the edge! )
Installed scripts: Everything!

I suspect there's some sort of timing issue here. There seems to be an interaction with JNF and Validator, at least. I have hacked my version of JNF to correct an error preventing it enabling fullscreen, then (because the Toolbox issues were fooling me) to always set fullscreen.

I am seeing 2 behaviours. Either WME loads with Validator available and JNF able to set fullscreen mode, or WME loads with no Validator interface and JNF not setting fullscreen.

The choice of behaviour is random. If I repeatedly hit refresh, I'll see one or the other. However, it tends to go in "runs" - so it will fail a few times in a row before things start working again.

I can see a fairly consistent pattern of errors in the console for either situation:

Everything working wrote:WME Toolbox: jquery-ui loaded. WME_Toolbox.min.js:1
WME Toolbox: JNF in installed. Cool! WME_Toolbox.min.js:1
WME Toolbox: Initializing main features WME_Toolbox.min.js:1
WME Toolbox: loading saved options WME_Toolbox.min.js:1

Uncaught ReferenceError: WazeEditorURL is not defined WME_Toolbox.min.js:1
(anonymous function) WME_Toolbox.min.js:1
lt.extend.each libs-8065af8a.js:1
Class.extend.ComputeHouseNumbers WME_Toolbox.min.js:1
Class.extend.HighlightSegments WME_Toolbox.min.js:1
OpenLayers.Events.OpenLayers.Class.triggerEvent OL-da1c4390.js:91
OpenLayers.Layer.OpenLayers.Class.setVisibility OL-da1c4390.js:115
Class.extend.init WME_Toolbox.min.js:1
Class wmelib.js:146
WMETB_Highlight_Init WME_Toolbox.min.js:1
WMETB_MainInitialise WME_Toolbox.min.js:1
WMETB_load_JNF WME_Toolbox.min.js:1
WMETB_wait_JqueryUI WME_Toolbox.min.js:1

WME Validator v0.9.9: login iainhouse ?zoom=4&lat=53.80094&lon=-1.70692&env=row&layers=1477:1
WMEOpenData: editing in the UK wme_oslinks.2.3.user.js:354

Uncaught ReferenceError: WazeEditorURL is not defined WME_Toolbox.min.js:1
(anonymous function) WME_Toolbox.min.js:1
lt.extend.each libs-8065af8a.js:1
Class.extend.ComputeHouseNumbers WME_Toolbox.min.js:1
Class.extend.HighlightSegments WME_Toolbox.min.js:1

[quote="JNF & Validator problems]WME Toolbox: waiting for jquery-ui... WME_Toolbox.min.js:1
WME Toolbox: jquery-ui loaded. WME_Toolbox.min.js:1
WME Toolbox: JNF in installed. Cool! WME_Toolbox.min.js:1
WME Toolbox: Initializing main features WME_Toolbox.min.js:1
WME Toolbox: loading saved options WME_Toolbox.min.js:1

Uncaught ReferenceError: WazeEditorURL is not defined WME_Toolbox.min.js:1
(anonymous function) WME_Toolbox.min.js:1
lt.extend.each libs-8065af8a.js:1
Class.extend.ComputeHouseNumbers WME_Toolbox.min.js:1
Class.extend.HighlightSegments WME_Toolbox.min.js:1
OpenLayers.Events.OpenLayers.Class.triggerEvent OL-da1c4390.js:91
OpenLayers.Layer.OpenLayers.Class.setVisibility OL-da1c4390.js:115
Class.extend.init WME_Toolbox.min.js:1
Class wmelib.js:146
WMETB_Highlight_Init WME_Toolbox.min.js:1
WMETB_MainInitialise WME_Toolbox.min.js:1
WMETB_load_JNF WME_Toolbox.min.js:1
WMETB_wait_JqueryUI WME_Toolbox.min.js:1

Uncaught ReferenceError: WazeEditorURL is not defined WME_Toolbox.min.js:1
(anonymous function) WME_Toolbox.min.js:1
lt.extend.each libs-8065af8a.js:1
Class.extend.ComputeHouseNumbers WME_Toolbox.min.js:1
Class.extend.HighlightSegments WME_Toolbox.min.js:1
OpenLayers.Events.OpenLayers.Class.triggerEvent OL-da1c4390.js:91
(anonymous function) WME-b62c2f74.js:18
c libs-8065af8a.js:1
d.fireWith libs-8065af8a.js:1
n libs-8065af8a.js:3
n libs-8065af8a.js:3

Uncaught ReferenceError: WazeEditorURL is not defined WME_Toolbox.min.js:1
(anonymous function) WME_Toolbox.min.js:1
lt.extend.each libs-8065af8a.js:1
Class.extend.ComputeHouseNumbers WME_Toolbox.min.js:1
Class.extend.HighlightSegments WME_Toolbox.min.js:1
OpenLayers.Events.OpenLayers.Class.triggerEvent OL-da1c4390.js:91
OpenLayers.Map.OpenLayers.Class.setLayerIndex OL-da1c4390.js:107
OpenLayers.Map.OpenLayers.Class.raiseLayer OL-da1c4390.js:107
(anonymous function) VM4677:1
pb WV.0.9.9.user.js:132
f WV.0.9.9.user.js:132

Uncaught ReferenceError: WazeEditorURL is not defined WME_Toolbox.min.js:1
(anonymous function) WME_Toolbox.min.js:1
lt.extend.each libs-8065af8a.js:1
Class.extend.ComputeHouseNumbers WME_Toolbox.min.js:1
Class.extend.HighlightSegments WME_Toolbox.min.js:1

WME Validator v0.9.9: login iainhouse ?zoom=4&lat=53.80094&lon=-1.70692&env=row&layers=1477:1

WMEOpenData: editing in the UK wme_oslinks.2.3.user.js:354
[/quote]

And yes, the second one seems to say Validator has loaded OK - but the interface is missing.

Feature request: Would be nice to have here.com added to the external permalinks. Thanks!

Thanks for adding the "here" permalink.
The zoom level needs an adjustment. Using the same value as Bing permalink should work fine.

Just wanted to poke in here and say thanks, I love the Toolbox!

It'd have to be pretty bad to be UAC

Not yet but I'll keep an eye on it.

The Junction Node fixer does this I think!

O

doctorkb wrote:Irowiki: it's a high-level editor feature that clears all visible with one keystroke... JNF doesn't do that.

I dunno, I can fix all issues with dead ends or a junction with one button press with jnf plus toolbox.

Toolbox highlights it and says press q to fix (requires jnf)