[Script] WME Validator 1.1.19 / 04.06.2016

Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Moderators: Unholy, bextein

Forum rules
Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

DO NOT START a new thread unless it is about a new idea. Keep discussion of existing tools within the main thread for that tool.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Re: [Script] WME Validator 0.4.2 (BETA) / 07.07.2014

Postby pumrum » Wed Jan 08, 2014 2:50 am

VERY good stuff here. Thanks! A suggestion:

Since dead-ends are supposed to have U-Turns hard disabled, it would be helpful to show the dead-end U-Turn alert for all end nodes that do NOT have the U-Turn hard disabled. Currently it only shows for hard enabled and soft enabled, it does not show for soft disabled.

Wiki: https://www.waze.com/wiki/Map_Editing_Q ... nd-streets

Example: https://www.waze.com/editor/?zoom=5&lat ... TT&env=usa
pumrum
 
Posts: 669
Joined: Mon Dec 09, 2013 3:02 am
Has thanked: 92 times
Been thanked: 294 times

Re: [Script] WME Validator 0.4.2 (BETA) / 07.07.2014

Postby AlanOfTheBerg » Wed Jan 08, 2014 4:25 am

I'm seeing the validator highlight/flash a LOT of segments, but when I click on them, nothing is shown.

Also, seems there's a bug with false-positive for unknown segment direction:
Image
Wiki Resources: Map Editing Manual | alanoftheberg@gmail.com
Oregon-based US Country Manager | iPhone6 - VZ - iOS 9.3.2 | Waze v4.7.0.1
AlanOfTheBerg
Waze Global Champs
Waze Global Champs
 
Posts: 23478
Joined: Sat Aug 28, 2010 8:48 pm
Location: US Country Manager - Oregon, USA
Has thanked: 1084 times
Been thanked: 4594 times

Re: [Script] WME Validator 0.4.2 (BETA) / 07.07.2014

Postby berestovskyy » Wed Jan 08, 2014 10:01 am

davidg666 wrote:I assume this takes account of countries where people drive on the left (and roundabouts are clockwise). Can you add Ireland to the list of countries like this?

There is a property in WME for left hand traffic and Validator takes it into account. For instance here is a "normal" (B->A) left-hand roundabout in Ireland: permalink and here is reversed left-hand (A->B) roundabout: permalink

Let me know if you want to completely disable this check for Ireland or change the check title/description.

AlanOfTheBerg wrote:Text bubble reads "Click 'Report' to review map issues" but there is no button named "Report" that I can see. There is a "Show report" button though.

Fixed.

AlanOfTheBerg wrote:Example where reverse connection does not appear to be detected:

Fixed.

AlanOfTheBerg wrote:Suggestions: If you can have only one active "report" then I would suggest a single icon to run the report and then clear the report.

While you are panning the map the issues are highlighted and reported. So you can click clear button any time to start the report over. If there are too many segments reported/cached, the clear report button becomes red.

The trash icon has changed.

AlanOfTheBerg wrote:
txemt wrote:When I select an interstate segment, it pops up a warning about city name being in the city field. It wants me to remove the city name from the interstate. I didn't think that was set in stone.

I agree. WMEV should not give this guidance.

Ok, the check is disabled for US.

lelehman wrote:it appears to stop when I go to a different tab and then start over when I switch back.

Drag the tab out to create a new window. Then do not minimize it, but just switch back to original window. At least this trick works for me.

pumrum wrote:Since dead-ends are supposed to have U-Turns hard disabled, it would be helpful to show the dead-end U-Turn alert for all end nodes that do NOT have the U-Turn hard disabled. Currently it only shows for hard enabled and soft enabled, it does not show for soft disabled

There was a bug with soft turns detection. This segment will be reported/highlighted now as having soft turns.

AlanOfTheBerg wrote:I'm seeing the validator highlight/flash a LOT of segments, but when I click on them, nothing is shown.

There is a "Might be incomplete city name" check, which reports segments with too short or partially duplicating city names.

This check has limits for different cases. If number of suspicious segments exceeds the limit, the Validator "unreport" all of those segments.

For instance, if we have segments with "City" and "City Plus", Validator "unreport" them if there are more than 10 segments with such a name.

Give me a permalink I'll have a look if that is the case.

AlanOfTheBerg wrote:Also, seems there's a bug with false-positive for unknown segment direction:
Image

Validator reports here that the segment is highlighted by the WME Color Highlight (WCH). Maybe you are using another script, which colors the segment in #00ffff (that's the color for "Unknown directions" in WCH.) You can disable those reports in Settings->WCH: Report highlighted segments

Thanks for the feedback!
berestovskyy
 
Posts: 925
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 254 times
Been thanked: 693 times

Re: [Script] WME Validator 0.4.2 (BETA) / 07.07.2014

Postby davidg666 » Wed Jan 08, 2014 11:49 am

berestovskyy wrote:
davidg666 wrote:I assume this takes account of countries where people drive on the left (and roundabouts are clockwise). Can you add Ireland to the list of countries like this?

There is a property in WME for left hand traffic and Validator takes it into account. For instance here is a "normal" (B->A) left-hand roundabout in Ireland: permalink and here is reversed left-hand (A->B) roundabout: permalink

Let me know if you want to completely disable this check for Ireland or change the check title/description.

Thanks for your response - however:

1. both of those roundabouts you mention above are correct (clockwise), even though one runs A->B and the other runs B->A. Possibly some of them are older and created with Cartouche, which may have created the segments a different way around (or maybe WME did once)
2. A great many roundabouts here (just pan around Dublin (we have plenty of roundabouts :) ) are reported as being incorrect, even when they're not.

It looks like 'newer' roundabouts (created around 2013) seem to run B->A and aren't flagged as wrong, but a lot of 'older' roundabouts (created around 2011) run A->B - both of these are correct on the map, but the A-B roundabouts are flagged as incorrect.

I suspect this is the case for other countries where people drive on the left, and possibly for all countries, including those where people drive on the right. (I haven't had time yet to look at other countries' roundabouts)

Can I suggest that you look around for older (2011 or so) roundabouts and compare with newer (2013 or later) roundabouts? (if this seems to affect drive-on-the-left countries only, maybe look at Australia, New Zealand or Japan and not the UK, since the UK has had a basemap import and may have more consistent roundabouts) I suspect that WME (or Cartouche) didn't always create roundabouts with the segments running A->B or B->A. For this reason, I don't think your roundabout correctness checking is correct, if it's just based on the order of segment end points.

Perhaps you could disable this check until it works consistently (and can handle both A->B and B->A roundabouts)?

++David \ davidg666
Country manager and local champ for Ireland
AM for Dublin, Wicklow, Kilkenny, Wexford, Graiguenamanagh and Enniscorthy

Image
davidg666
Waze Local Champs
Waze Local Champs
 
Posts: 503
Joined: Thu Jan 12, 2012 6:58 pm
Location: Dublin, Ireland
Has thanked: 32 times
Been thanked: 96 times

Re: [Script] WME Validator 0.4.2 (BETA) / 07.07.2014

Postby khaytsus » Wed Jan 08, 2014 1:23 pm

I've tried disabling all other scripts, yet this one still doesn't seem to "validate" anything. It shows up, I click the Play button, it pans around, finishes scanning, then nothing. No report (button stays greyed out).

Chrome 31, in tapermonkey. I'll try from the Chrome store later. Can't use Firefox right now, it's completely broken since it updated to 27 for me.
USA Country Manager
Central Kentucky Area Manager
AT&T LG G2 (AOKP 4.4.4)
Nexus 7 2012 (AOKP 4.4.4)
Samsung Galaxy Note (i717 AT&T; AOKP 4.4.4)
Image
khaytsus
 
Posts: 863
Joined: Tue Nov 03, 2009 10:43 pm
Location: Lexington, KY
Has thanked: 43 times
Been thanked: 84 times

Re: [Script] WME Validator 0.4.2 (BETA) / 07.07.2014

Postby AlanOfTheBerg » Wed Jan 08, 2014 4:06 pm

Script has the wrong forum URL for "Website." In the Extensions window, the "Visit website" link is https://www.waze.com/forum/viewtopic.php?t=61518, which is for a different extension. :)
Wiki Resources: Map Editing Manual | alanoftheberg@gmail.com
Oregon-based US Country Manager | iPhone6 - VZ - iOS 9.3.2 | Waze v4.7.0.1
AlanOfTheBerg
Waze Global Champs
Waze Global Champs
 
Posts: 23478
Joined: Sat Aug 28, 2010 8:48 pm
Location: US Country Manager - Oregon, USA
Has thanked: 1084 times
Been thanked: 4594 times

Re: [Script] WME Validator 0.4.2 (BETA) / 07.07.2014

Postby AlanOfTheBerg » Wed Jan 08, 2014 4:34 pm

The checkboxes under the Validator section don't seem to save between permalinks/sessions. Is this by design? (Because I would expect if I uncheck "Exclude non-drivables and streets" that it would stay that way.
Wiki Resources: Map Editing Manual | alanoftheberg@gmail.com
Oregon-based US Country Manager | iPhone6 - VZ - iOS 9.3.2 | Waze v4.7.0.1
AlanOfTheBerg
Waze Global Champs
Waze Global Champs
 
Posts: 23478
Joined: Sat Aug 28, 2010 8:48 pm
Location: US Country Manager - Oregon, USA
Has thanked: 1084 times
Been thanked: 4594 times

Re: [Script] WME Validator 0.4.2 (BETA) / 07.07.2014

Postby SuperDave1426 » Wed Jan 08, 2014 4:51 pm

Just installed this tool, and am really liking it so far. Now I can even spot something I goofed on before I get a note from my RC telling me, "You goofed on this part over here...." :lol:

One thing I've noticed, and I don't know if it's something that can be done anything about or not: When I click on a segment that flashed, sometimes after fixing and saving, it will stop flashing when I move the map, and other times, I have to click on the segment again for it to realize that the segment was fixed. One example that comes to mind is the dead-end U-Turn indicator. I can fix it and save it, but if I move the map a bit, it will continue to flash the segment. If I select the segment again and then click somewhere else to deselect it, it then stops flashing that segment as a problem.
ImageImageImageImage
Country Manager: USA (mostly oriented around NV & CA)
Editor Guide Best Editing Practices Editor Quick-start
Places Guidelines Nevada Wiki
SuperDave1426
Country Manager
Country Manager
 
Posts: 802
Joined: Wed Oct 16, 2013 5:27 pm
Location: Nevada, USA
Has thanked: 74 times
Been thanked: 227 times

Re: [Script] WME Validator 0.4.3 (BETA) / 08.01.2014

Postby berestovskyy » Wed Jan 08, 2014 5:20 pm

AlanOfTheBerg wrote:Request: Add detection of segments which share the same two endpoints: https://www.waze.com/editor/?zoom=6&lat ... 4,61233176

This is known to cause routing errors and incorrect start-point display issues in the app. Also can cause the "requested route" information for Update Requests to show the wrong segment.

Need more info here. At the moment the "Unneeded node A/B" reports are disabled.

AlanOfTheBerg wrote:I'm seeing the validator highlight/flash a LOT of segments, but when I click on them, nothing is shown.

Fixed in 0.4.3.

davidg666 wrote:1. both of those roundabouts you mention above are correct (clockwise), even though one runs A->B and the other runs B->A.

You are right. Please check the new "Inconsistent roundabout direction" report which just checks adjacent roundabout segment directions and reports if they are different.

khaytsus wrote:I've tried disabling all other scripts, yet this one still doesn't seem to "validate" anything. It shows up, I click the Play button, it pans around, finishes scanning, then nothing. No report (button stays greyed out).

There is a chance you have a perfectly mapped area ;)

AlanOfTheBerg wrote:Script has the wrong forum URL for "Website."

Fixed in the script, on userscripts etc.

AlanOfTheBerg wrote:The checkboxes under the Validator section don't seem to save between permalinks/sessions. Is this by design?

Yep, that was the idea :lol: In 0.4.3 there are just 2 default options: non-editables and duplicates. Let me know if it's ok now or shall I store the values across sessions.

And the same with the settings: there are just 2 persistent options...

SuperDave1426 wrote:When I click on a segment that flashed, sometimes after fixing and saving, it will stop flashing when I move the map, and other times, I have to click on the segment again for it to realize that the segment was fixed.

There is an internal segment cache. Validator revalidates only new, selected or unselected segments. Please try 0.4.3, there some changes in highlighting. Please report if the problem is still there.

0.4.3 is published. See my original post for the download links or force update in your browser.
berestovskyy
 
Posts: 925
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 254 times
Been thanked: 693 times

Re: [Script] WME Validator 0.4.3 (BETA) / 08.01.2014

Postby SuperDave1426 » Wed Jan 08, 2014 5:22 pm

Ok, there's one other kind-of odd thing I've noticed. This segment of road is effectively a loop road, yet the validator is flashing it as having unneeded nodes A and B. Is that something which can be fixed, or is it too hard for the script to be able to figure that out and we just have to know that it should be ignored in this case?
ImageImageImageImage
Country Manager: USA (mostly oriented around NV & CA)
Editor Guide Best Editing Practices Editor Quick-start
Places Guidelines Nevada Wiki
SuperDave1426
Country Manager
Country Manager
 
Posts: 802
Joined: Wed Oct 16, 2013 5:27 pm
Location: Nevada, USA
Has thanked: 74 times
Been thanked: 227 times

PreviousNext

Return to Addons, Extensions, and Scripts

Who is online

Users browsing this forum: No registered users