[Script] WME Validator 2020.04.12 (PLACES BETA)

Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Moderators: Unholy, bextein, Glodenox, JustinS83

Forum rules
Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

DO NOT START a new thread unless it is about a new idea. Keep discussion of existing tools within the main thread for that tool.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Re: [Script] WME Validator 0.9.4 (BETA) / 30.03.2014

Postby berestovskyy » Mon Mar 31, 2014 8:05 pm

Hi!
Got few new ideas, so I request for comments.

1. No road continuation (for Primary Streets and up)
Report/highlight the segment if at the node:
a) this segment's road type is the highest among the segments at the node
b) and there is another segment with the same road type and street name
c) and that another segment is not marked as closed
d) and the connectivity between those two segments is possible (road directions), but not enabled


2. No right* turn (for any drivable road)
* for the right-hand traffic
Report/highlight the segment if at the node:
a) there is a 90±5° right turn
b) and that right turn segment is also drivable
c) and that right turn segment is not marked as closed
d) and the connectivity between those two segments is possible (road directions), but not enabled


3. Geometry points are too close (for any drivable road)
Report/highlight the segment if:
a) the segment is a dead-end
b) and it has more than 2 geometry points
c) and the dead-end geometry point is very close (2 m?) to another point of the same segment
Here is an example posted on this forum some time ago: permalink

Any comments/suggestions?
berestovskyy
 
Posts: 897
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 327 times
Been thanked: 821 times

Re: right turn should be allowed

Postby berestovskyy » Tue Apr 01, 2014 6:18 am

sketch wrote:Wait, I have a problem with the "no right turn" check. Wouldn't it call for erroneous enabling of turns like the right turn from this segment?


Ok, how about that:
2. No right* turn (for any drivable road)
* for the right-hand traffic
Report/highlight the segment if at the node:
a) there is an up to 85° right turn
a1) and either this segment OR that right turn segment is longer than 300m (~1000 ft)
b) and that right turn segment is also drivable and non-private
c) and that right turn segment is not marked as closed
d) and the connectivity between those two segments is possible (road directions), but not enabled

Would that new a1) condition be sufficient to detect connectors and other possible exceptions?

BellHouse wrote:I don't get the idea behind 2.

The idea is that in right-hand traffic countries the right non-acute turns are mostly enabled except some rare situations. So we can assume that disabled right turn is an error.
berestovskyy
 
Posts: 897
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 327 times
Been thanked: 821 times

Re: [Script] WME Validator 0.9.4 (BETA) / 30.03.2014

Postby berestovskyy » Tue Apr 01, 2014 8:35 pm

Please welcome one more language:

Localization and translation package* for Germany by BellHouse:
For Chrome browser: Chrome Web Store
For Firefox/Greasemonkey/Tampermonkey: userscripts.org
* Note: you also need the main package installed.

The package will be useful for any German-speaking editor, since it translates user interface, problem descriptions and solutions (once you switch WME into German), while applies the rules of the country you are using it in.

Many thanks to BellHouse for the great job!

If you would like to translate Validator into your language, please have a look at this forum post
berestovskyy
 
Posts: 897
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 327 times
Been thanked: 821 times

Re: [Script] WME Validator 0.9.4 (BETA) / 30.03.2014

Postby berestovskyy » Wed Apr 02, 2014 5:55 am

sketch wrote:check out Street View on the service road at Aurora and Orion here — to prohibit drivers from cutting through the neighborhood when exiting the Interstate.

Wow, very nice and rare example. I just wondering how can we detect such a situation... A turn from a Ramp/Highway to the regular street or lower? Any ideas?

Although the map is perfectly correct, there are few possibilities to suppress the warning in Validator at the moment:
1. Add a 24/7 time based turn restriction from highway to the street.

2. Make an exiting piece of the screet one way.

3. Make the screet private.

I know it's ugly but a tempory solution. So, shall I exclude inward connectivities warnings for the turns from highways/ramps to streets/parking lots/dirts?
berestovskyy
 
Posts: 897
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 327 times
Been thanked: 821 times

Re: [Script] WME Validator 0.9.4 (BETA) / 30.03.2014

Postby berestovskyy » Fri Apr 04, 2014 4:18 pm

lg1992 wrote:Are there plans to enable checking for invalid elevation? If not, can I enable this checking just for me? If not, what's the correct rule to define custom condition for that?

Sorry, I couldn't reproduce the issue in my environment, so there is no plans to re-enable it unless someone ask me to. But sure you can use custom check to find null elevations.

Click Settings->custom and in "Custom template" field put:
Code: Select all
${elevation}

In the "Custom RegExp" field put:
Code: Select all
null
berestovskyy
 
Posts: 897
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 327 times
Been thanked: 821 times

Re: [Script] WME Validator 0.9.4 (BETA) / 30.03.2014

Postby berestovskyy » Mon Apr 07, 2014 9:17 am

No worries, Validator is a read-only tool. At the moment it's dozens of files/~15K lines of source code project roots in WMET, so I never paid attention to those messages. And frankly, I have no idea how did you get into that part of legacy code :lol:

But sure, it will be fixed in the next release.
berestovskyy
 
Posts: 897
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 327 times
Been thanked: 821 times

Re: [Script] WME Validator 0.9.4 (BETA) / 30.03.2014

Postby berestovskyy » Mon Apr 07, 2014 11:19 am

petervdveen wrote:Question about the error 'too short segment'.

It's a per-country setting and by default Validator reports 'too short segment' if a segment is 2m long or less. The check also skips dead-ends and roundabout segments.

There is also a group if checks, which skips less than 6m long segments:
#44 'No outward connectivity'
#102/#103 'Node A/B: No outward connectivity'
#107/#108 'Node A/B: No connection'

So by default there is a gap for the 3-5m long segments, i.e. you don't get them reported as too short nor Validator thoroughly checks their connectivity.

It's made on purpose after I scanned few capitals in Europe and found too many false positives at complex intersections. There was no reliable way to exclude those false positives, so I decided to make the gap. It's in my todo, but I haven't managed yet to get back to the issue.

Let me know if I shall increase the value for the too short segments for BeNeLux.
berestovskyy
 
Posts: 897
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 327 times
Been thanked: 821 times

Re: [Script] WME Validator 0.9.4 (BETA) / 30.03.2014

Postby berestovskyy » Mon Apr 07, 2014 1:14 pm

Here are few examples of too short segments in Amsterdam to illustrate what I mean:
permalink1
permalink2
permalink3
permalink4

And tons of regular streets like this:
permalink
berestovskyy
 
Posts: 897
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 327 times
Been thanked: 821 times

Re: [Script] WME Validator 0.9.5 (BETA) / 07.04.2014

Postby berestovskyy » Mon Apr 07, 2014 8:48 pm

07.04.2014 v0.9.5:
- Validator now skips locked segments, so the locks may
be used to hide issues for low-level users.
- New faster 'Show report' method (Chrome only)
- Layers param in permalinks in report

- Updated Spanish translations thanks to robindlc
- Updated #109 'Too short segment': 5m by default
(6m for BeNeLux) + wiki link added
- Updated #79 'Too short U-turn connector' to report
only same road types
- Updated #24 'Might be incorrect city name' for
Строитель снт vs Строитель 2 снт

For localization packs:
- Configured check parameters are listed now in
'Settings->About->Available checks'
- New params to override default check description:
'titleEN', 'problemEN' and 'solutionEN'
- Fixed custom check ${deadEnd} variable for off-screen
nodes
- Fixed custom check ${softTurns} variable

Checks review:
I'm reviewing all the checks, removing unused, merging similar checks, adding params to some checks, splitting nodes A/B etc. So in this release:
Code: Select all
  All "option1" properties changed to params/regexp
  Changed check ID #10 -> #9
  Split check #40 'Soft turns' -> #200 and #300
    'Node A/B: Unconfirmed turn on minor road'
  Split check #86 'Soft turns on primary road' -> #201 and #301
    'Node A/B: Unconfirmed turn on primary road'
  Removed #49 and #111 (Roundabouts)
  Added params for #73 'Too short street name'
    and #109 'Too short segment'
  Added new checks to validate street names:
    #160 Freeway name (merged #61 and #80)
    #161 Major Highway name (merged #53, #60 and #81)
    #162 Minor Highway name (merged #82)
    #163 Ramp name (merged #54, #64, #89 and #113)
    #164 Primary Street name
    #165 Street name
    #166 Parking Lot Road name
    #167 Railroad name (merged #58)
    #169 any type street name (merged #55, #56 and #123)
    #170 'Lowercase street name' (merged #93, #94)
    #171 'Incorrectly abbreviated street'
      (merged #26, #51, #68 and #88)
    #172 'Unneeded spaces in street name' (merged #30)
    #173 'No space before/after abbreviation' (merged #32)
    #174 'Street name spelling mistake' (merged #100)
    #175 'Empty street name' (merged #98)
  Added new checks to validate street types:
    #70 must be a Freeway (merged #83)
    #71 must be a Major (merged #62 and #84)
    #72 must be a Minor (merged #63 and #85)
berestovskyy
 
Posts: 897
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 327 times
Been thanked: 821 times

Re: [Script] WME Validator 0.9.5 (BETA) / 07.04.2014

Postby berestovskyy » Tue Apr 08, 2014 6:02 am

kentsmith9 wrote:I propose the validator identify these segments without a state.

Sure, will be added. Meanwhile you can click Settings->custom and put into the "Custom template" field:
Code: Select all
${state}

then put in the custom RexExp field:
Code: Select all
^$

And you will get those empty states highlighted for you.

irowiki wrote:Wait, I thought locked segments were already excluded?

They were excluded by default with "Exclude non-editable segments". Now the locked segments are excluded always.
berestovskyy
 
Posts: 897
Joined: Fri Jul 15, 2011 1:50 pm
Has thanked: 327 times
Been thanked: 821 times

PreviousNext

Return to Addons, Extensions, and Scripts

Who is online

Users browsing this forum: jm6087, n4dog