[Script] Live Map UR Layer v2.24 (20160202)

Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Moderator: Unholy

Forum rules
Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

DO NOT START a new thread unless it is about a new idea. Keep discussion of existing tools within the main thread for that tool.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Re: [Script] Live Map UR Layer v2.7 (20140223)

Postby Twister-UK » Sun Feb 23, 2014 12:10 pm

2.7 finally includes support for UR comments... With one exception, all of the comment-based filtering options present in URO+ are now also present in LMUR. I haven't included support for the "show/hide URs I'm following" filter, due to the amount of extra data I'd need to pull across from the WME server just to get the data required for that filter.

Comment filtering is only possible when the user is logged-in to the Livemap server, and so I've taken the decision to require the user to be logged-in in order to enable LMUR at all, as this makes the behind the scenes operations a lot cleaner. As with the requirement to be on the secure Livemap server, if you're not logged-in then it'll be pretty obvious...

I've also tweaked the way the script handles its local data cache, to reduce the number of times it reloads data from the WME server - this not only makes life easier for the server (especially now with the extra access calls required to get the comments data), but it also improves Livemap responsiveness when panning/zooming within the already cached area. One side-effect of this change is that LMUR will now only auto-refresh the central 1x1 degree region every 60s, whereas previously it would auto-refresh the central 3x3 degree region.


Firefox+Greasemonkey version: http://userscripts.org/scripts/show/150276
Chrome Web Store version: https://chrome.google.com/webstore/deta ... niefljookp
L4 AM for NW London and Shetland Islands - HTC One M8/Android 5.0.1
WME/Livemap enhancement scripts @ GreasyFork and Chrome Web Store
Image
Twister-UK
Area Manager
Area Manager
 
Posts: 1784
Joined: Sat Jan 07, 2012 12:00 am
Location: NW London
Has thanked: 229 times
Been thanked: 1400 times

Re: [Script] Live Map UR Layer v2.7 (20140223)

Postby ditchi56 » Tue Feb 25, 2014 11:02 am

Twister-UK wrote:2.7 finally includes support for UR comments

Many thanks. Just one gripe / bug report:

I think "hide if last comment made less than nn days ago" should only hide UR's which do actually have a comment. At present it's hiding UR's with no comment too (presumably only if they're less than nn days old, although I haven't checked this).
ditchi56
Country Manager
Country Manager
 
Posts: 3167
Joined: Tue May 29, 2012 12:35 pm
Has thanked: 537 times
Been thanked: 1172 times

Re: [Script] Live Map UR Layer v2.7 (20140223)

Postby Twister-UK » Tue Feb 25, 2014 1:59 pm

ditchi56 wrote:
Twister-UK wrote:2.7 finally includes support for UR comments

Many thanks. Just one gripe / bug report:

I think "hide if last comment made less than nn days ago" should only hide UR's which do actually have a comment. At present it's hiding UR's with no comment too (presumably only if they're less than nn days old, although I haven't checked this).


Oops... This is due to the way the marker objects get initialised - the comments data is loaded seperately to the main marker data, so I have to initialise the comment parameters with safe defaults first, and then fill in the correct values once the comment data is available. However, for markers that don't have comments, the safe default values are then left untouched. And it just so happens that the safe default value for the "last comment age" parameter is such that, if I then forget to disable the comment filters for URs that don't actually have any comments (and yes, that's exactly what I've done), the "hide less than n days" filter triggers regardless of how many days are set as the threshold and, as if by magic, the UR disappears...

I'll roll out a fix for this soon.
L4 AM for NW London and Shetland Islands - HTC One M8/Android 5.0.1
WME/Livemap enhancement scripts @ GreasyFork and Chrome Web Store
Image
Twister-UK
Area Manager
Area Manager
 
Posts: 1784
Joined: Sat Jan 07, 2012 12:00 am
Location: NW London
Has thanked: 229 times
Been thanked: 1400 times

Re: [Script] Live Map UR Layer v2.7 (20140223)

Postby ditchi56 » Sat Mar 08, 2014 5:15 am

A bug, although I shan't be surprised if it turns out to be in Waze code rather than your script...
This UR has one comment, a fact which WME recognises. However LMUR continues to show it has having no comments.
ditchi56
Country Manager
Country Manager
 
Posts: 3167
Joined: Tue May 29, 2012 12:35 pm
Has thanked: 537 times
Been thanked: 1172 times

Re: [Script] Live Map UR Layer v2.7 (20140223)

Postby Twister-UK » Sun Mar 09, 2014 7:54 pm

Odd, LMUR is definitely getting the correct data back from the server for this UR, and I can't see anything different about the data format that might throw off the comment handling code. Will have to spend a bit of time digging into this one...
L4 AM for NW London and Shetland Islands - HTC One M8/Android 5.0.1
WME/Livemap enhancement scripts @ GreasyFork and Chrome Web Store
Image
Twister-UK
Area Manager
Area Manager
 
Posts: 1784
Joined: Sat Jan 07, 2012 12:00 am
Location: NW London
Has thanked: 229 times
Been thanked: 1400 times

Re: [Script] Live Map UR Layer v2.7 (20140223)

Postby Twister-UK » Mon Mar 10, 2014 1:33 pm

Problem solved... There are two URs with almost identical co-ords here, one of which has comments and one of which doesn't, and it's simply a case that WME and LMUR are rendering the markers in opposite orders. Use of the appropriate filtering options in either LMUR or URO allows the other UR marker to become visible/selectable.
L4 AM for NW London and Shetland Islands - HTC One M8/Android 5.0.1
WME/Livemap enhancement scripts @ GreasyFork and Chrome Web Store
Image
Twister-UK
Area Manager
Area Manager
 
Posts: 1784
Joined: Sat Jan 07, 2012 12:00 am
Location: NW London
Has thanked: 229 times
Been thanked: 1400 times

Re: [Script] Live Map UR Layer v2.7 (20140223)

Postby foxitrot » Mon Mar 10, 2014 3:31 pm

That's the way URs can be teasing you ;-)

Sent from a touch display, which took care of perfectly scrambling my thoughts.
...with the good old crashing :roll: Symbian 2.1.99.114 (N-E52), while
trying to get used to the good new social Android 3.9.xx.yyy (SG-S3 KikiriKat).
foxitrot
Waze Global Champs
Waze Global Champs
 
Posts: 6383
Joined: Thu Jul 14, 2011 10:22 pm
Location: Slovakia
Has thanked: 1753 times
Been thanked: 799 times

Re: [Script] Live Map UR Layer v2.7 (20140223)

Postby Dev0 » Mon May 19, 2014 11:45 pm

It dosent work anymore?
I have installed it in chrome, but when trying to click the small green arrow then the dialog box opens and closes in the same second, so i can't activate the script?

No UR's is displayed on the livemap, so i guess i have to open this dialog box, but it's just not possible?
Image
| APP Beta-Tester | Coordinator for Danish Translators | WME Beta-tester |
Area Manager: Denmark

WazeDanmark
| Facebook | Twitter | Google+ |
Dev0
Localizers
Localizers
 
Posts: 590
Joined: Sat Apr 19, 2014 5:04 pm
Location: Marstal, Denmark
Has thanked: 106 times
Been thanked: 138 times

Re: [Script] Live Map UR Layer v2.7 (20140223)

Postby aka_serge » Tue May 20, 2014 5:03 am

Works fine today in the morning for me.

Отправлено с моего HTC One S через Tapatalk
aka_serge
Waze Local Champs
Waze Local Champs
 
Posts: 880
Joined: Thu Jun 16, 2011 3:51 am
Location: Moscow, Russia
Has thanked: 321 times
Been thanked: 118 times

Re: [Script] Live Map UR Layer v2.7 (20140223)

Postby Dev0 » Tue May 20, 2014 11:56 am

I still cant open the dialog box :-/
Image
| APP Beta-Tester | Coordinator for Danish Translators | WME Beta-tester |
Area Manager: Denmark

WazeDanmark
| Facebook | Twitter | Google+ |
Dev0
Localizers
Localizers
 
Posts: 590
Joined: Sat Apr 19, 2014 5:04 pm
Location: Marstal, Denmark
Has thanked: 106 times
Been thanked: 138 times

PreviousNext

Return to Addons, Extensions, and Scripts

Who is online

Users browsing this forum: No registered users