[Script] WME Validator v2020.11.1 (PLACES BETA)

[Glodenox]

So the addition of the ExtendedSVG renderer fixes the script already? I've just installed the userscript at https://dbcm.github.io/waze/valfix/valfix.js as a userscript on Firefox, but the validator still doesn't seem to work yet here (I've made it so that the fix gets executed before validator).

I'll look into it later if other people say this does seem to fix validator for them.

[Glodenox]

It's just a regular userscript, so I can't see where there would be a difference between TamperMonkey and GreaseMonkey here. Unless there's another bug that is only present on Firefox that hasn't been fixed this way. But I'll look into it closer in a couple of hours.

[Glodenox]

I've been able to get this to work consistently in Firefox after a couple of changes to the code of dbcm. The if statement around the proxy for require was unnecessary and I had to use window.require instead of just require to get it to work with GreaseMonkey. [EDIT: This has now been applied to dbcm's script] I've checked with TamperMonkey and this new version works there as well.

[Glodenox]

Indeed, I had to change the @include rule in WME Validator as well to get it to work on beta because it is still referring to the old "editor-beta" subdomain that has been replaced quite a while ago.

[Glodenox]

In case you want to merge the code, do a pull request.
https://github.com/dbcm/waze/pulls

Double check that works also in Chrome with Tampermonkey

Done, and I had already checked that it still works with TamperMonkey. It wouldn't hurt that other people also verify this, but I've only ever installed my adjusted version of the userscript in TamperMonkey and WME Validator works there, so I'd say it works fine

There is something missing to be able to use in languages other than English, no?

I've just checked it with Dutch and it doesn't work there indeed. There's an uncaught TypeError where the script is trying to access a layers property in the translations.
Adding a very small subset of the "en" translations seems to do the trick, I'll make the change and send another pull request.

[Glodenox]

Heads-up warning: Waze is planning to put the beta version of WME in production tomorrow. This script has a reference to the W.app.modeController object, which has been removed after the removal of the MTE mode. The fix is simple: just remove everything connected to that object as it no longer has any use. This can be done safely in production already.

This script relies on modeController being present at initialization, so it becomes broken in this new version.
EDIT: just noticed the GitHub, I'll quickly fork it and send in a pull request.

[glomp]

DISABLED for US 'More than 55 letters Ramp name'

Can we get this disabled for Australia?

With the work we have done for the addition of road shields, the format used for them can add an extra 7-10 characters to the name of a highway/freeway name. This makes the average length of a highway/freeway name about 25 characters.

With the addition of wording such as "entry to:/exit" and a couple of city destinations, it quickly makes the ramp names quite long.

[goodolsen]

edit again: I do miss the flashing, maybe it's just me! Could it be optional?

I second that, the flashing made it easier for me and took up less real estate on the screen.

[goodolsen]

NM, clearing cache resolved the issue.

[Gregorygf]

I need a Level 5 Map Editor to fix this error. When turning off of Rand Road onto westbound Capri Drive, at the very next intersection with an unnamed road to runs NNW, at that point Capri Drive becomes ONE WAY in the east bound direction. Waze thinks it's a two way street and tries to route me down that street. https://www.waze.com/editor/?lon=-1.318 ... 597&zoom=0