[Script] WME Junction Node Fixer v0.1.3 2016-05-25

Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

Moderator: Unholy

Forum rules
Discussion for the unofficial, community-developed addons, extensions and scripts built for the Waze Map Editor.

DO NOT START a new thread unless it is about a new idea. Keep discussion of existing tools within the main thread for that tool.

The official index of these tools is the Community Plugins, Extensions and Tools wiki page.

[Script] WME Junction Node Fixer v0.1.3 2016-05-25

Postby bgodette » Sun Dec 23, 2012 11:37 pm

Version 0.1.3
This is now a Chrome Webstore Extension
Chrome Webstore
2016-05-25: Patches WME for when linking a new Google Place it returns results from a 2 mile radius first.
2016-04-27: Restricted URLs JNF operates on. Added turning GPIDs into URLs that open the place in a new tab.
2014-12-23: Update to changes in Beta WME. Removes Features reload after successful save, lets see if WME has fixed the stale data problem...

Checks WME's API to make sure used objects and functions exist and are the correct type. This works as long as function argument order doesn't change. Next step is to regex match on function contents to confirm arg order.

Makes cameras visible at zoom 0.
Updates keyboard pan amount by 1/4th the map view height.
Saves and persists turn arrow visibility and clickability between reloads/permalinks.
Saves and persists Full-screen mode.

Hooks into replaces 'q' (Disable All Turns) and does these actions on the selected node:
  • Enables U-Turn and locks all turns at dead-end nodes. Changed Behavior
  • Fixes any self and reverse connectivity issues
  • Converts single node roundabouts (lollipops) and loops into a three segment loop. Any existing house numbers will be associated with the middle segment and MUST BE EDITED after save to update their stop point.
  • If two or more segments are connected to the same two segments, it will split one of them. Same rules as SameNode.js bookmarklet.
  • Terminates dead-ends
  • Makes dead-ends two-way (only if both ends of the segment are visible)
  • Sets the Type of a roundabouts using lowest of two highest rule and sets country/state if needed
  • For UK sets Type of roundabouts using highest type excluding Freeway rule.
  • Removes revcon (turns into wrong-direction of one-way), and selfcon (U-Turns at non-dead ends). Once the app has real support for U-Turns selfconf will be left alone
  • Locks all turns at selected node.
ImageImage
bgodette
Waze Global Champs
Waze Global Champs
 
Posts: 3365
Joined: Wed Jul 06, 2011 8:19 pm
Location: Denver, CO
Has thanked: 101 times
Been thanked: 475 times

Re: [Script] WME Junction Node Fixer v0.0.7.5 Dec 23 2012

Postby AlanOfTheBerg » Mon Dec 24, 2012 12:08 am

A couple other items of note for this script, for clarity:

1. In order to do an actual "Disallow all turns" you must click the button with your mouse. The script only overloads the 'q' keyboard shortcut with this functionality.
2. This will not fix a closed loop (one junction) roundabout.
Wiki Resources: Map Editing Manual | alanoftheberg@gmail.com
Oregon-based US Country Manager | iPhone6 - VZ - iOS 9.3.1 | Waze v4.4.9904
AlanOfTheBerg
Waze Global Champs
Waze Global Champs
 
Posts: 23439
Joined: Sat Aug 28, 2010 8:48 pm
Location: US Country Manager - Oregon, USA
Has thanked: 1080 times
Been thanked: 4553 times

Re: [Script] WME Junction Node Fixer v0.0.7.5 Dec 23 2012

Postby iainhouse » Mon Dec 24, 2012 12:19 am

Fantastic work, sir! I didn't realise quite how much I was relying on this one until the WME update broke it. :D

Now it's working properly, there's a potential problem I came across whilst it wasn't working. I did briefly see what would happen if I re-enabled the script by hacking it: this problem convinced me that was a bad idea, so I stopped using it again. But now it's working, the problem still remains.

I had to rebuild this major interchange because part of the roundabout had turned into a normal road type. If I 'Q' on one of it's junctions, your script turns the whole roundabout into ramps. I've actually set the roundabout to be minor highway, to match the MH connecting on the SE corner.

Your post says that you are using a different rule for UK roundabouts (highest type, excluding freeways), which matches the UK Wiki. However, I'm fairly sure that ramp shouldn't be included in those types.
UK Country Administrator
AM: London (DELETED), S Wales
Waze 3.7.3 • iPhone 4S (iOS 6.1.3) • Chrome/W7x64
ImageImage
UK WikiWaze FAQ
I want to go to a commune in Vermont and deal with no unit of time shorter than a season
iainhouse
Country Manager
Country Manager
 
Posts: 6453
Joined: Mon Jul 23, 2012 5:16 pm
Location: on the road from London to insanity
Has thanked: 1009 times
Been thanked: 3261 times

Re: [Script] WME Junction Node Fixer v0.0.7.5 Dec 23 2012

Postby jasonh300 » Mon Dec 24, 2012 12:21 am

bgodette acknowledged the ramp issue in a private forum and said he'd be back at the computer to fix it in a few hours.
Image
New Orleans, Louisiana, USA
South-Central Regional Coordinator
(LA/MS/AR...contact karlcr9911 for TX/OK related issues)
U.S. Champ, Global Champ
Waze FAQ ... Best Map Editing Practice
Ask me about Louisiana Editors Chat in Google Hangouts!
jasonh300
Waze Global Champs
Waze Global Champs
 
Posts: 7546
Joined: Fri Oct 28, 2011 4:26 pm
Location: New Orleans, LA, USA
Has thanked: 398 times
Been thanked: 965 times

[Script] WME Junction Node Fixer v0.0.7.5 Dec 23 2012

Postby NorfolkMustard » Mon Dec 24, 2012 12:57 am

This script has been great, in conjunction with the colour highlighter script to identify iffy junctions.

Thanks for the full screen save,too. Are you able to save the ordering of the layers, too? I always prefer the GPS later under the roads but it reverts after a refresh/permalink

Cheers
Stu
Local Champ: England wiki | Australia wiki
iOS
NorfolkMustard
Map Editor - Level 5
Map Editor - Level 5
 
Posts: 1131
Joined: Thu Mar 25, 2010 7:44 am
Location: Blighty
Has thanked: 166 times
Been thanked: 316 times

Re: Re: [Script] WME Junction Node Fixer v0.0.7.5 Dec 23 201

Postby bgodette » Mon Dec 24, 2012 12:59 am

NorfolkMustard wrote:This script has been great, in conjunction with the colour highlighter script to identify iffy junctions.

Thanks for the full screen save,too. Are you able to save the ordering of the layers, too? I always prefer the GPS later under the roads but it reverts after a refresh/permalink

Cheers
Might be possible.


It's all my phone's fault for using Tapatalk.
ImageImage
bgodette
Waze Global Champs
Waze Global Champs
 
Posts: 3365
Joined: Wed Jul 06, 2011 8:19 pm
Location: Denver, CO
Has thanked: 101 times
Been thanked: 475 times

Re: [Script] WME Junction Node Fixer v0.0.7.5 Dec 23 2012

Postby ncc1701v » Mon Dec 24, 2012 5:51 pm

In a word, deeelightful. Deep thanks for the new version. I have one occasional problem: now and then the connectivity arrows become translucent and I cannot click on them. I've seen this before with the URL notifier (which I have disabled). It may arise when I toggle in and out of Z (show connectivity) mode a lot.
... and the "v" is for Volvo.
ncc1701v
 
Posts: 547
Joined: Thu Jun 07, 2012 6:08 pm
Location: Ithaca, NY USA
Has thanked: 49 times
Been thanked: 45 times

Re: [Script] WME Junction Node Fixer v0.0.7.5 Dec 23 2012

Postby jasonh300 » Mon Dec 24, 2012 6:04 pm

ncc1701v wrote:In a word, deeelightful. Deep thanks for the new version. I have one occasional problem: now and then the connectivity arrows become translucent and I cannot click on them. I've seen this before with the URL notifier (which I have disabled). It may arise when I toggle in and out of Z (show connectivity) mode a lot.


Hitting A makes the arrows translucent. That's how you keep from clicking on them by accident.

You must've missed it when you read this very important part of the documentation (see the bulleted items about 1/2 way down.
Image
New Orleans, Louisiana, USA
South-Central Regional Coordinator
(LA/MS/AR...contact karlcr9911 for TX/OK related issues)
U.S. Champ, Global Champ
Waze FAQ ... Best Map Editing Practice
Ask me about Louisiana Editors Chat in Google Hangouts!
jasonh300
Waze Global Champs
Waze Global Champs
 
Posts: 7546
Joined: Fri Oct 28, 2011 4:26 pm
Location: New Orleans, LA, USA
Has thanked: 398 times
Been thanked: 965 times

Re: [Script] WME Junction Node Fixer v0.0.7.5 Dec 23 2012

Postby ncc1701v » Mon Dec 24, 2012 7:04 pm

jasonh300 wrote:Hitting A makes the arrows translucent. That's how you keep from clicking on them by accident.

You must've missed it when you read this very important part of the documentation (see the bulleted items about 1/2 way down.

Thanks, I just forgot about that - I've never used it intentionally.
... and the "v" is for Volvo.
ncc1701v
 
Posts: 547
Joined: Thu Jun 07, 2012 6:08 pm
Location: Ithaca, NY USA
Has thanked: 49 times
Been thanked: 45 times

Re: [Script] WME Junction Node Fixer v0.0.7.5 Dec 23 2012

Postby Olestas » Wed Dec 26, 2012 6:20 pm

Thank you for reviving da script!

Can you please add option to correct roads segments with no selected city name and street name? Make them "none"?
Last edited by Olestas on Wed Dec 26, 2012 8:08 pm, edited 1 time in total.
Olestas
Coordinators
Coordinators
 
Posts: 4594
Joined: Wed Mar 09, 2011 7:08 pm
Location: Latvia
Has thanked: 1684 times
Been thanked: 1235 times

Next

Return to Addons, Extensions, and Scripts

Who is online

Users browsing this forum: amynm