[Script] WME MagicWand

[Iridium1]

Confirmed.

It looks like the script is calling a function which is for whatever reason currently not availabe neither in WME Prod nor Beta.
Thus the problem is on the WME side…

[SpeedDzel]

concur…

dialog pop-up “www.waze.com says: Unable to find appropriate control element…”

feeling of helplessness setting in… tinkering Place polygons

[JustinS83]

I tried looking into this. The control that this script uses to add in its additional Place modifications no longer exist in WME. Disable the script until it is brought back.

Since the WME update it is no longer possible to move a Place, and that control is what this script was relying on finding.

[Grid64]

@JustinS83

I tried looking into this. The control that this script uses to add in its additional Place modifications no longer exist in WME. Disable the script until it is brought back.

Since the WME update it is no longer possible to move a Place, and that control is what this script was relying on finding.

but I want to move places!

[aureozb]

@TheGridExe

@JustinS83

I tried looking into this. The control that this script uses to add in its additional Place modifications no longer exist in WME. Disable the script until it is brought back.

Since the WME update it is no longer possible to move a Place, and that control is what this script was relying on finding.

but I want to move places!

me too, what kind of person want us to work in map but don’t move places ?

[SpeedDzel]

oh, we can move places…
by bloodily moving each and every Geo Node (and destroying the neatly formed shape)

without this excellent script, moving and resizing ‘places’ is now a pain in the ( :mrgreen: )

hoping for a miracle (pretty please)

[Olestas]

Broken.

[JustinS83]

@DauserShenkt

@JustinS83

I tried looking into this. The control that this script uses to add in its additional Place modifications no longer exist in WME. Disable the script until it is brought back.

Since the WME update it is no longer possible to move a Place, and that control is what this script was relying on finding.

Did you happen to notice if the Clone feature has been removed by WME?

Pretty sure the clone ability was being provided by a script, URO+ I think.

[wasd42]

Hello, everyone!

Thank you for making me aware of the problem, but I cannot find a solution for ModifyFeature control issue. Previously, I used Waze.map.getControlsByClass(/.geometryediting./i) to find a ModifyFeature control, but now it is gone and there are no obvious (and not-so-obvious) replacement in place.

Any ideas where to find it?

[Olestas]

This not helpful?
https://www.waze.com/forum/viewtopic.php?f=819&t=211626

[bz2012]

When WME Magic Wand is enabled, I get the following error message when I start WME:

www.waze.com says:
Unable to find appropriate control element, script is broken

However, the java console shows no error messages from Magic Wand.

WMEWAL: Initialized
VM23966:69 WME MagicWand init
VM23966:154 WME MagicWand: loading options
VM23934:135 WME LMAO: No alerts in view
VM23893:174

Puzzling.

[aureozb]

@DauserShenkt

@wasd42

Hello, everyone!

Waze.map.getControlsByClass(/.geometryediting./i) to find a ModifyFeature control

Any ideas where to find it?

WMECH old code with same control type

[code]// add current city in to drop-down list
function initCityList() {
var locationInfo = Waze.map.getControlsByClass(‘Waze.Control.LocationInfo’)[0];
if (locationInfo === null || locationInfo.location === null)
return;

var cityName = locationInfo.location.city;
var thisCity = null;
for (var city in Waze.model.cities.objects) {
var cityObj = Waze.model.cities.get(city);
if (cityObj.name == cityName) {
thisCity = cityObj.id;
break;
}
}
if (thisCity === null)
return;[/code]

Latest WMECH latest code for same function

[code]// add current city in to drop-down list
function initCityList() {
var thisCity = Waze.model.segments.topCityID;
if (thisCity === null) return;
var thisName = Waze.model.cities.get(thisCity).attributes.name;

var selectCity = getId(‘_selectCity’);
var cityOption = document.createElement(‘option’);
var cityText = document.createTextNode(thisName);
cityOption.appendChild(cityText);
cityOption.setAttribute(‘value’,thisCity);
selectCity.appendChild(cityOption);
console.info("WME Highlights: Init City list: " + thisName);[/code]

Hope this helps.

i don’t understand, can you please be more specific ?

Many thanks in advance

[paulned]

@Iridium1

Thanks fo the Update!

I am having an issue: Whenever I try to create a landmark by clicking on the map I get an error:
Cannot create landmark, need at least 3 points to create polygon

What do I do wrong?
FYI: Chrome 51.0.2704.84 (latest) is used.

EDIT: This happens using the default “Color Distance” mode, using “Human-Eye”, the browser windows gets unresponsive.

Appreciate your help.

Same problem here. Any info to solve this?

Thanks

[wasd42]

Hey, everyone!
Sorry for the long response! I’ve fixed the script (rotate, resize options) AND finally introduced a proper concave hull algorithm, which means that now landmarks of any complex layout can be created automatically! Thanks, Andrii Heonia (http://stackoverflow.com/users/2561331/andriiheonia) for help!

Error “Cannot create landmark, need at least 3 points to create polygon” means that the script was unable to find enough pixels of the similar colour where you clicked to build a concave hull. Please, try some other point nearby. Also, it happens that the server stops responding to tiles request for some reason, so try to refresh the page.

[Iridium1]

Thanks for having this useful script in the portfolio again.

Two issues I am currently struggling with:

• For me I always get the “Please, try again, no useful points found” status when trying to pick a color.
• I cannot “toggle” back to the green status when clicking on the (activated) red button - only a reload of the page helps.

Can you please confirm or give me a hint what I’m doing wrong (Chrome is used btw.)?

[wasd42]

@Iridium1

• For me I always get the “Please, try again, no useful points found” status when trying to pick a color.
• I cannot “toggle” back to the green status when clicking on the (activated) red button - only a reload of the page helps.?

You are most welcome!

Both issues seem to be connected. As you are using Chrome, would you open the Developer Console (Options -> More tools -> Developer Tools), reload the Editor page, try to use Magic Wand and take a look whether any errors will appear in the console, please?

[Iridium1]

Thanks for your quick reply.

Here’s my console log (no other scripts or extensions are active)

VM12121:55 WME MagicWand init
VM12121:140 WME MagicWand: loading options

After approx. 2 secounds I get:

util.js:211 Google Maps API warning: NoApiKeys https://developers.google.com/maps/documentation/javascript/error-messages#no-api-keys

XA.j @ util.js:211
(anonymous) @ js:136
(anonymous) @ js:53
(anonymous) @ js:50
(anonymous) @ js:53
(anonymous) @ js:109
(anonymous) @ js:50
(anonymous) @ js:109
(anonymous) @ js:50
(anonymous) @ js:109
(anonymous) @ js:50
(anonymous) @ js:109
Tc @ js:52
Sc.cb @ js:109
(anonymous) @ common.js:1

Now clicking the Magic Wand Button (button turns red) and trying to pick a color:

VM12121:770 WME MagicWand algorithm: sensitivity
VM12121:771 WME MagicWand sensitivity: 8
VM12121:772 WME MagicWand simplification: 3
VM12121:773 WME MagicWand landmark type: FOREST_GROVE
VM12121:774 WME MagicWand sampling mask size: 3

Button stays red, nothing more to click, no more output in the console, ony status shows “Please, try again, no useful points found”.

I hope this helps.

[wasd42]

Thanks, Iridium1! The bug should be fixed now, please update to version 2.0.2.

[JustinS83]

Could you update the namespace in the header to point to your greasyfork? Currently it references a bad URL so you cannot click on the link in tampermonkey to load the greasyfork page.

[Iridium1]

That was fast

I tried it with 2.0.2, here are my findings:

• The toggling of the button (red/green) is working now, unfortunatiely I still cannot pick any color (same message).
• Whe trying to use “Human Eye” for the algorithm and clicking on the map to pick a color the browser tab freezes.