[Script] WME Place Harmonizer: Version 1.1, Mar 2016

[anon9558397]

@bmtg

A family issue continues to occupy much of my free time at the moment, but I hope to address the dozen or so bug reports sent in the past month soon, as well as the broken issues from the latest WME update. Thank you for your patience.

Thank you for everything you do, all of the requests are far from as important as family.

[jasonh300]

@johnsninja58

Were there any recent changes to WME, as this morning I am finding that it keeps giving me a missing city error for places, tried quitting browser, restarting still the same issue.

There were some major changes to WME that has left several scripts malfunctioning or completely broken.

[ldriveskier]

@jasonh300

@johnsninja58

Were there any recent changes to WME, as this morning I am finding that it keeps giving me a missing city error for places, tried quitting browser, restarting still the same issue.

There were some major changes to WME that has left several scripts malfunctioning or completely broken.

Until the author can fix it, I found that changing the true/false in lines 3196 and 3197 of the script suppressed WMEPH from complaining about the missing city. It will look as follows after you edit it:
bannButt.cityMissing.active = false;
lockOK = true;

Note that you need to remember to manually check for the city since this modification actually breaks it and remember that you “broke” it this way until the author releases a new update. However, the rest of WMEPH seems to work otherwise.

[JustinS83]

To fix yourself, replace this code (should be on line 3195):
addr.city.isEmpty

With this:
addr.city.attributes.isEmpty

With the recent changes to the cities object, everything was moved under the attributes object.

[jasonh300]

@JustinS83

To fix yourself, replace this code (should be on line 3195):
addr.city.isEmpty

With this:
addr.city.attributes.isEmpty

With the recent changes to the cities object, everything was moved under the attributes object.

Perfect. I had just removed all references to City completely, but it also completely elminated the warning about no city.

[jasonh300]

To expand on the addr.city* being changed to addr.city.attributes*, I did this throughout the entire script. Now, when I hit Web Search, it inserts the city name. But it still won’t autofill the city based on the city attached to the closest street like it used to.

Any ideas on what to change for that?

[JustinS83]

@jasonh300

To expand on the addr.city* being changed to addr.city.attributes*, I did this throughout the entire script. Now, when I hit Web Search, it inserts the city name. But it still won’t autofill the city based on the city attached to the closest street like it used to.

Any ideas on what to change for that?

Everywhere that has city.name will need to be changed to city.attributes.name as well.

[jasonh300]

@JustinS83

@jasonh300

To expand on the addr.city* being changed to addr.city.attributes*, I did this throughout the entire script. Now, when I hit Web Search, it inserts the city name. But it still won’t autofill the city based on the city attached to the closest street like it used to.

Any ideas on what to change for that?

Everywhere that has city.name will need to be changed to city.attributes.name as well.

That didn’t work…anything else that might do that?

[JustinS83]

@jasonh300

@JustinS83

@jasonh300

To expand on the addr.city* being changed to addr.city.attributes*, I did this throughout the entire script. Now, when I hit Web Search, it inserts the city name. But it still won’t autofill the city based on the city attached to the closest street like it used to.

Any ideas on what to change for that?

Everywhere that has city.name will need to be changed to city.attributes.name as well.

That didn’t work…anything else that might do that?

Nothing blatant that I can see. Could be that the UpdateFeatureAddress class isn’t working correctly since the city change, similar to how the getByAttributes method isn’t working since the update. Someone with deeper knowledge of the script might need to dig in.

[n4dog]

We really need to get this one fixed. I use it 100+ times a day.

[jasonh300]

@JustinS83

Nothing blatant that I can see. Could be that the UpdateFeatureAddress class isn’t working correctly since the city change, similar to how the getByAttributes method isn’t working since the update. Someone with deeper knowledge of the script might need to dig in.

Thanks for trying. 20 years ago, I would have combed through the code and figured out how everything works. Now I get a headache just thinking about that.

[jasonh300]

@JustinS83

Nothing blatant that I can see. Could be that the UpdateFeatureAddress class isn’t working correctly since the city change, similar to how the getByAttributes method isn’t working since the update. Someone with deeper knowledge of the script might need to dig in.

It suddenly started working. But I think it’s doing it based on the polygons rather than the adjacent segments. I was in an area that’s probably supposed to be outside of the polygons, but someone added the city names to it, and it didn’t work, but when I got into the middle of the city, it worked.

[tonestertm]

Just wanted to bring this all together in one post, thanks to tortured_1 for the tweaks:

Change an instance of

addr.city.isEmptyto

addr.city.attributes.isEmpty

Change several instances of

addr.city.nameto

addr.city.attributes.name

And, for good measure (though it will only affect those in WME Beta),
change

https://editor-beta.waze.comto

https://beta.waze.com

[n4dog]

The above worked for me.

[Cardyin]

Hi all,

Since Mark still hasn’t had a chance to post an update here is an updated version of the script for in several months, I decided to apply the minor fixes to the latest versions of the scripts:

Place Harmonizer
Place Harmonizer Beta

Since I’m using a different namespace, you will have to uninstall the old version and reinstall this one if you wish to use them. Also, I believe that you must be listed as a beta user in order to use the beta script.

Please PM me or post here if you have any issues.

Thanks!

[t0cableguy]

https://www.waze.com/forum/viewtopic.php?p=1536434

https://www.waze.com/forum/viewtopic.php?f=819&p=1537043#p1537043

Thanks to dummyd2
afaik this restores wmeph’s full functionality as it was before the last wme update.

This is a quick and dirty fix. It will apply globally for WME.
You’ll notice that you’ll probably have to disable toolbox and possibly JNF for the time being. They continue to throw errors.
Other things may continue to be broken. YMMV

Open up tampermonkey/greasemonkey dashboard and create a new script.
Delete everything. Paste the following code

// ==UserScript== // @name WME Fix Scripts // @namespace http://tampermonkey.net/ // @version 0.1 // @description try to take over the world! // @author You // @match https://*.waze.com/editor/* // @grant none // ==/UserScript==

Immediately after this code paste the d2 code in the first link. save.

sort your tampermonkey scripts by load order.
Move this script above all your other scripts.
Refresh WME

This might have to be removed in the future as we can integrate the wrapper script in the 2nd link.

[RussPA]

@t0cableguy

https://www.waze.com/forum/viewtopic.php?f=819&p=1537043#p1537043
afaik this restores wmeph’s full functionality as it was before the last wme update.

It would be nice to have WMEPH back, but how do we non-scripters apply those fixes?

[t0cableguy]

Post merged with “link” post ^^^ two posts up. Added HOWTO on globally applying the D2 script to WME in the first link provided.

[RussPA]

OK, got that part working. But now I can’t select places, H key doesn’t work, JNF gives an error. Going to take some trial and error to see what this fixed and what it further broke, hopefully it fixed more than it broke. I’ve had Toolbox disabled since the WME update. But thanks for the help to get that installed.

[t0cableguy]

Turn off toolbox in your extensions.Turn off jnf also.
Jnf has been integrated into toolbox for quite some time. so if that is still throwing an error I think you might still have toolbox enabled somewhere.

JNF might be the part that is breaking everything else, which is why i suggest disabling it if you have it installed separately.

sorry russ… it would help if i read before I reacted…