[Script] WME Toolbox 1.9.0 - 1.9.29 (New thread linked below and on last page)

If there are junctions that toolbox considers unneeded they should be deleted. Same to geometry. And loops should also be fixed … All of this before saving.

So, it would be interesting to have only one button that performs all the following four steps: suppress unneeded junctions > suppress unneeded geometry > auto add node(s) to loops > SAVE

It would save me a lot - really a lot - of clicks … :wink:

Thanks

While that sounds good on the surface, I absolutely wouldn’t want them all combined into one button. First, I wouldn’t necesarily want to do all three operations on a whole screen I have open at the same time. But, more importantly, I absolutely wouldn’t want it to autmatically save. When I use any one of those buttons (well, not the suppress unneeded geometry because that’s limited to GC here and I’m not a GC), I look over all of the proposed changes to decide if they’re what I expected before I save the changes. If it’s not, I can undo. If it did auto-save, I’d have to spend more time hunting around to see if I agreed with the changes before moving on.

I agree completely. Even after 5+ years editing, I am still occasionally surprised by the result of a simple mouse click. :smiley: The last thing I would want would be an automatic save before I had time to review the changes.

While combining those functions into a single click is not difficult (I say that tentatively as I haven’t tested if a certain order of those actions may cause some kind of precedence or action error), I will never in any of the scripts I own or work on include an auto-save function. Regardless of rank/role. I don’t put such a feature in any I write for myself, and wouldn’t do it for any I share.

The risks far out-weigh the benefits. There is a keyboard shortcut for the save function that can help save some time, I’d suggest using that with auto-fix tools to speed up certain tasks.

Good afternoon.

Okay, I agree that the “save” option can be questionable. :slight_smile:

But think this way: if you make an edition and after saving TB shows a point that can be deleted, will you delete it or leave it?

Also: if you make an edition and after saving TB says that a segment can be simplified, will you simplify or leave it that way!?

Again: for loops … will you fix it or leave it?

On my normal editions I found myself putting everything okay (fine and shine) and, before saving, I click on each of those 3 buttons in order to “clean any mess” that can be cleaned (mainly those suppress unneeded junctions and suppress unneeded geometry buttons). Only after I make a save. I’m not talking of editions in zoom 2, 1 or 0. I’m talking of editions on a bigger zoom – mainly when adjusting segments to satellite image, creating new small roads … After such type of editions, it is normal to have to make some cleaning … and for me, those 3 buttons are almost like … say … CCleaner: it cleans some “garbage” that you left behind.

In the end, such functionality could be only available on a bigger zoom.

The idea is to optimize a repetitive action, and honestly, I do not see any problem on applying these 3 functionalities before a standard save.

The suggestion to include a “save” would be almost like a replacement of the standard save button: if you click on the standard save button you know that you want to save, right!? So, if you will click on the new suggested save button you also know what you want to do.

The suggestion was to make a save button, that intends to be a “normal” save, but immediately before saving it would clean all the “garbage" that such 3 functionalities allow cleaning!

But, again, if you see that a save can be problematic, forget the save suggestion.

It is just an idea… not a demand. :wink:

Thanks for your time and your great work with this tool

Ah, I understand now. Although it’s a good idea and could potentially save a lot of time (like you mentioned) I foresee it being a potential source of trouble still.

For instance, as part of those auto-fix functions there is one to correct unterminated roads. This is an issue you see less and less as time goes on and the map matures, but it’s meant to fix an issue where some segments in the database didn’t have a node at one end. This can be mistakenly replicated today by having a long segment with one end off screen. WME still has loading issues and this is exacerbated exponentially by the more scripts you have enabled and processing as data is loaded into the window. This all leads to TB falsely assuming that some one-way segments are really unterminated roads and switches them to two-way without the editor intending that outcome.

Now this is something I’ve been trying to work on (ok - time constraints mean that I’ve spent maybe 15 minutes on it) but so far don’t have a good solution. And this is only one example, others may exist and things change in WME that result in different outcomes all the time.

In short - although a great idea, it’s not too far off from an “auto save” function, just in reverse. Instead of saving after edits, it jams edits in right before the save. And with the potential for many issues as a result, I don’t think it’s a smart direction to take the script.

I do thank you for the suggestion and am happy to discuss any others anyone has.

Thank you SkiDooGuy for your time and answer. :slight_smile:

My English is not so good so, sometimes, I struggle to make me understood in this that is not my main language.

My suggestion was from a user point of view. Unfortunately, scripts and its own “language” is not something I understand. So, it’s kind of normal to be suggesting something that may have more consequences than the ones I’m aware of. :roll:

I’m aware of this problem, and it happens a lot to me. In the end, by having knowledge of this, I almost always try to check both ends of the new segment in order to confirm if it’s really connected (or try to make zoom out before saving to make sure everything goes okay with the save). But like your amazing script, there is another one that you also know: Magic. With this script I’m immediately alerted of the “no connection” problem.

My suggestion is a consequence of the Falcon functionality: it’s known that now there is a higher need to make a split of segments (transforming one segment with two directions in two segments with one direction to each way). To do this, my normal procedure is almost mechanical: I make the split of the existing segment, then I click to suppress unneeded junctions. After such click, almost always, it results in a segment with unneeded geometry. So, the first unneeded junctions button results - almost always - in the need to use the second unneeded geometry button. After all these editions, it comes the Save …

Well, this was a suggestion. Who knows it may give you any new idea(s) :slight_smile: … or to anyone else more capable to express their ideas in English. :lol:
(who knows … it can be possible to, at least, aggregate firstly the suppress unneeded junctions and secondly the suppress unneeded geometry in one button)

Again, thank you for your time and work.

Suggestions are always appreciated, sometimes the script writer may not even think of something until it is mentioned in a suggestion.

One issue I would have with autofixing unneeded junction nodes is that there are times the junction node is there intentionally.
For example. If I am dividing a road, I will cut the segment in half so I can complete the divide. Many times I save in between these steps to prevent possible issues from creeping up on me or I cut a bunch of segments, save, and then work on my divide project.

If the junction node is automatically deleted (even without an autosave), it could undo the work I am preparing to do.

Thank you!

Bumped on a peculiar issue - when fixing reverse connections on segments connected to roundabouts, the roundabout Road Type is altered too…!

In the beginning I thought the road type drops one step (MH to mH/PS to St etc), but while trying to reproduce one mH roundabout changed to Ramp. I can’t reproduce it consistently, but here are some examples. I think it breaks when a roundabout has 7 segments or more connected.

Reproduced:
Permalink 1
Permalink 2
Permalink 3

Not able to reproduce:
Permalink 4
Permalink 5

Just wondering what the latest is with the simplify segments button. It’s been missing for a while and I thought it was fixed but maybe I’m getting confused with the highlighting?

It appears to be working for me.

According to the WMETB Country Settings for Australia, the Simplifiable segments highlight should be available for L5, L6, L3 w/ AM, or CM (which should cover you)

The AutoFix option should be available when a segment is selected for L5, L6, L3 w/ AM, or CM (which should also cover you)

Same with me: it’s working properly.

Still happens btw.

It is actually lowering the RA to the lowest connected segment type (except PLR) when there are equal amounts of each type.

In my first GIF, the RA is connected to 2 mH, 2 MH, 2 FWY, and 1 PLR segments and it gets lowered from MH to mH.

In the second GIF, the RA is connected to 2 PS, 2 MH, 2 FWY, and 1 PLR segments and it gets lowered from MH to PS.

And the last GIF, the RA is connected to 2 PS, 4 MH, and 1 PLR segments and it does not get lowered.

Thanks for checking :slight_smile:

I used to have it (AM with L4 is ticked in the Aus spreadsheet) but it disappeared some time since the Falcon Map Raid.

I have reinstalled the Chrome plugin and also checked in Firefox but it is still missing.

Anything else that can be checked? It was my most used tool and I am really missing it :frowning: It is possible it disappeared when I moved up to L4. A permission problem maybe?

I will check into this today. (My today which is just beginning)

There are several issues with roundabouts and any function that messes with turns. I have to rewrite the section that deals with RAs as the way it stands there is no easy quick patch. Unfortunately it’s several hundred lines long and I just haven’t had time to sit down and work through it. I’ll try to make some time to do so this week.

Hey all, I accidentally uploaded a beta version to the production version of Toolbox in the Chrome store last night.

There are no major changes, so thankfully everything should work fine still, the name will just say beta in it. I’ll get a correct version uploaded later today.

Sorry about the confusion.

I couldn’t get “Q” to work after the update. Instead of clearing out the RevCon it disabled all turns. Only happened after the update.

Hey, I was wondering if there is a chance to add new box that allowed you to add JB roundabout?

Like the function of adding place roundabout.

Now, after the update in the beta I think this function can be very useful.

Thanks :slight_smile: