[Script] WME Validator v2025.02.26 (+ PLACES BETA)

Map Editors Community Addons, Extensions, And Scripts
1201

Code blue is the integrity check.

If you copy-paste the Validator, try to save it to a file and then load or drag and drop into the Tampermonkey. And vice versa.

1202

I am seeing inconsistencies with custom template/regexp highlighting, This makes it somewhat less useful than it could be for identifying “state smudging”
Test conditions:

  • Chrome 37.0.2062.124 m and 38.0.2125.104 m with all extensions disabled except for Validator

  • blue: template ${state} and two different regexps: !/^Pennsylvania$/ and /Delaware/

  • All filter and search settings disabled/blank
    I chose an editable area in which all streets match both regexps. Most of the visible segments are highlighted, but many are not:

  • If I zoom out to zoom=3, far enough to run a validator scan, blue highlighting is spotty at best. Validator scan does not fix blue highlighting at zoom=3. zoom=4 and higher is required.

  • At zoom=4, panning, zooming, and layer refresh do not cause matching segments to show the blue highlight. Clicking the permalink icon is required.
    The following observations were made at zoom=4 and greater, using the permalink icon before making each observation.

  • Matching Non-editable segments are not highlighted, though “exclude non-editable segments” is disabled"

  • Toggling exclude non-editable segments" toggles highlighting from all segments connected to non-editable segments, and from some contiguous segments not connected to non-editable segments. For example:

I can no longer reproduce the following, which I observed using Chrome 37, with several other extensions enabled.

  • Selecting a highlighted segment without making any edit removes the highlight. Refreshing the layers does not bring the highlighting back. Clicking the permalink brought the highlight back. I did not do thorough testing of zooming, panning, and refresh layers effect on this.
1203

I don’t think this is a problem with Validator, but rather a problem with WME not loading all segment details fully. I notice this most prevalently after saving. If you click on one of these not-highlighted segments, does the highlight show up? Clicking on the segment forces WME to look at the segment info, because it has to display it.

Bookmarklets that operate on everything on the screen will also sometimes make WME load all that info as well. Sometimes, if I run a geometry simplifier bookmarklet, the highlights will then show up.

1204

Unfortunately, WME was not created with Validator in mind, so there are few limitations. If you combine them together it will look like a bug sometimes, but from your description it it sound like a strange but normal behaviour:

  1. WME does not load all of the geometry at zoom levels 0-3. So you see the image of the streets, but there are no geometry, so those streets are not selectable and Validator can’t check/highlight them.

  2. Sometimes there are exceptions to the rule #1. For instance, if you zoom in to lvl 4 and then zoom out to lvl 3, the geometry may be still there, so Validator highlight some of the streets, but not the others.

  3. Out of screen segments are not loaded, but sometimes they are still there when we pan around. Some Validator checks need all of the segments to be loaded.

Plus there are few Validator limitations:

  1. Checks marked with “slow” does not run on zoom level 0-3.

  2. There is a limit of reported segments per check (300). The ‘Clear’ button becomes red and there is a message in the segment’s properties for that. So you can’t report/highlight more that 300 blue custom check segments, you need to click the ‘Clear’ button time to time :frowning:

  3. There is a total number of segments limit (20K). Same, you’ll see the red ‘Clear’ button and the message.

  4. The therm “editable segment” in Validator has a bit stricter meaning: the segment properties should be editable and both of the nodes.

I hope that answers your questions.

EDIT: There is also few “bypasses” in Validator I forgot to mention:

  1. Validator skips all checks for non-editable segments, which were updated after the 2014-05-01. There is a message in the segment’s properties for that. We mark “exceptions” this way.

  2. Validator skips all checks (but overlapping segments) for unconfirmed roads.

  3. Validator skips all checks (but overlapping segments) for construction zones.

1205

After scanning an area with all layers turned off the Validator doesn’t restore the layer of Place updates.

1206

Thank you for the information above. It is a big help to using validator effectively.

I have a couple more questions about custom checks.

  • is a custom check like ${state} !/Pennsylvania/ a slow search?

If I have the “exclude un editable segment” disabled, and am operating at level 6 with fewer than 300 segments on the screen, should a segment which is locked above my level and which matches the custom check be highlighted?

1207

Referencing this thread: https://www.waze.com/forum/viewtopic.php?f=8&t=112938

Is there any way Validator could check for a segment that is in the opposite direction of the ones surrounding it, perhaps limited to minor highways and above? Bugs like the one in the thread above have very significant routing implications and given the lack of user feedback, tracking these down is tedious and difficult to say the least.

1208

That is a great idea, I wouldn’t even want to see it limited to mH and above. It not that common for one-way roads to converge or separate outside of parking lots… but even then, this is something that should be looked at. It’s not like the map would be covered with highlights.

Perhaps an option to ignore roads below “xxxxxx” so PLRs and private roads can be ignored manually.

1209

My thought was that in an area that hasn’t seen the light of an editor it may return a ton of errors on ordinary surface streets where the street directions are all out of whack. Since mH and above would be the most critical to routing, I thought that may be a good start, or at least as you mention, offer some kind of toggle to allow all street types to be considered if you wanted.

1210

True, but we need to have those issues on the local roads brought to our attention as well.
Any editor working with MH would likely be L3+ and would have the understanding that the MH/mH/Primary need attention first.

1211

Hi,

No, custom checks are not marked as slow, so they run whenever all other conditions are met.

There is also few “bypasses” in Validator I forgot to mention:

  1. Validator skips all checks for non-editable segments, which were updated after the 2014-05-01. There is a message in the segment’s properties for that. We mark “exceptions” this way.

  2. Validator skips all checks (but overlapping segments) for unconfirmed roads.

  3. Validator skips all checks (but overlapping segments) for construction zones.

If I understand that correctly, two one-way segments connected at a node and running in opposite directions should trigger “no inward/outward connectivity”. Unfortunately, those checks are not working at the moment :frowning:

1212

Yes, that is what I was describing.

I assume this is something that the latest version of WME broke?

1213

By “locked”, do you mean any lock at all, or just locks past a certain level? Because if it’s any locks, it can be a problem where a segment is locked at level 2, and an inexperienced level 2 editor makes changes after May 2014, but doesn’t clear the problem.

1214

Good point. Sure, Validator skips all the checks if user level is less than segment lock level.

1215

Ok great! So for me it will show all highlights, even if edited yesterday. Just wanted to make sure nothing changed. I like that lower level users can see older locked errors so they can submit an unlock or update request.

1216

Thanks for all the explanations.

I humbly place the following requests for enhancement

  1. The “exclude non-editable segments” item gets a little rename to make clear that this option applies only to streets with a one or more non-editable nodes, even if the segment is not itself non-editable (I can, for example, change the city, name, or state on the segment)
  2. I think there would be value in an option to allow doing checks on segments I cannot edit.
    This way, I can spot an out-of-state road more easily, and quickly move to placing the unlock request to fix the city/state smudging problem, for example.

Thank you so much for a very fine and valuable tool. I’m sorry that the latest WME upgrade has broken revcon and connectivity checks. Such a hassle for you, and such a loss to the editors.

1217

Enhancement request:

Separate the highlights and listings in the report for “one way” and “toll”

We have a BUNCH of split roads, so we have a lot of legitimate one-way, but we have very, very few legitimate “toll” roads and none that are editable by L4 and below.
I am frequently catching the “toll” flag set incorrectly, but Validator is not helpful in locating them.

1218

Feature request:

Allow custom color settings for custom checks in a localization pack. For some checks, it would be nice to have a different color than the standard yellow/gold.

1219

Also, I seem to have lost the “No inward/outward connectivity of a driveable road”
I’m assuming this has to do with the WME changes that changed the attachment the turn restrictions to the junction vs segment (same thing that killed RevCon detections).
I’m hoping that this will be restored soon.

1220

Is there any possibility of detecting reversal on one-way segments on particular street types? The reversal bug is still with us, and it can be very difficult to spot.