[Script] Street to River Plus

jm6087 · March 19, 2021, 11:15am

I am not sure if the script dev is still updating this script but a couple things need updating.

The script still references Waze. which is deprecated and will eventually be removed. (note: script will currently still work without this change since)
All references should be changed to W.
The following line

if (sel.type == "segment" && sel.state == "Insert") {

needs to be changed to

if (sel.type == "segment" && sel.state == "INSERT") {

When I comment/delete these 3 lines, the temporary red road deletes as expected.

if (newRiver.isGeometryEditable()){ Waze.model.actionManager.add(new UpdateSegmentAddress(newRiver, {countryID: city.countryID, stateID: city.stateID, emptyCity: true, emptyStreet: true})); }

// if (newRiver.isGeometryEditable()){ // Waze.model.actionManager.add(new UpdateSegmentAddress(newRiver, {countryID: city.countryID, stateID: city.stateID, emptyCity: true, emptyStreet: true})); // }

juliansean · March 19, 2021, 11:31am

Thanks John! Works great!

jm6087 · March 19, 2021, 11:38am

jangliss:

Nomenclator1677:

Thanks.

It merges on a new river (create one and after, extend it with a new part of the river).

It currently is non working when trying to merge an old one with a new part one.

By “merges on a new river”, do you save between the original part, and the new part you’re extending?

For “merge an old one”, can you tell me the steps to reproduce? I created a road, and clicked on the “Street to River” and clicked save. I noticed it no longer seems to delete the original road segment, so there is a bug there. Once it’s saved, I deleted the road segment, and saved again, then drew the new road segment overlapping the original river, clicked on the Street to River, and it extended as expected. If I don’t delete the road segment that gets left, or don’t save after deleting it, I can sort of reproduce the issue you are experiencing.

I am not able to duplicate either. I have tested with (shown in GIF) and without my above fix (excluding the “INSERT” change)

Nomenclator1677 · March 20, 2021, 6:29pm

What line numbers ? Thanks

juliansean · March 20, 2021, 7:03pm

Try around line 394-396

Nomenclator1677 · March 20, 2021, 8:09pm

Thanks

Patrik-20 · July 28, 2021, 5:10am

Proffa · July 28, 2021, 3:15pm

This fixed the script for me too, thanks

reivaxX162 · October 31, 2021, 10:45pm

Hi. I have just installed this script and attempting to add a river by following the instructions on the first post. However I keep getting the attached error message. Anyone else getting this?
Screenshot 2021-11-01 084453.png

MODERATOR NOTE: places screenshot inline to allow it to show.

jm6087 · October 31, 2021, 10:52pm

Did you draw a new segment and leave it unnamed and selected?

reivaxX162 · November 3, 2021, 5:01am

Hi John,

Thanks for your prompt response. Yes I drew a new street segment and left it unnamed and selected. I also attempted as other options to also put the width and name in, but I also get the same error.

Thanks

Sapozhnik · November 3, 2021, 6:50am

Try this one:
https://www.waze.com/forum/viewtopic.php?p=2103845#p2103845

reivaxX162 · November 7, 2021, 11:30pm

Excellent that one worked for me. Thanks for this

lmlama · January 14, 2022, 5:38pm

Hi, I haven’t used this script for a while. I reactivated it but it doesn’t work, and I can’t find any updates.
Can you give me some information on this?
Thank you

Proffa · January 14, 2022, 7:46pm

Well I use this version but I needed to do the fix in picture and it has worked as expected after that.

lmlama · January 14, 2022, 8:20pm

Thanks, now it works

SeveriorumPatrem · February 27, 2022, 5:46am

Adding myself to the list of users having trouble.

I have 16.07.25 installed.

When I attempt to create a new river or extend an existing one, I get a pop up error: “No unsaved and selected new street found!”

I’ve used this script extensively and am confident I am using it correctly… draw a new segment and activate the script on it immediately before it is saved, etc…

Proffa · March 1, 2022, 6:36am

Have you made the modification to script as mentioned in few comments earlier? Quite simple fix that has worked for me and others.

SeveriorumPatrem · March 1, 2022, 7:28am

I had not looked that close, sorry and thank you. Just saw others struggling and checked that I had the latest version. My bad for not looking closer. Hopefully the script author can make this fix to the source soon. I’ll go edit the script…

Sapozhnik · November 21, 2022, 6:37pm

=====
if you have problem with original script, try to use this fork:

[Script] Street to River Plus

updated 21-11-2022