[Script] Street to River Plus

[Domingues3D]

It works

Thanks @Sapozhnik

[SomozRafa]

Thanks a lot @Sapozhnik, now we can edit again.

Regards

[cruiserccl]

Thanks, @Sapozhnik good job

[Patrik-20]

I have a problem with this version, it has an error on my system!
the error is:
“No unsaved and selected new street found!”

[SomozRafa]

@Patrik-20

I have a problem with this version, it has an error on my system!
the error is:
“No unsaved and selected new street found!”

Hi, Try this fork:
https://github.com/waze-ua/wme-street-to-river-plus-mod/raw/master/wme_street_to_river_plus.user.js

[anon92977492]

@SomozRafa

@Patrik-20

I have a problem with this version, it has an error on my system!
the error is:
“No unsaved and selected new street found!”

Hi, Try this fork: https://github.com/waze-ua/wme-street-t … us.user.js

Only part of the link is showing so it doesn’t work. Can you repost the full link? Thanks.

[SomozRafa]

@Mapman44

@SomozRafa

@Patrik-20

I have a problem with this version, it has an error on my system!
the error is:
“No unsaved and selected new street found!”

Hi, Try this fork: https://github.com/waze-ua/wme-street-t … us.user.js

Only part of the link is showing so it doesn’t work. Can you repost the full link? Thanks.

https://github.com/waze-ua/wme-street-to-river-plus-mod/raw/master/wme_street_to_river_plus.user.js

[Nomenclator1677]

I don’t know why but after corrected the script like said before in here

@jangliss

On line 172 in the script, it is looking for the state to be “Insert”, it should be “INSERT”. Just installed it, and on line 172 I have:

if (sel.type == "segment" && sel.state == "Insert") {

Change it to:

if (sel.type == "segment" && sel.state == "INSERT") {

Refresh WME, and you should be good to go.

I can’t merge an old one with the new one. It is always a new river or canal.

An explanation ?

Thanks(unavailable attachment: Capture d’écran 2021-02-11 à 14.16.13.png)
(unavailable attachment: Capture d’écran 2021-02-11 à 14.15.55.png)

[jangliss]

@Nomenclator1677

I don’t know why but after corrected the script like said before in here

@jangliss

On line 172 in the script, it is looking for the state to be “Insert”, it should be “INSERT”. Just installed it, and on line 172 I have:

            if (sel.type == "segment" && sel.state == "Insert") {

Change it to:

            if (sel.type == "segment" && sel.state == "INSERT") {

Refresh WME, and you should be good to go.

I can’t merge an old one with the new one. It is always a new river or canal.

An explanation ?

Thanks

I’ve not looked at it since asked on the mentioned issue. I cannot think immediately of why changing from Insert (non-working) to INSERT would cause an issue, if you change it back, it probably won’t work anymore at all. There has probably been some other WME changes that have caused some conflicts. I’ll see if I can spare some time later to take a look.

[Nomenclator1677]

Thanks.

It merges on a new river (create one and after, extend it with a new part of the river).

It currently is non working when trying to merge an old one with a new part one.

[jangliss]

@Nomenclator1677

Thanks.

It merges on a new river (create one and after, extend it with a new part of the river).

It currently is non working when trying to merge an old one with a new part one.

By “merges on a new river”, do you save between the original part, and the new part you’re extending?

For “merge an old one”, can you tell me the steps to reproduce? I created a road, and clicked on the “Street to River” and clicked save. I noticed it no longer seems to delete the original road segment, so there is a bug there. Once it’s saved, I deleted the road segment, and saved again, then drew the new road segment overlapping the original river, clicked on the Street to River, and it extended as expected. If I don’t delete the road segment that gets left, or don’t save after deleting it, I can sort of reproduce the issue you are experiencing.

[jm6087]

@jangliss

I created a road, and clicked on the “Street to River” and clicked save. I noticed it no longer seems to delete the original road segment, so there is a bug there.

IIRC, I don’t think it has ever deleted the original road segment, but I could be wrong.

[Nomenclator1677]

@jm6087

@jangliss

I created a road, and clicked on the “Street to River” and clicked save. I noticed it no longer seems to delete the original road segment, so there is a bug there.

IIRC, I don’t think it has ever deleted the original road segment, but I could be wrong.

at a certain moment, it deleted the original segment but not now for a long time

[Patrik-20]

the script no longer working
have you any idea?

[juliansean]

I too found the script not working this morning.

[jm6087]

@Patrik-20

the script no longer working
have you any idea?

A quick question

What is your version number of Street to River Plus?

[jm6087]

If you edit the script in TamperMonkey and look for

sel.state == "Insert"

And change “Insert” to “INSERT”

It might fix the script for you

[juliansean]

@jm6087

If you edit the script in TamperMonkey and look for

sel.state == "Insert"

And change “Insert” to “INSERT”

It might fix the script for you

Thank you! I’ll try that this week!

[BeastlyHaz]

@jm6087

If you edit the script in TamperMonkey and look for

sel.state == "Insert"

And change “Insert” to “INSERT”

It might fix the script for you

I just tried it myself and it works perfectly. Thanks!

[juliansean]

@jm6087

If you edit the script in TamperMonkey and look for

sel.state == "Insert"

And change “Insert” to “INSERT”

It might fix the script for you

The fix works. Thank you!!