This may be a known issue but in setting daily repeating closures, if the timespan goes over a Daylight Saving time switch, the times are shifted incorrectly.
To recreate:
Create daily closures 9am - 3 pm Fri 3/8/24 - Mon 3/11
Other options as you prefer
Save
Results:
Fri + Sat closures will be for 9 am - 3 pm
Sun + Mon closures will be for 8 am - 2 pm
I have not tested the Fall time switch but assume it would act similarly
It would be better to either handle the time change or give a warning and direct user to create a âbeforeâ and âafterâ set of closures.
Gonna be honest with you here, itâs a problem one night every 4 years - we wonât be putting in to to fix it. If someone wants to submit a pull request, we welcome it.
I understand everyoneâs busy, and this is not a critical or breaking issue by any means, I mostly wanted to get it on the radar, and sorry, my JS skills arenât up to coding a change.
Itâs not uncommon for utilities or municipalities to provide advance notice of closures where the closure is every weekday (or every weekend) for a period of weeks. When those closures span one of the 2 time change weekends, WME Advanced Closures does generate a closure that is mostly correct.
OTOH, this feature has existed for years Iâm sure,
I have some changes that I think fix this problem in processing a CSV closures file. I have not submitted a pull request yet. I am going to do some more testing, but if anyone wants to try it and let me know how it works, use the Tampermonkey Import from URL feature with this URL:
Ădit: the editor who test⌠Told me it was OK before waiting for the end, it blocked 6%.
But it can click on the arrow to the right of the line to put the closure manually
Version 2024.04.11.01 should be available now from greasyfork and should fix the error that can occur during applying closures from a CSV file.
In addition, I am now able to merge updates into the wazedev AC repository, which means we wont have to wait for someone to approve any updates that I create for Advanced Closures.