[Script] WME Road Selector Highlights

Map Editors Community Addons, Extensions, And Scripts
41

Currently, highlighting is not working the same in beta as it does in production. When you tell it to highlight, it will highlight the segments in the current display, but when you scroll, it does not continue highlighting; in order to view highlights for new segment, you have to press the highlight button again (instead of it continually highlighting as you scroll).

42

Thanks for reporting an issue! I’m currently still very busy, but I will do my best to take a look as soon as I can.

43

I’m having trouble getting this to go. I just installed Road Selector 1.25, Expression editor 0.3.4.6 and Road Selector Highlights 0.7.8.8. I went to an area with a bunch of basemap, and used this expression: Unnamed AND Road Type != “Private Road” and none of it was selected. The segments are all “No street, No city”

Any ideas about what I’m doing wrong?

Also, is there a way to interrogate for unconfirmed turns?

Thanks.

-Greg G

44

If I understand right what you need to achieve you are in wrong topic :slight_smile: .
The selection is made by WME Road Selector which has its own topic but for now I will give you answer here.

The Unnamed condition means that the segment has not Street and City assigned (so called red segments).
If you want to select empty Street and City use City = “” AND Street = “” condition.

There was no request to select segments with unconfirmed turns till now. Could you specify what you mean more detail but to the right topic.

45

Hi, after the last update of WME Road Selector (1.28) the Highlights script doesnt look correct in Google Chrome.

46

There was a problem with both scripts from TheLastTaterTot. I’ve tried to send her a PM but it is still unread. Therefore I made some hacks to the WME Road Selector to make both scripts working again.

WME Road Selector Expression Editor is OK
In WME Road Selector Highlights was the appearance OK but the script didn’t work.

There is the same problem as in many other scripts after the last WME update. To make the script working it is necessary to comment out the lines 1425 an 1448:

// I18n.translations.en.layers.name.__RSel_Highlights = 'Road Selector Highlights'; // I18n.translations.en.layers.name.__RSel_Highlights_Under = 'Road Selector Highlights (Under)';

47

many many thanks. I use these scripts all the time. thanks.

48

this is the best script ever

but, is not working on beta

49

I had to change Line 7 to // @include https://beta.waze.com/*editor/* in order to get it to work in Beta. It still had the old website.

50

New Problem:
While creating a new highlighter and saving, the new highlighter took the criteria of the highlighter I had just been using (call this the old highlighter for this discussion).
Now the old highlighter doesn’t have any criteria for highlighting. The new highlighter has the “old” criteria.

Worse still is I cannot delete the “new” highlighter.

Patti Help me !

51

Apologies. It looks like with a WME reload that allows me to delete selected highlighters.

Also, it appears that correctly saving the intended highlights is accomplished by clicking on “select roads” with the search criteria set.

thanks again for a great script.

52

I’m experiencing the darkened save screen issue in WME when saving changes to segments (note that 1 segment per save seems to be okay, it’s 2+ that gives a problem) that were/are highlighted at the time of the save. The changes I’m saving should no longer pass the highlighter criteria. I still need to test the theory more, but I don’t seem to have this issue if I clear the highlighters before saving and then reapply afterwards.

In this specific use case, I’m using the highlighter capability to locate segments that need to have their city name changed and I’m also adding an alt city (repeating the street name for the alt name as well). I believe they stay highlighted until I save (despite no longer passing the highlighter criteria), and I’m usually met with the perpetual darkened screen once a save is attempted. At the time I usually see this in the console:

app-b90eda0….js:1 Uncaught TypeError: Cannot read property 'name' of undefined
    at initialize.getAddressDetails (app-b90eda0….js:1)
    at initialize.getAddressDetails (app-b90eda0….js:4)
    at Y.s.serializeData (app-b90eda0….js:18)
    at Y.s._renderTemplate (vendor-dc9e195….js:36)
    at Y.s.render (vendor-dc9e195….js:36)
    at Y.s.onFeaturesChanged (app-b90eda0….js:2)
    at Y.s.onFeaturesChanged (app-b90eda0….js:19)
    at f (vendor-dc9e195….js:2)
    at M (vendor-dc9e195….js:2)
    at h (vendor-dc9e195….js:2)
    at initialize.l.trigger (vendor-dc9e195….js:2)

Almost seems like there could be a problem with an existing highlighter adjusting to the saved data, especially when the segment was highlighted, and now shouldn’t be after changes.

In all cases, the save does go through, which is characteristic of the darkened screen.

Google Chrome (will try a different PC a bit later)
WME Road Selector 1.31
WME Road Selector Highlights 0.7.8.8
WME Road Selector Expression Editor 0.3.4.6

EDIT: Another editor was working the same project and had the same symptoms and solution of erasing the highlighters before saving. I also experienced the same problem on another PC later today.

53

The RSelector is ok, but RS Higlighter doesn’t do nothing

54

pvo11, u need to update the script on Greasy Fork, without these 2 changes the script doesn’t work perfectly

55

This script is not working at all for me any more. RS works fine, but not Highlights.

56

It is true RSel is my script. It has its own thread and I update it after each WME update to keep it working and I add some new features.

The author of WME RSel Highlights and WME RSel Expression Editor is TheLastTaterTot. Unfortunately, she is not updating the scripts any more a she is not answering PMs.
I have no to possibility to update these scripts. The best solution would be to make a fork on greasyfork.org. Can anybody do it instead o posting the changes here? I’m too busy to do it.

The script WME RSel Highlights uses RSel interface and only changes which are needed are caused by WME changes.

The script WME RSel Expression Editor is another case; it uses the RSel buttons and it shoud be updated after each adding new condition to the RSel a of course after some WMW changes. It is not easy task. But I think this script is not so important.

57

Here is a fork with the fixes
https://greasyfork.org/en/scripts/35939-wme-road-selector-highlights

1 Like
58

I use this one all the time, makes it a lot faster for me to change the selection. But it does seem to work still, even if it might not support all the options anymore.

59

it’s interesting to note that RSEL and RSEL highlights were working like always on my mac. But when I went to edit on my tablet, the controls for RSEL highlights were not functional. I installed the fork above and now it works like a champ on the windows tablet as well. Super!

60

Excuse me…
With the recent WME update I have the problem of page 500 error.
It’s actually impossible to access to WME and to all the scripts.
I have migrated to another OS to update the browser but I would like to recover the highlight expression saved in the old OS.
Where the saved highliters could be found? Where the script save them? Consider that I can only access to the hard disk and to the browser, WME not working…

Thanks… :frowning: