Missing string sanitization and merging for street/city names in Edit Suggestions

Is this a…:
Standard bug
Steps to reproduce this issue:
Prerequisites:

  • An account restricted from editing a specific segment.
  • Another account that has permissions to review suggestions in that area, but is limited from creating new cities (by rank, e.g., in Israel this is an L6 action, so you need an account level <6).
  • A target street/city that already exists in the database

Actual steps to reproduce and outcome (2 scenarios):

  1. When trying to use the existing name which is loaded into the data model, it is possible for the user to add white spaces, which won’t be trimmed, causing a new street/city entity in the suggestion.
    Fixed in v2.354.
  2. When trying to use an existing name that is not yet loaded into the data model, the WME submits a new city action and does not merge it in the background and links the edit suggestion to the existing street/city entity.

As a result, editors who aren’t allowed to create new cities in the country of the edit suggestion aren’t allowed to interact with the suggestion at all, even though this issue could’ve been resolved by simple sanitization/trimming and backend aggregation.

Scenario 1 might be a design choice, but it is completely wrong when we talk about new editors. If it is WAD, let me know and I’ll file a suggestion.
Scenario 2 is definitely a bug.

Environment where the bug occurs…:
All environments
Permalink:

  1. The suggestion contains a trailing white space in the city name, causing it not being identified as an existing city - Fixed in v2.354
  2. A village existing in the database but not loaded into the data model

Browser name and version:
Irrelevant
Are you using scripts? Please detail which ones.:
Reproducible without them, too. The response coming back from the backend indicates no permissions on such suggestions.

4 Likes

Hi @r0den,

Thank you for submitting this report and providing such a detailed description.

Both scenarios are indeed bugs, and we have opened two internal tickets to address them.

I will keep you posted on our progress.

Regards,
Nataliia

3 Likes